pengjunjie/sdkjs
1
0
Fork 1
mirror of https://github.com/ONLYOFFICE/sdkjs.git synced 2026-04-07 14:09:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ve] Add shadow offset cell existance check + fix return type comments

Browse Source
This commit is contained in:
Fedor Kobyakov
2025-07-04 13:32:24 +03:00
parent 63c5d4f168
commit f4e51f78ee
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
visio/model/ooxmlApi/convertFunctions.js
View File

@ -2232,8 +2232,10 @@
let shadowOffsetXcell = this.getCell("ShapeShdwOffsetX");
let shadowOffsetYcell = this.getCell("ShapeShdwOffsetY");
let shadowOffsetX_inch = shadowOffsetXcell.calculateValue(this, pageInfo, visioDocument.themes);
let shadowOffsetY_inch = shadowOffsetYcell.calculateValue(this, pageInfo, visioDocument.themes);
let shadowOffsetX_inch = shadowOffsetXcell &&
shadowOffsetXcell.calculateValue(this, pageInfo, visioDocument.themes);
let shadowOffsetY_inch = shadowOffsetYcell &&
shadowOffsetYcell.calculateValue(this, pageInfo, visioDocument.themes);
let shadowOffsetX = shadowOffsetX_inch === undefined ? 0 : shadowOffsetX_inch * g_dKoef_in_to_mm;
let shadowOffsetY = shadowOffsetY_inch === undefined ? 0 : shadowOffsetY_inch * g_dKoef_in_to_mm;
let atan = Math.atan2(shadowOffsetY, shadowOffsetX);

10
visio/model/ooxmlApi/ooxmlApiIndex.js
View File

@ -566,7 +566,7 @@
* Finds shape section by formula. Compares N with string argument. For Geometry use find sections.
* @param {String} formula
* @memberof SheetStorage
* @returns {Section_Type | null}
* @returns {Section_Type | undefined}
*/
SheetStorage.prototype.getSection = function getSection(formula) {
let section = this.inheritedElements[formula];
@ -581,7 +581,7 @@
* Returns link to object not copy.
* @param {String} formula
* @memberof SheetStorage
* @returns {Row_Type | null}
* @returns {Row_Type | undefined}
*/
SheetStorage.prototype.getRow = function getRow(formula) {
let row = this.inheritedElements[formula];
@ -613,7 +613,7 @@
* Let's search cells only directly in Section for now (if called on Section).
* @param {String} formula
* @memberof SheetStorage
* @returns {Cell_Type|null}
* @returns {Cell_Type | undefined}
*/
SheetStorage.prototype.getCell = function getCell(formula) {
// Cells can have N only no IX
@ -682,7 +682,7 @@
* low performance function! use if can't use get section
* @param {String} formula
* @memberof SheetStorage
* @returns {Section_Type[] | null}
* @returns {Section_Type[]}
*/
SheetStorage.prototype.getSections = function(formula) {
// TODO check may be optimized. maybe use getGeometrySections
@ -1354,7 +1354,7 @@
* Returns object of shape not copy!
*
* @memberof Shape_Type
* @returns {Text_Type | null}
* @returns {Text_Type | undefined}
*/
Shape_Type.prototype.getTextElement = function getTextElement() {
let text = this.inheritedElements["Text"];