Fix bug #70332

Convert drawing to inline form when adding picture content control

api.js

@@ -189,6 +189,17 @@ window["AscOForm"] = window.AscOForm = AscOForm;
 			let h = isSignature ? 32 / 72 * 25.4 : undefined;
 			
 			var oCC = oLogicDocument.AddContentControlPicture(w, h);
+			
+			// MSWord can't open files with anchored picture content controls (70332)
+			if (oCC && !oFormPr)
+			{
+				let allDrawings = oCC.GetAllDrawingObjects();
+				for (let i = 0; i < allDrawings.length; ++i)
+				{
+					allDrawings[i].MakeInline();
+				}
+			}
+			
 			let oFormParaDrawing = null;
 			if (oCC && oFormPr)
 			{
@@ -673,6 +684,9 @@ window["AscOForm"] = window.AscOForm = AscOForm;
 		
 		form.SetFormPr(formPr.Copy());
 		
+		if (!form.IsMainForm() && form.GetMainForm().GetFormRole() !== formPr.GetRole())
+			form.SetFormRole(form.GetMainForm().GetFormRole());
+		
 		let docPartId = form.GetPlaceholder();
 		let glossary  = logicDocument.GetGlossaryDocument();
 		if ((form.IsTextForm()

apiPlugins.js

@@ -34,6 +34,8 @@
 
 (function(window)
 {
+	let Api = window["asc_docs_api"];
+
 	/**
      * @typedef {Object} ContentControl
 	 * Content control object.
@@ -62,7 +64,7 @@
 	 * @returns {ContentControl[]} - An array with all the forms from the document.
 	 * @see office-js-api/Examples/Plugins/Forms/Api/Methods/GetAllForms.js
 	 */
-	window["asc_docs_api"].prototype["pluginMethod_GetAllForms"] = function()
+	Api.prototype["pluginMethod_GetAllForms"] = function()
 	{
 		let oFormsManager = this.private_GetFormsManager();
 		if (!oFormsManager)
@@ -85,7 +87,7 @@
 	 * @returns {ContentControl[]} - An array with all the forms from the document with the specified tag.
 	 * @see office-js-api/Examples/Plugins/Forms/Api/Methods/GetFormsByTag.js
 	 */
-	window["asc_docs_api"].prototype["pluginMethod_GetFormsByTag"] = function(tag)
+	Api.prototype["pluginMethod_GetFormsByTag"] = function(tag)
 	{
 		let oFormsManager = this.private_GetFormsManager();
 		if (!oFormsManager)
@@ -111,7 +113,7 @@
 	 * @param {string | boolean} value - Form value to be set. Its type depends on the form type.
 	 * @see office-js-api/Examples/Plugins/Forms/Api/Methods/SetFormValue.js
 	 */
-	window["asc_docs_api"].prototype["pluginMethod_SetFormValue"] = function(internalId, value)
+	Api.prototype["pluginMethod_SetFormValue"] = function(internalId, value)
 	{
 		this.private_SetFormValue(internalId, value);
 	};
@@ -124,7 +126,7 @@
 	 * @returns {null | string | boolean} The form value in the string or boolean format depending on the form type. The null value means that the form is filled with a placeholder.
 	 * @see office-js-api/Examples/Plugins/Forms/Api/Methods/GetFormValue.js
 	 */
-	window["asc_docs_api"].prototype["pluginMethod_GetFormValue"] = function(internalId)
+	Api.prototype["pluginMethod_GetFormValue"] = function(internalId)
 	{
 		if (!AscCommon.g_oTableId)
 			return "";

oform/OForm.js

@@ -96,10 +96,22 @@
 			
 		this.CurrentUser = role.getUserMaster();
 	};
+	/**
+	 * Difference between noRole and when role is not set, is that when role is not set we can fill any field,
+	 * but when noRole is set then we can't fill anything
+	 */
+	OForm.prototype.setCurrentNoRole = function()
+	{
+		this.CurrentUser = AscOForm.getNoRole();
+	};
 	OForm.prototype.clearCurrentRole = function()
 	{
 		this.CurrentUser = null;
 	};
+	OForm.prototype.getCurrentRole = function()
+	{
+		return this.CurrentUser ? this.CurrentUser.getRole() : null;
+	};
 	OForm.prototype.getCurrentUserMaster = function()
 	{
 		return this.CurrentUser;
@@ -444,6 +456,21 @@
 	{
 		this.NeedUpdateRoles = true;
 	};
+	OForm.prototype.onChangeFieldGroupFilled = function(fieldGroup)
+	{
+		if (!this.Document)
+			return;
+		
+		for (let i = 0; i < this.Roles.length; ++i)
+		{
+			let role = this.Roles[i];
+			if (fieldGroup === role.getFieldGroup())
+			{
+				this.Document.sendEvent("asc_onOFormRoleFilled", role.getRole(), fieldGroup.isFilled());
+				return;
+			}
+		}
+	};
 	OForm.prototype.onChangeRoleColor = function()
 	{
 		this.NeedRedraw = true;
@@ -561,6 +588,39 @@
 	{
 		this.onUndoRedo();
 	};
+	OForm.prototype.canFillRole = function(roleName)
+	{
+		let role = this.getRole(roleName);
+		if (!role || role.isFilled())
+			return false;
+		
+		let weight = role.getWeight();
+		for (let i = 0; i < this.Roles.length; ++i)
+		{
+			if (this.Roles[i] === role || this.Roles[i].isFilled())
+				continue;
+			
+			if (this.Roles[i].getWeight() < weight)
+				return false;
+		}
+		
+		return true;
+	};
+	OForm.prototype.setRoleFilled = function(roleName, isFilled)
+	{
+		let role = this.getRole(roleName);
+		if (!role)
+			return;
+		
+		role.setFilled(isFilled);
+	};
+	OForm.prototype.setAllRolesNotFilled = function()
+	{
+		for (let roleIndex = 0, roleCount = this.Roles.length; roleIndex < roleCount; ++roleIndex)
+		{
+			this.Roles[roleIndex].setFilled(false);
+		}
+	};
 	////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 	// Private area
 	////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -598,5 +658,6 @@
 	OForm.prototype['asc_moveDownRole'] = OForm.prototype.moveDownRole;
 	OForm.prototype['asc_haveRole']     = OForm.prototype.haveRole;
 	OForm.prototype['asc_getRole']      = OForm.prototype.getRoleSettings;
+	OForm.prototype['asc_canFillRole']  = OForm.prototype.canFillRole;
 	
 })(window);

oform/Role.js

@@ -78,6 +78,15 @@
 		if (this.FieldGroup)
 			this.FieldGroup.setWeight(weight);
 	};
+	CRole.prototype.isFilled = function()
+	{
+		return this.FieldGroup ? this.FieldGroup.isFilled() : true;
+	};
+	CRole.prototype.setFilled = function(isFilled)
+	{
+		if (this.FieldGroup)
+			this.FieldGroup.setFilled(isFilled);
+	};
 	CRole.prototype.getFieldGroup = function()
 	{
 		return this.FieldGroup;

oform/format/Document.js

@@ -568,6 +568,13 @@
 		
 		this.OForm.onChangeRoles();
 	};
+	CDocument.prototype.onChangeFieldGroupFilled = function(fieldGroup)
+	{
+		if (!this.OForm)
+			return;
+		
+		this.OForm.onChangeFieldGroupFilled(fieldGroup);
+	};
 	CDocument.prototype.onChangeUserMaster = function(userMaster)
 	{
 		if (!this.OForm)

oform/format/FieldGroup.js

@@ -42,6 +42,7 @@
 	{
 		AscOForm.CBaseFormatObject.call(this);
 
+		this.Filled = false;
 		this.Weight = null;
 		this.Fields = [];
 		this.Users  = [];
@@ -57,6 +58,19 @@
 		this.Parent = parent;
 		this.onChange();
 	};
+	CFieldGroup.prototype.isFilled = function()
+	{
+		return !!this.Filled;
+	};
+	CFieldGroup.prototype.setFilled = function(isFilled)
+	{
+		if (this.Filled === isFilled)
+			return;
+		
+		AscCommon.History.Add(new AscDFH.CChangesOFormFieldGroupFilled(this, this.Filled, isFilled));
+		this.Filled = isFilled;
+		this.onChangeFilled();
+	};
 	CFieldGroup.prototype.setWeight = function(value)
 	{
 		if (this.Weight === value)
@@ -149,6 +163,13 @@
 		
 		this.Parent.onChangeFieldGroup(this);
 	};
+	CFieldGroup.prototype.onChangeFilled = function()
+	{
+		if (!this.Parent)
+			return;
+		
+		this.Parent.onChangeFieldGroupFilled(this);
+	};
 	CFieldGroup.prototype.getAllFields = function()
 	{
 		let fields = [];
@@ -207,6 +228,8 @@
 		
 		writer.WriteXmlNodeStart("fieldGroup");
 		writer.WriteXmlNullableAttributeInt("weight", this.getWeight());
+		if (this.isFilled())
+			writer.WriteXmlNullableAttributeBool("filled", true);
 		writer.WriteXmlAttributesEnd();
 		
 		for (let userIndex = 0, userCount = this.Users.length; userIndex < userCount; ++userIndex)
@@ -239,8 +262,11 @@
 		
 		while (reader.MoveToNextAttribute())
 		{
-			if ("weight" === reader.GetNameNoNS())
+			let attrName = reader.GetNameNoNS();
+			if ("weight" === attrName)
 				fG.setWeight(reader.GetValueInt());
+			if ("filled" === attrName)
+				fG.setFilled(reader.GetValueBool());
 		}
 		
 		let xmlReaderContext = reader.GetOformContext();

oform/format/UserMaster.js

@@ -34,6 +34,23 @@
 
 (function(window)
 {
+	let noRole = null;
+	function getNoRole()
+	{
+		if (!noRole)
+		{
+			noRole = AscCommon.ExecuteNoHistory(function()
+			{
+				let user = new CUserMaster();
+				user.setUserId("{BA186350-BB64-8503-5C55-083595AB15A9}");
+				user.setRole("NoRole");
+				return user;
+			});
+		}
+		
+		return noRole;
+	}
+	
 	/**
 	 * @param {boolean} [generateId=false]
 	 * @constructor
@@ -107,7 +124,7 @@
 	CUserMaster.prototype.initDefaultUser = function()
 	{
 		// TODO: Возможно стоит придумать уникальный id общий для дефолтовой роли
-		this.setRole(AscCommon.translateManager.getValue("Anyone"));
+		this.setRole("Anyone");
 		this.setColor(255, 239, 191);
 	};
 	CUserMaster.prototype.compare = function(user)
@@ -228,5 +245,7 @@
 	};
 	//--------------------------------------------------------export----------------------------------------------------
 	AscOForm.CUserMaster = CUserMaster;
+	AscOForm.getNoRole   = getNoRole;
+	
 
 })(window);

oform/format/changes/FieldGroupChanges.js

@@ -37,6 +37,7 @@
 	window['AscDFH'].historyitem_OForm_FieldGroup_Weight         = window['AscDFH'].historyitem_type_OForm_FieldGroup | 1;
 	window['AscDFH'].historyitem_OForm_FieldGroup_AddRemoveField = window['AscDFH'].historyitem_type_OForm_FieldGroup | 2;
 	window['AscDFH'].historyitem_OForm_FieldGroup_AddRemoveUser  = window['AscDFH'].historyitem_type_OForm_FieldGroup | 3;
+	window['AscDFH'].historyitem_OForm_FieldGroup_Filled         = window['AscDFH'].historyitem_type_OForm_FieldGroup | 4;
 
 	/**
 	 * @constructor
@@ -120,5 +121,26 @@
 		}
 	);
 	window['AscDFH'].CChangesOFormFieldGroupAddRemoveUser = CChangesOFormFieldGroupAddRemoveUser;
-
+	
+	/**
+	 * @constructor
+	 * @extends {window['AscDFH'].CChangesBaseBoolProperty}
+	 */
+	function CChangesOFormFieldGroupFilled(Class, Old, New)
+	{
+		window['AscDFH'].CChangesBaseBoolProperty.call(this, Class, Old, New);
+	}
+	window['AscDFH'].InheritPropertyChange(
+		CChangesOFormFieldGroupFilled,
+		window['AscDFH'].CChangesBaseBoolProperty,
+		window['AscDFH'].historyitem_OForm_FieldGroup_Filled,
+		function(value)
+		{
+			this.Class.Filled = value;
+			this.Class.onChangeFilled();
+		},
+		false
+	);
+	window['AscDFH'].CChangesOFormFieldGroupFilled = CChangesOFormFieldGroupFilled;
+	
 })(window);