pengjunjie/langflow
1
0
Fork 1
mirror of https://github.com/langflow-ai/langflow.git synced 2026-07-23 22:15:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(execution): register ExecutorService factory and update seam test mocks

Browse Source 
- register ExecutorServiceFactory in register_all_service_factories so
  EXECUTOR_SERVICE resolves at app startup; without it the seam raised
  NoFactoryRegisteredError across integration and mcp tests
- test_base.py graph.async_start mocks now default the leading positional
  param (the seam calls async_start with inputs as a keyword), fixing the
  'missing 1 required positional argument' failures
- add executor_kind to the settings composition EXPECTED_FIELDS set
This commit is contained in:
ogabrielluiz
2026-06-17 15:39:05 -03:00
parent 276ed1f1d5
commit 2f061d470e
3 changed files with 22 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/base/langflow/services/utils.py
View File

@ -487,6 +487,7 @@ def register_all_service_factories() -> None:
from lfx.services.schema import ServiceType
service_manager = get_service_manager()
from lfx.services.executor import factory as executor_factory
from lfx.services.mcp_composer import factory as mcp_composer_factory
from lfx.services.settings import factory as settings_factory
@ -542,6 +543,7 @@ def register_all_service_factories() -> None:
)
service_manager.register_factory(authorization_factory.AuthorizationServiceFactory())
service_manager.register_factory(mcp_composer_factory.MCPComposerServiceFactory())
service_manager.register_factory(executor_factory.ExecutorServiceFactory())
service_manager.set_factory_registered()

38
src/lfx/tests/unit/run/test_base.py
View File

@ -180,7 +180,7 @@ class TestRunFlowJsonInput:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -308,7 +308,7 @@ class TestRunFlowSessionId:
graph.edges = []
graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
graph.async_start = _async_start
@ -469,7 +469,7 @@ class TestRunFlowSessionIdPropagation:
graph.edges = []
graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
graph.async_start = _async_start
@ -574,7 +574,7 @@ class TestRunFlowUserId:
graph.edges = []
graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
graph.async_start = _async_start
@ -671,7 +671,7 @@ class TestRunFlowFallbackToEnvVars:
graph.edges = []
graph.prepare = MagicMock()
async def _async_start(_inputs, **kwargs):
async def _async_start(_inputs=None, **kwargs):
captured.update(kwargs)
yield
@ -743,7 +743,7 @@ class TestRunFlowGlobalVariables:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -784,7 +784,7 @@ graph = Graph(chat_input, chat_output)
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -825,7 +825,7 @@ class TestRunFlowOutputFormats:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -938,7 +938,7 @@ class TestRunFlowTiming:
mock_result.vertex.display_name = "TestComponent"
mock_result.vertex.id = "test-id-123"
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield mock_result
mock_graph.async_start = mock_async_start
@ -1133,7 +1133,7 @@ class TestRunFlowVariableValidation:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -1169,7 +1169,7 @@ class TestRunFlowInputValueHandling:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -1207,7 +1207,7 @@ class TestRunFlowInputValueHandling:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -1264,7 +1264,7 @@ class TestRunFlowJsonFileExecution:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def mock_async_start(_inputs, **_kwargs):
async def mock_async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = mock_async_start
@ -1364,7 +1364,7 @@ class TestRunFlowExecutionErrors:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def failing_async_start(_inputs, **_kwargs):
async def failing_async_start(_inputs=None, **_kwargs):
msg = "Execution failed"
raise ValueError(msg)
yield # Required to make it an async generator
@ -1662,7 +1662,7 @@ class TestUpgradeFlowOption:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = _async_start
@ -1703,7 +1703,7 @@ class TestUpgradeFlowOption:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = _async_start
@ -1740,7 +1740,7 @@ class TestUpgradeFlowOption:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = _async_start
@ -1783,7 +1783,7 @@ class TestUpgradeFlowOption:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = _async_start
@ -1822,7 +1822,7 @@ class TestUpgradeFlowOption:
mock_graph.edges = []
mock_graph.prepare = MagicMock()
async def _async_start(_inputs, **_kwargs):
async def _async_start(_inputs=None, **_kwargs):
yield
mock_graph.async_start = _async_start

1
src/lfx/tests/unit/services/settings/test_settings_composition.py
View File

@ -176,6 +176,7 @@ EXPECTED_FIELDS = {
"redis_queue_polling_stale_threshold_s",
"redis_queue_polling_watchdog_interval_s",
"max_ingestion_timeout_secs",
"executor_kind",
# UiSettings
"embedded_mode",
"hide_getting_started_progress",