pengjunjie/core
1
0
Fork 1
mirror of https://github.com/ONLYOFFICE/core.git synced 2026-02-10 18:05:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

V8: Implemented CJSObject::getPropertyNames()

Browse Source
This commit is contained in:
Mikhail Lobotskiy
2023-11-16 14:34:06 +04:00
parent 7eebede9a6
commit 59806039ed
2 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
DesktopEditor/doctrenderer/js_internal/js_base.h
View File

@ -215,7 +215,7 @@ namespace NSJSBase
* Returns specified property of the object.
* @param name The name of a property.
*/
virtual JSSmart<CJSValue> get(const char* name) = 0;
virtual JSSmart<CJSValue> get(const char* name) = 0;
/**
* Sets a property of the object.
* @param name The name of a property.
@ -228,6 +228,10 @@ namespace NSJSBase
void set(const char* name, JSSmart<CJSValue> value);
void set(const char* name, JSSmart<CJSObject> value);
/**
* Returns a vector containing the names of the properties of this object as strings, including properties from prototype objects.
*/
virtual std::vector<std::string> getPropertyNames() = 0;
/**
* Returns a pointer to the native embedded object.
*/
@ -673,7 +677,7 @@ namespace NSJSBase
*
* NOTE: If you don't want to export certain functions from your embedded class for some reason,
* then add the inline comment "[noexport]" at the start of a function declaration.
* Also you can use `#ifdef ... #endif` blocks (see doctrenderer/test/internal/Embed.h for an example).
* Also you can use `#ifdef ... #endif` blocks (see doctrenderer/test/embed/external/Embed.h for an example).
*/
#endif // _CORE_EXT_JS_BASE_H_

17
DesktopEditor/doctrenderer/js_internal/v8/v8_base.h
View File

@ -446,6 +446,23 @@ namespace NSJSBase
value->Set(V8ContextFirstArg _name, v8::Number::New(isolate, _value));
}
virtual std::vector<std::string> getPropertyNames()
{
v8::Local<v8::Context> context = CV8Worker::GetCurrentContext();
v8::Local<v8::Array> names = value->GetPropertyNames(context).ToLocalChecked();
uint32_t len = names->Length();
std::vector<std::string> ret(len);
for (uint32_t i = 0; i < len; i++)
{
CJSValueV8 _value;
_value.value = names->Get(context, i).ToLocalChecked();
ret[i] = _value.toStringA();
}
return ret;
}
virtual CJSEmbedObject* getNative()
{
v8::Handle<v8::External> field = v8::Handle<v8::External>::Cast(value->GetInternalField(0));