From 2587e1e0f5b1acf5bad8446ec1c3e9a1082ea107 Mon Sep 17 00:00:00 2001 From: maxkadushkin Date: Sat, 23 Nov 2024 00:06:02 +0300 Subject: [PATCH 1/2] [DE mobile] fix "Mobile View" option for PDF forms --- apps/documenteditor/mobile/src/controller/Main.jsx | 10 +++++----- apps/documenteditor/mobile/src/controller/Toolbar.jsx | 1 + apps/documenteditor/mobile/src/store/appOptions.js | 1 + apps/documenteditor/mobile/src/view/Toolbar.jsx | 2 +- .../mobile/src/view/settings/SettingsPage.jsx | 2 +- 5 files changed, 9 insertions(+), 7 deletions(-) diff --git a/apps/documenteditor/mobile/src/controller/Main.jsx b/apps/documenteditor/mobile/src/controller/Main.jsx index a2801fd532..97adb8ea46 100644 --- a/apps/documenteditor/mobile/src/controller/Main.jsx +++ b/apps/documenteditor/mobile/src/controller/Main.jsx @@ -347,7 +347,6 @@ class MainController extends Component { const isOForm = appOptions.isOForm; const appSettings = this.props.storeApplicationSettings; const customization = appOptions.customization; - const isStandardView = customization?.mobile?.standardView ?? false; f7.emit('resize'); @@ -378,10 +377,10 @@ class MainController extends Component { appSettings.changeShowTableEmptyLine(value); this.api.put_ShowTableEmptyLine(value); - - value = LocalStorage.getBool('mobile-view'); + value = LocalStorage.itemExists('mobile-view') ? + LocalStorage.getBool('mobile-view') : !(customization?.mobile?.standardView ?? false); - if(value || !isStandardView) { + if(appOptions.isMobileViewAvailable && value) { this.api.ChangeReaderMode(); } else { appOptions.changeMobileView(); @@ -466,7 +465,8 @@ class MainController extends Component { Common.Utils.Metric.setCurrentMetric(1); //pt - this.appOptions = {isCorePDF: isPDF}; + this.appOptions = {isCorePDF: isPDF}; + this.props.storeAppOptions.isMobileViewAvailable = !this.appOptions.isCorePDF; this.bindEvents(); Common.Gateway.on('init', loadConfig); diff --git a/apps/documenteditor/mobile/src/controller/Toolbar.jsx b/apps/documenteditor/mobile/src/controller/Toolbar.jsx index 5f127d7c17..c851fabc6f 100644 --- a/apps/documenteditor/mobile/src/controller/Toolbar.jsx +++ b/apps/documenteditor/mobile/src/controller/Toolbar.jsx @@ -418,6 +418,7 @@ const ToolbarController = inject('storeAppOptions', 'users', 'storeReview', 'sto isViewer={isViewer} turnOnViewerMode={turnOnViewerMode} isMobileView={isMobileView} + isMobileViewAvailable={appOptions.isMobileViewAvailable} changeMobileView={changeMobileView} changeTitleHandler={changeTitleHandler} isVersionHistoryMode={isVersionHistoryMode} diff --git a/apps/documenteditor/mobile/src/store/appOptions.js b/apps/documenteditor/mobile/src/store/appOptions.js index 10513b6f84..ee26d13539 100644 --- a/apps/documenteditor/mobile/src/store/appOptions.js +++ b/apps/documenteditor/mobile/src/store/appOptions.js @@ -65,6 +65,7 @@ export class storeAppOptions { this.typeProtection = type; } + isMobileViewAvailable = true; isMobileView = true; changeMobileView() { this.isMobileView = !this.isMobileView; diff --git a/apps/documenteditor/mobile/src/view/Toolbar.jsx b/apps/documenteditor/mobile/src/view/Toolbar.jsx index a501573d50..ca22d1ade3 100644 --- a/apps/documenteditor/mobile/src/view/Toolbar.jsx +++ b/apps/documenteditor/mobile/src/view/Toolbar.jsx @@ -62,7 +62,7 @@ const ToolbarView = props => { }) } {!isEditableForms ? [ - ((isViewer || !Device.phone) && isAvailableExt && !props.disabledControls && !isVersionHistoryMode) && + ((isViewer || !Device.phone) && props.isMobileViewAvailable && !props.disabledControls && !isVersionHistoryMode) && { props.changeMobileView(); props.openOptions('snackbar'); diff --git a/apps/documenteditor/mobile/src/view/settings/SettingsPage.jsx b/apps/documenteditor/mobile/src/view/settings/SettingsPage.jsx index dfdb1931af..3075d3aa06 100644 --- a/apps/documenteditor/mobile/src/view/settings/SettingsPage.jsx +++ b/apps/documenteditor/mobile/src/view/settings/SettingsPage.jsx @@ -126,7 +126,7 @@ const SettingsPage = inject("storeAppOptions", "storeReview", "storeDocumentInfo } - {((!isViewer && Device.phone) || isEditableForms) && + {(appOptions.isMobileViewAvailable && ((Device.phone && !isViewer) || isEditableForms)) && { From 475ef968a52a1dd4b32f7902da14f53b994acb36 Mon Sep 17 00:00:00 2001 From: maxkadushkin Date: Sat, 23 Nov 2024 00:11:07 +0300 Subject: [PATCH 2/2] [DE mobile] fix "Settings" popup position --- apps/documenteditor/mobile/src/view/Toolbar.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/documenteditor/mobile/src/view/Toolbar.jsx b/apps/documenteditor/mobile/src/view/Toolbar.jsx index ca22d1ade3..c2122535bc 100644 --- a/apps/documenteditor/mobile/src/view/Toolbar.jsx +++ b/apps/documenteditor/mobile/src/view/Toolbar.jsx @@ -96,6 +96,7 @@ const ToolbarView = props => { props.openOptions('settings')}>,