From bd6c34b66ddff1fe85bbef87e46c72381950a166 Mon Sep 17 00:00:00 2001
From: Maxim Kadushkin <maxim.kadushkin@onlyoffice.com>
Date: Wed, 6 Jan 2021 20:33:01 +0300
Subject: [PATCH] [stylesheets] repaired some components

---
 .../main/lib/component/ComboBorderSize.js     |  8 +++--
 .../resources/less/colors-table-dark.less     |  2 +-
 apps/common/main/resources/less/combobox.less |  8 +++--
 .../main/app/view/ImageSettingsAdvanced.js    | 32 ++++++++++++-------
 .../resources/less/advanced-settings.less     | 11 +------
 .../main/app/view/ShapeSettingsAdvanced.js    |  8 ++---
 .../main/app/view/ShapeSettingsAdvanced.js    |  8 ++---
 7 files changed, 41 insertions(+), 36 deletions(-)

diff --git a/apps/common/main/lib/component/ComboBorderSize.js b/apps/common/main/lib/component/ComboBorderSize.js
index ace87669cd..9a55a3b568 100644
--- a/apps/common/main/lib/component/ComboBorderSize.js
+++ b/apps/common/main/lib/component/ComboBorderSize.js
@@ -177,7 +177,9 @@ define([
         template: _.template([
             '<span class="input-group combobox combo-border-size input-group-nr <%= cls %>" id="<%= id %>" style="<%= style %>">',
                 '<input type="text" class="form-control text">',
-                '<button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown"><span class="caret img-commonctrl"></span></button>',
+                '<button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown">',
+                    '<span class="caret"></span>',
+                '</button>',
                 '<ul class="dropdown-menu <%= menuCls %>" style="<%= menuStyle %>" role="menu">',
                     '<% _.each(items, function(item) { %>',
                         '<li id="<%= item.id %>" data-value="<%= item.value %>"><a tabindex="-1" type="menuitem">',
@@ -230,7 +232,9 @@ define([
                     '<i class="image"></i>',
                 '</div>',
                 '<div style="display: table-cell;"></div>',
-                '<button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown"><span class="caret img-commonctrl"></span></button>',
+                '<button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown">',
+                    '<span class="caret"></span>',
+                '</button>',
                 '<ul class="dropdown-menu <%= menuCls %>" style="<%= menuStyle %>" role="menu">',
                     '<% _.each(items, function(item) { %>',
                         '<li id="<%= item.id %>" data-value="<%= item.value %>"><a tabindex="-1" type="menuitem" style="padding: 2px 0 2px 10px;">',
diff --git a/apps/common/main/resources/less/colors-table-dark.less b/apps/common/main/resources/less/colors-table-dark.less
index c9e7751bd0..94a9279993 100644
--- a/apps/common/main/resources/less/colors-table-dark.less
+++ b/apps/common/main/resources/less/colors-table-dark.less
@@ -19,7 +19,7 @@
         --highlight-button-pressed: #606060;
         --highlight-button-pressed-hover: #808080;
         --highlight-primary-dialog-button-hover: #e5e5e5;
-        --highlight-header-button-hover: #000, 20%;
+        --highlight-header-button-hover: fade(#fff, 20%);
         --highlight-toolbar-tab-underline: #ddd;
         --highlight-text-select: #96c8fd;
 
diff --git a/apps/common/main/resources/less/combobox.less b/apps/common/main/resources/less/combobox.less
index 5786313426..ee35ea957e 100644
--- a/apps/common/main/resources/less/combobox.less
+++ b/apps/common/main/resources/less/combobox.less
@@ -55,9 +55,11 @@
         padding-right: 4px;
     }
 
-    .btn-default.disabled:hover {
-        background-color: transparent;
-        border-color: @border-regular-control;
+    .btn-default.disabled {
+        &:hover, &:focus {
+            background-color: transparent;
+            border-color: @border-regular-control;
+        }
     }
 
     &.input-group-nr.open:not(.no-highlighted) {
diff --git a/apps/documenteditor/main/app/view/ImageSettingsAdvanced.js b/apps/documenteditor/main/app/view/ImageSettingsAdvanced.js
index d1b1a67dc5..ef7f0f8c11 100644
--- a/apps/documenteditor/main/app/view/ImageSettingsAdvanced.js
+++ b/apps/documenteditor/main/app/view/ImageSettingsAdvanced.js
@@ -1012,9 +1012,11 @@ define([    'text!documenteditor/main/app/template/ImageSettingsAdvanced.templat
                 el: $('#shape-advanced-begin-style'),
                 template: _.template([
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
-                    '<div class="img-arrows form-control image" style="width: 100px;"></div>',
-                    '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                        '<div class="img-arrows form-control image" style="width: 100px;"></div>',
+                        '<div style="display: table-cell;"></div>',
+                        '<button type="button" class="btn btn-default">',
+                            '<span class="caret"></span>',
+                        '</button>',
                     '</div>'
                 ].join(''))
             });
@@ -1039,9 +1041,11 @@ define([    'text!documenteditor/main/app/template/ImageSettingsAdvanced.templat
                 el: $('#shape-advanced-begin-size'),
                 template: _.template([
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
-                    '<div class="img-arrows form-control image" style="width: 100px;"></div>',
-                    '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                        '<div class="img-arrows form-control image" style="width: 100px;"></div>',
+                        '<div style="display: table-cell;"></div>',
+                        '<button type="button" class="btn btn-default">',
+                            '<span class="caret"></span>',
+                        '</button>',
                     '</div>'
                 ].join(''))
             });
@@ -1072,9 +1076,11 @@ define([    'text!documenteditor/main/app/template/ImageSettingsAdvanced.templat
                 el: $('#shape-advanced-end-style'),
                 template: _.template([
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
-                    '<div class="img-arrows form-control image" style="width: 100px;"></div>',
-                    '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                        '<div class="img-arrows form-control image" style="width: 100px;"></div>',
+                        '<div style="display: table-cell;"></div>',
+                        '<button type="button" class="btn btn-default">',
+                            '<span class="caret"></span>',
+                        '</button>',
                     '</div>'
                 ].join(''))
             });
@@ -1099,9 +1105,11 @@ define([    'text!documenteditor/main/app/template/ImageSettingsAdvanced.templat
                 el: $('#shape-advanced-end-size'),
                 template: _.template([
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
-                    '<div class="img-arrows form-control image" style="width: 100px;"></div>',
-                    '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                        '<div class="img-arrows form-control image" style="width: 100px;"></div>',
+                        '<div style="display: table-cell;"></div>',
+                        '<button type="button" class="btn btn-default">',
+                            '<span class="caret"></span>',
+                        '</button>',
                     '</div>'
                 ].join(''))
             });
diff --git a/apps/documenteditor/main/resources/less/advanced-settings.less b/apps/documenteditor/main/resources/less/advanced-settings.less
index dcfce65af1..a8f70e3288 100644
--- a/apps/documenteditor/main/resources/less/advanced-settings.less
+++ b/apps/documenteditor/main/resources/less/advanced-settings.less
@@ -50,16 +50,7 @@
         &.image {
             background-position: 10px 0;
             background-attachment: scroll;
-            background-color: white;
-        }
-    }
-
-    .btn {
-        &:active:not(.disabled),
-        &.active:not(.disabled){
-            .caret {
-                background-position: @arrow-small-offset-x @arrow-small-offset-y;
-            }
+            background-color: @background-normal;
         }
     }
 }
diff --git a/apps/presentationeditor/main/app/view/ShapeSettingsAdvanced.js b/apps/presentationeditor/main/app/view/ShapeSettingsAdvanced.js
index 6b58dad79d..a116cdc64f 100644
--- a/apps/presentationeditor/main/app/view/ShapeSettingsAdvanced.js
+++ b/apps/presentationeditor/main/app/view/ShapeSettingsAdvanced.js
@@ -357,7 +357,7 @@ define([    'text!presentationeditor/main/app/template/ShapeSettingsAdvanced.tem
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
@@ -384,7 +384,7 @@ define([    'text!presentationeditor/main/app/template/ShapeSettingsAdvanced.tem
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
@@ -417,7 +417,7 @@ define([    'text!presentationeditor/main/app/template/ShapeSettingsAdvanced.tem
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
@@ -444,7 +444,7 @@ define([    'text!presentationeditor/main/app/template/ShapeSettingsAdvanced.tem
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
diff --git a/apps/spreadsheeteditor/main/app/view/ShapeSettingsAdvanced.js b/apps/spreadsheeteditor/main/app/view/ShapeSettingsAdvanced.js
index 799dc8090b..2f3719cc3a 100644
--- a/apps/spreadsheeteditor/main/app/view/ShapeSettingsAdvanced.js
+++ b/apps/spreadsheeteditor/main/app/view/ShapeSettingsAdvanced.js
@@ -378,7 +378,7 @@ define([    'text!spreadsheeteditor/main/app/template/ShapeSettingsAdvanced.temp
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
@@ -405,7 +405,7 @@ define([    'text!spreadsheeteditor/main/app/template/ShapeSettingsAdvanced.temp
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
@@ -438,7 +438,7 @@ define([    'text!spreadsheeteditor/main/app/template/ShapeSettingsAdvanced.temp
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });
@@ -465,7 +465,7 @@ define([    'text!spreadsheeteditor/main/app/template/ShapeSettingsAdvanced.temp
                     '<div class="input-group combobox combo-dataview-menu input-group-nr dropdown-toggle combo-arrow-style"  data-toggle="dropdown">',
                     '<div class="form-control image" style="width: 100px;"></div>',
                     '<div style="display: table-cell;"></div>',
-                    '<button type="button" class="btn btn-default"><span class="caret img-commonctrl"></span></button>',
+                    '<button type="button" class="btn btn-default"><span class="caret"></span></button>',
                     '</div>'
                 ].join(''))
             });