From ddfa27b28848bd34f98f57b1f76a40249f0cef77 Mon Sep 17 00:00:00 2001 From: JuliaSvinareva Date: Wed, 7 Jun 2023 15:54:31 +0300 Subject: [PATCH 1/6] [DE PE] Fix tooltips --- .../main/app/controller/DocumentHolder.js | 15 ++++++++++----- .../main/app/controller/DocumentHolder.js | 15 ++++++++++----- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/apps/documenteditor/main/app/controller/DocumentHolder.js b/apps/documenteditor/main/app/controller/DocumentHolder.js index ce1ae59acb..4712531552 100644 --- a/apps/documenteditor/main/app/controller/DocumentHolder.js +++ b/apps/documenteditor/main/app/controller/DocumentHolder.js @@ -140,11 +140,6 @@ define([ isVisible: false }; me.eyedropperTip = { - toolTip: new Common.UI.Tooltip({ - owner: this, - html: true, - cls: 'eyedropper-tooltip' - }), isHidden: true, isVisible: false, eyedropperColor: null, @@ -1063,6 +1058,16 @@ define([ me.eyedropperTip.toolTip.hide(); } + if (!me.eyedropperTip.toolTip) { + var tipEl = $('
'); + me.documentHolder.cmpEl.append(tipEl); + me.eyedropperTip.toolTip = new Common.UI.Tooltip({ + owner: tipEl, + html: true, + cls: 'eyedropper-tooltip' + }); + } + var color = moveData.get_EyedropperColor().asc_getColor(), r = color.get_r(), g = color.get_g(), diff --git a/apps/presentationeditor/main/app/controller/DocumentHolder.js b/apps/presentationeditor/main/app/controller/DocumentHolder.js index 6612e0996a..a9711d7415 100644 --- a/apps/presentationeditor/main/app/controller/DocumentHolder.js +++ b/apps/presentationeditor/main/app/controller/DocumentHolder.js @@ -118,11 +118,6 @@ define([ isVisible: false }; me.eyedropperTip = { - toolTip: new Common.UI.Tooltip({ - owner: this, - html: true, - cls: 'eyedropper-tooltip' - }), isHidden: true, isVisible: false, eyedropperColor: null, @@ -921,6 +916,16 @@ define([ me.eyedropperTip.toolTip.hide(); } + if (!me.eyedropperTip.toolTip) { + var tipEl = $('
'); + me.documentHolder.cmpEl.append(tipEl); + me.eyedropperTip.toolTip = new Common.UI.Tooltip({ + owner: tipEl, + html: true, + cls: 'eyedropper-tooltip' + }); + } + var color = moveData.get_EyedropperColor().asc_getColor(), r = color.get_r(), g = color.get_g(), From b15ccae10749f1b390fe898ed3ab3de7c7f7a3a1 Mon Sep 17 00:00:00 2001 From: JuliaSvinareva Date: Wed, 7 Jun 2023 14:44:57 +0300 Subject: [PATCH 2/6] [scale] Fix scale for themes and fonts --- .../main/lib/component/ComboBoxFonts.js | 14 ++- .../main/resources/less/asc-mixins.less | 101 ++++++++++++++++++ .../main/resources/less/toolbar.less | 2 +- 3 files changed, 115 insertions(+), 2 deletions(-) diff --git a/apps/common/main/lib/component/ComboBoxFonts.js b/apps/common/main/lib/component/ComboBoxFonts.js index 8ab9686fe1..3da561f273 100644 --- a/apps/common/main/lib/component/ComboBoxFonts.js +++ b/apps/common/main/lib/component/ComboBoxFonts.js @@ -58,7 +58,13 @@ define([ {ratio: 1.25, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@1.25x.png', width: iconWidth * 1.25, height: iconHeight * 1.25}, {ratio: 1.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@1.5x.png', width: iconWidth * 1.5, height: iconHeight * 1.5}, {ratio: 1.75, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@1.75x.png', width: iconWidth * 1.75, height: iconHeight * 1.75}, - {ratio: 2, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@2x.png', width: iconWidth * 2, height: iconHeight * 2} + {ratio: 2, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@2x.png', width: iconWidth * 2, height: iconHeight * 2}, + {ratio: 2.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@2.5x.png', width: iconWidth * 2.5, height: iconHeight * 2.5}, + {ratio: 3, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@3x.png', width: iconWidth * 3, height: iconHeight * 3}, + {ratio: 3.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@3.5x.png', width: iconWidth * 3.5, height: iconHeight * 3.5}, + {ratio: 4, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@4x.png', width: iconWidth * 4, height: iconHeight * 4}, + {ratio: 4.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@4.5x.png', width: iconWidth * 4.5, height: iconHeight * 4.5}, + {ratio: 5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@5x.png', width: iconWidth * 5, height: iconHeight * 5}, ], thumbIdx = 0, listItemHeight = 28, @@ -71,6 +77,12 @@ define([ thumbs[2].path = Common.Controllers.Desktop.call('getFontsSprite', '@1.5x'); thumbs[3].path = Common.Controllers.Desktop.call('getFontsSprite', '@1.75x'); thumbs[4].path = Common.Controllers.Desktop.call('getFontsSprite', '@2x'); + thumbs[5].path = Common.Controllers.Desktop.call('getFontsSprite', '@2.5x'); + thumbs[6].path = Common.Controllers.Desktop.call('getFontsSprite', '@3x'); + thumbs[7].path = Common.Controllers.Desktop.call('getFontsSprite', '@3.5x'); + thumbs[8].path = Common.Controllers.Desktop.call('getFontsSprite', '@4x'); + thumbs[9].path = Common.Controllers.Desktop.call('getFontsSprite', '@4.5x'); + thumbs[10].path = Common.Controllers.Desktop.call('getFontsSprite', '@5x'); } var bestDistance = Math.abs(applicationPixelRatio-thumbs[0].ratio); diff --git a/apps/common/main/resources/less/asc-mixins.less b/apps/common/main/resources/less/asc-mixins.less index ab1796d395..f4f12456ff 100644 --- a/apps/common/main/resources/less/asc-mixins.less +++ b/apps/common/main/resources/less/asc-mixins.less @@ -293,6 +293,107 @@ } } +.background-ximage-all-scale(@image, @w: auto, @h: auto, @repeat: no-repeat, @commonimage: true) { + .choose-image-path(@commonimage); + @imagepath: '@{path}/@{image}'; + + background-image: if(@icon-src-base64, data-uri(%("%s", '@{imagepath}')), ~"url(@{imagepath})"); + background-repeat: @repeat; + + @1d5ximage: replace(@imagepath, '\.png$', '@1.5x.png'); + @1d75ximage: replace(@imagepath, '\.png$', '@1.75x.png'); + @1d25ximage: replace(@imagepath, '\.png$', '@1.25x.png'); + @2ximage: replace(@imagepath, '\.png$', '@2x.png'); + @2d5ximage: replace(@imagepath, '\.png$', '@2.5x.png'); + @3ximage: replace(@imagepath, '\.png$', '@3x.png'); + @3d5ximage: replace(@imagepath, '\.png$', '@3.5x.png'); + @4ximage: replace(@imagepath, '\.png$', '@4x.png'); + @4d5ximage: replace(@imagepath, '\.png$', '@4.5x.png'); + @5ximage: replace(@imagepath, '\.png$', '@5x.png'); + + @media only screen { + @media (-webkit-min-device-pixel-ratio: 1.25) and (-webkit-max-device-pixel-ratio: 1.49), + (min-resolution: 1.25dppx) and (max-resolution: 1.49dppx), + (min-resolution: 120dpi) and (max-resolution: 143dpi) + { + background-image: ~"url(@{1d25ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 1.5) and (-webkit-max-device-pixel-ratio: 1.74), + (min-resolution: 1.5dppx) and (max-resolution: 1.74dppx), + (min-resolution: 144dpi) and (max-resolution: 167dpi) + { + background-image: ~"url(@{1d5ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 1.75) and (-webkit-max-device-pixel-ratio: 1.9), + (min-resolution: 1.75dppx) and (max-resolution: 1.9dppx), + (min-resolution: 168dpi) and (max-resolution: 191dpi) + { + background-image: ~"url(@{1d75ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 2) and (-webkit-max-device-pixel-ratio: 2.49), + (min-resolution: 2dppx) and (max-resolution: 2.49dppx), + (min-resolution: 192dpi) and (max-resolution: 239dpi) + { + background-image: ~"url(@{2ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 2.5) and (-webkit-max-device-pixel-ratio: 2.9), + (min-resolution: 2.5dppx) and (max-resolution: 2.9dppx), + (min-resolution: 240dpi) and (max-resolution: 287dpi) + { + background-image: ~"url(@{2d5ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 3) and (-webkit-max-device-pixel-ratio: 3.49), + (min-resolution: 3dppx) and (max-resolution: 3.49dppx), + (min-resolution: 288dpi) and (max-resolution: 335dpi) + { + background-image: ~"url(@{3ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 3.5) and (-webkit-max-device-pixel-ratio: 3.9), + (min-resolution: 3.5dppx) and (max-resolution: 3.9dppx), + (min-resolution: 336dpi) and (max-resolution: 383dpi) + { + background-image: ~"url(@{3d5ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 4) and (-webkit-max-device-pixel-ratio: 4.49), + (min-resolution: 4dppx) and (max-resolution: 4.49dppx), + (min-resolution: 384dpi) and (max-resolution: 431dpi) + { + background-image: ~"url(@{4ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 4.5) and (-webkit-max-device-pixel-ratio: 4.9), + (min-resolution: 4.5dppx) and (max-resolution: 4.9dppx), + (min-resolution: 432dpi) and (max-resolution: 479dpi) + { + background-image: ~"url(@{4d5ximage})"; + background-size: @w @h; + } + + @media (-webkit-min-device-pixel-ratio: 5), + (min-resolution: 5dppx), + (min-resolution: 480dpi) + { + background-image: ~"url(@{5ximage})"; + background-size: @w @h; + } + } +} + .img-commonctrl { &.img-colored { filter: none; diff --git a/apps/presentationeditor/main/resources/less/toolbar.less b/apps/presentationeditor/main/resources/less/toolbar.less index 40670f329c..950739d723 100644 --- a/apps/presentationeditor/main/resources/less/toolbar.less +++ b/apps/presentationeditor/main/resources/less/toolbar.less @@ -119,7 +119,7 @@ .item-theme { width: 88px; height: 40px; - .background-ximage-all('../../../../../../sdkjs/common/Images/themes_thumbnail.png', 88px); + .background-ximage-all-scale('../../../../../../sdkjs/common/Images/themes_thumbnail.png', 88px); background-size: cover } From 23240c6c54479d7acc1a5448172248cf546f8a95 Mon Sep 17 00:00:00 2001 From: JuliaSvinareva Date: Thu, 8 Jun 2023 11:56:41 +0300 Subject: [PATCH 3/6] [scale] Turn off big scales for fonts --- apps/common/main/lib/component/ComboBoxFonts.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/common/main/lib/component/ComboBoxFonts.js b/apps/common/main/lib/component/ComboBoxFonts.js index 3da561f273..340757d3f9 100644 --- a/apps/common/main/lib/component/ComboBoxFonts.js +++ b/apps/common/main/lib/component/ComboBoxFonts.js @@ -59,12 +59,12 @@ define([ {ratio: 1.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@1.5x.png', width: iconWidth * 1.5, height: iconHeight * 1.5}, {ratio: 1.75, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@1.75x.png', width: iconWidth * 1.75, height: iconHeight * 1.75}, {ratio: 2, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@2x.png', width: iconWidth * 2, height: iconHeight * 2}, - {ratio: 2.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@2.5x.png', width: iconWidth * 2.5, height: iconHeight * 2.5}, + /*{ratio: 2.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@2.5x.png', width: iconWidth * 2.5, height: iconHeight * 2.5}, {ratio: 3, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@3x.png', width: iconWidth * 3, height: iconHeight * 3}, {ratio: 3.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@3.5x.png', width: iconWidth * 3.5, height: iconHeight * 3.5}, {ratio: 4, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@4x.png', width: iconWidth * 4, height: iconHeight * 4}, {ratio: 4.5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@4.5x.png', width: iconWidth * 4.5, height: iconHeight * 4.5}, - {ratio: 5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@5x.png', width: iconWidth * 5, height: iconHeight * 5}, + {ratio: 5, path: '../../../../sdkjs/common/Images/fonts_thumbnail' + postfix + '@5x.png', width: iconWidth * 5, height: iconHeight * 5},*/ ], thumbIdx = 0, listItemHeight = 28, @@ -77,12 +77,12 @@ define([ thumbs[2].path = Common.Controllers.Desktop.call('getFontsSprite', '@1.5x'); thumbs[3].path = Common.Controllers.Desktop.call('getFontsSprite', '@1.75x'); thumbs[4].path = Common.Controllers.Desktop.call('getFontsSprite', '@2x'); - thumbs[5].path = Common.Controllers.Desktop.call('getFontsSprite', '@2.5x'); + /*thumbs[5].path = Common.Controllers.Desktop.call('getFontsSprite', '@2.5x'); thumbs[6].path = Common.Controllers.Desktop.call('getFontsSprite', '@3x'); thumbs[7].path = Common.Controllers.Desktop.call('getFontsSprite', '@3.5x'); thumbs[8].path = Common.Controllers.Desktop.call('getFontsSprite', '@4x'); thumbs[9].path = Common.Controllers.Desktop.call('getFontsSprite', '@4.5x'); - thumbs[10].path = Common.Controllers.Desktop.call('getFontsSprite', '@5x'); + thumbs[10].path = Common.Controllers.Desktop.call('getFontsSprite', '@5x');*/ } var bestDistance = Math.abs(applicationPixelRatio-thumbs[0].ratio); From c1130c325cfa343dabd04b0b71bbac7ca080a17c Mon Sep 17 00:00:00 2001 From: OVSharova Date: Thu, 8 Jun 2023 15:15:49 +0300 Subject: [PATCH 4/6] fix bug 62962 --- apps/spreadsheeteditor/main/index_internal.html | 1 + apps/spreadsheeteditor/main/index_internal.html.deploy | 1 + 2 files changed, 2 insertions(+) diff --git a/apps/spreadsheeteditor/main/index_internal.html b/apps/spreadsheeteditor/main/index_internal.html index 5c47e631e6..0f46245a75 100644 --- a/apps/spreadsheeteditor/main/index_internal.html +++ b/apps/spreadsheeteditor/main/index_internal.html @@ -215,6 +215,7 @@ +
From f28288f15f7f2adf7e89b9da33559ed194c43989 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Thu, 8 Jun 2023 15:49:40 +0300 Subject: [PATCH 5/6] Fix focus for buttons in modal windows --- apps/common/main/resources/less/buttons.less | 24 ++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/apps/common/main/resources/less/buttons.less b/apps/common/main/resources/less/buttons.less index ae0f9ab14b..7682afa2c0 100644 --- a/apps/common/main/resources/less/buttons.less +++ b/apps/common/main/resources/less/buttons.less @@ -1178,10 +1178,26 @@ } .asc-window.modal { - .btn-toolbar:not(.bg-white), .btn-group { - &:focus:not(.disabled) { - .box-shadow(0 0 0 @scaled-one-px-value-ie @border-control-focus-ie); - .box-shadow(0 0 0 @scaled-one-px-value @border-control-focus); + .btn-toolbar:not(.bg-white):not(.disabled) { + &:focus { + .box-inner-shadow(0 0 0 @scaled-one-px-value-ie @border-control-focus-ie); + .box-inner-shadow(0 0 0 @scaled-one-px-value @border-control-focus); + } + } + .btn-group:not(.split) { + &.open, + &.active, + &:active { + .btn-toolbar:not(.bg-white):not(.disabled) { + .box-inner-shadow(0 0 0 @scaled-one-px-value-ie @border-control-focus-ie); + .box-inner-shadow(0 0 0 @scaled-one-px-value @border-control-focus); + } + } + } + .btn-group.split, + .input-field-btn { + .btn-toolbar:not(.bg-white):not(.disabled):focus { + .box-shadow(none); } } } From 702f38dbee33d91c6846a7ca5b2d75fe47246585 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 9 Jun 2023 13:50:03 +0300 Subject: [PATCH 6/6] [SSE] Fix Bug 62975 --- apps/spreadsheeteditor/main/app/view/DocumentHolder.js | 4 ++-- .../main/resources/less/advanced-settings.less | 6 +++--- apps/spreadsheeteditor/main/resources/less/toolbar.less | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/spreadsheeteditor/main/app/view/DocumentHolder.js b/apps/spreadsheeteditor/main/app/view/DocumentHolder.js index a8dfb58f70..08193557d8 100644 --- a/apps/spreadsheeteditor/main/app/view/DocumentHolder.js +++ b/apps/spreadsheeteditor/main/app/view/DocumentHolder.js @@ -677,8 +677,8 @@ define([ var numFormatTemplate = _.template(''+ '
'+ - '
<%= caption %>
' + - '' + + '
<%= caption %>
' + + '' + '
'); me.pmiNumFormat = new Common.UI.MenuItem({ diff --git a/apps/spreadsheeteditor/main/resources/less/advanced-settings.less b/apps/spreadsheeteditor/main/resources/less/advanced-settings.less index 7c2bd9c653..fe941bf7ef 100644 --- a/apps/spreadsheeteditor/main/resources/less/advanced-settings.less +++ b/apps/spreadsheeteditor/main/resources/less/advanced-settings.less @@ -729,7 +729,7 @@ .item-container { position: relative; .name { - width: 100px; + width: 125px; position: absolute; left: 0; .rtl & { @@ -745,13 +745,13 @@ text-overflow: ellipsis; text-align: right; vertical-align: bottom; - padding-left: 100px; + padding-left: 125px; color: silver; white-space: nowrap; .rtl & { text-align: left; padding-left: 0; - padding-right: 100px; + padding-right: 125px; } } } diff --git a/apps/spreadsheeteditor/main/resources/less/toolbar.less b/apps/spreadsheeteditor/main/resources/less/toolbar.less index 0f876a141d..7b81198eb8 100644 --- a/apps/spreadsheeteditor/main/resources/less/toolbar.less +++ b/apps/spreadsheeteditor/main/resources/less/toolbar.less @@ -297,7 +297,7 @@ .rtl & { text-align: left; padding-left: 0; - padding-right: 100px; + padding-right: 125px; } } }