From b423ef972183dfeb8e6d3f13b10dd87c7dcf90df Mon Sep 17 00:00:00 2001 From: Dmitry-Ilyushechkin Date: Wed, 8 Oct 2025 00:20:56 +0300 Subject: [PATCH 1/3] fix: chart container width detection --- .../main/app/controller/DocumentHolderExt.js | 36 ++++++++++--------- .../main/app/controller/DocumentHolderExt.js | 34 +++++++++--------- .../main/app/controller/DocumentHolderExt.js | 36 ++++++++++--------- .../main/app/controller/DocumentHolderExt.js | 36 ++++++++++--------- 4 files changed, 75 insertions(+), 67 deletions(-) diff --git a/apps/documenteditor/main/app/controller/DocumentHolderExt.js b/apps/documenteditor/main/app/controller/DocumentHolderExt.js index 2c0077a7e8..9f271d2879 100644 --- a/apps/documenteditor/main/app/controller/DocumentHolderExt.js +++ b/apps/documenteditor/main/app/controller/DocumentHolderExt.js @@ -1243,6 +1243,25 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { + + if (!me.btnChartElement) { + me.btnChartElement = new Common.UI.Button({ + parentEl: $('#id-document-holder-btn-chart-element'), + cls: 'btn-toolbar', + iconCls: 'toolbar__icon btn-chart-elements', + hint: me.documentHolder.btnChart, + menu: me.documentHolder.menuChartElement.menu + }); + + me.btnChartElement.on('click', function() { + me.chartProps = me.getCurrentChartProps(); + if (me.chartProps) { + me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); + } + Common.UI.TooltipManager.closeTip('chartElements'); + }); + } + me._XY = undefined; me.checkEditorOffsets(); var x = asc_CRect.asc_getX(), @@ -1298,23 +1317,6 @@ define([], function () { Common.UI.TooltipManager.applyPlacement('chartElements'); }, 100); - if (!me.btnChartElement) { - me.btnChartElement = new Common.UI.Button({ - parentEl: $('#id-document-holder-btn-chart-element'), - cls: 'btn-toolbar', - iconCls: 'toolbar__icon btn-chart-elements', - hint: me.documentHolder.btnChart, - menu: me.documentHolder.menuChartElement.menu - }); - - me.btnChartElement.on('click', function() { - me.chartProps = me.getCurrentChartProps(); - if (me.chartProps) { - me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); - } - Common.UI.TooltipManager.closeTip('chartElements'); - }); - } me.disableChartElementButton(); } else { chartContainer.hide(); diff --git a/apps/pdfeditor/main/app/controller/DocumentHolderExt.js b/apps/pdfeditor/main/app/controller/DocumentHolderExt.js index cffa901db7..d7ecb0fa27 100644 --- a/apps/pdfeditor/main/app/controller/DocumentHolderExt.js +++ b/apps/pdfeditor/main/app/controller/DocumentHolderExt.js @@ -3058,6 +3058,24 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { + + if (!me.btnChartElement) { + me.btnChartElement = new Common.UI.Button({ + parentEl: $('#id-document-holder-btn-chart-element'), + cls: 'btn-toolbar', + iconCls: 'toolbar__icon btn-chart-elements', + hint: me.documentHolder.btnChart, + menu: me.documentHolder.menuChartElement.menu + }); + + me.btnChartElement.on('click', function() { + me.chartProps = me.getCurrentChartProps(); + if (me.chartProps) { + me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); + } + }); + } + me._XY = undefined; me.checkEditorOffsets(); var x = asc_CRect.asc_getX(), @@ -3107,22 +3125,6 @@ define([], function () { top: btnTop + 'px' }).show(); - if (!me.btnChartElement) { - me.btnChartElement = new Common.UI.Button({ - parentEl: $('#id-document-holder-btn-chart-element'), - cls: 'btn-toolbar', - iconCls: 'toolbar__icon btn-chart-elements', - hint: me.documentHolder.btnChart, - menu: me.documentHolder.menuChartElement.menu - }); - - me.btnChartElement.on('click', function() { - me.chartProps = me.getCurrentChartProps(); - if (me.chartProps) { - me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); - } - }); - } me.disableChartElementButton(); } else { chartContainer.hide(); diff --git a/apps/presentationeditor/main/app/controller/DocumentHolderExt.js b/apps/presentationeditor/main/app/controller/DocumentHolderExt.js index 638770f48f..b41c3855c4 100644 --- a/apps/presentationeditor/main/app/controller/DocumentHolderExt.js +++ b/apps/presentationeditor/main/app/controller/DocumentHolderExt.js @@ -1201,6 +1201,25 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { + + if (!me.btnChartElement) { + me.btnChartElement = new Common.UI.Button({ + parentEl: $('#id-document-holder-btn-chart-element'), + cls: 'btn-toolbar', + iconCls: 'toolbar__icon btn-chart-elements', + hint: me.documentHolder.btnChart, + menu: me.documentHolder.menuChartElement.menu + }); + + me.btnChartElement.on('click', function() { + me.chartProps = me.getCurrentChartProps(); + if (me.chartProps) { + me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); + } + Common.UI.TooltipManager.closeTip('chartElements'); + }); + } + me._XY = undefined; me.checkEditorOffsets(); var x = asc_CRect.asc_getX(), @@ -1257,23 +1276,6 @@ define([], function () { Common.UI.TooltipManager.applyPlacement('chartElements'); }, 100); - if (!me.btnChartElement) { - me.btnChartElement = new Common.UI.Button({ - parentEl: $('#id-document-holder-btn-chart-element'), - cls: 'btn-toolbar', - iconCls: 'toolbar__icon btn-chart-elements', - hint: me.documentHolder.btnChart, - menu: me.documentHolder.menuChartElement.menu - }); - - me.btnChartElement.on('click', function() { - me.chartProps = me.getCurrentChartProps(); - if (me.chartProps) { - me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); - } - Common.UI.TooltipManager.closeTip('chartElements'); - }); - } me.disableChartElementButton(); } else { chartContainer.hide(); diff --git a/apps/spreadsheeteditor/main/app/controller/DocumentHolderExt.js b/apps/spreadsheeteditor/main/app/controller/DocumentHolderExt.js index 8eff782636..35cf9913d1 100644 --- a/apps/spreadsheeteditor/main/app/controller/DocumentHolderExt.js +++ b/apps/spreadsheeteditor/main/app/controller/DocumentHolderExt.js @@ -3881,6 +3881,25 @@ define([], function () { me.isRtlSheet = me.api.asc_getSheetViewSettings().asc_getRightToLeft(); if (me.chartProps) { + + if (!me.btnChartElement) { + me.btnChartElement = new Common.UI.Button({ + parentEl: $('#id-document-holder-btn-chart-element'), + cls: 'btn-toolbar', + iconCls: 'toolbar__icon btn-chart-elements', + hint: me.documentHolder.btnChart, + menu: me.documentHolder.menuChartElement.menu + }); + + me.btnChartElement.on('click', function() { + me.chartProps = me.getCurrentChartProps(); + if (me.chartProps) { + me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); + } + Common.UI.TooltipManager.closeTip('chartElements'); + }); + } + me.tooltips.coauth.XY = undefined me.onDocumentResize(); var x = asc_CRect.asc_getX(), @@ -3947,23 +3966,6 @@ define([], function () { Common.UI.TooltipManager.applyPlacement('chartElements'); }, 100); - if (!me.btnChartElement) { - me.btnChartElement = new Common.UI.Button({ - parentEl: $('#id-document-holder-btn-chart-element'), - cls: 'btn-toolbar', - iconCls: 'toolbar__icon btn-chart-elements', - hint: me.documentHolder.btnChart, - menu: me.documentHolder.menuChartElement.menu - }); - - me.btnChartElement.on('click', function() { - me.chartProps = me.getCurrentChartProps(); - if (me.chartProps) { - me.updateChartElementMenu(me.documentHolder.menuChartElement.menu, me.chartProps); - } - Common.UI.TooltipManager.closeTip('chartElements'); - }); - } me.disableChartElementButton(); } else { chartContainer.hide(); From 122095eb64aeda9ec7b58771d28d69df314e35a0 Mon Sep 17 00:00:00 2001 From: Dmitry-Ilyushechkin Date: Wed, 8 Oct 2025 00:40:02 +0300 Subject: [PATCH 2/3] [DE, PDFE, PE] fix: reset data labels state before setting position --- .../main/app/controller/DocumentHolderExt.js | 9 +++++++++ .../main/app/controller/DocumentHolderExt.js | 11 ++++++++++- .../main/app/controller/DocumentHolderExt.js | 11 ++++++++++- 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/apps/documenteditor/main/app/controller/DocumentHolderExt.js b/apps/documenteditor/main/app/controller/DocumentHolderExt.js index 9f271d2879..f6129837ff 100644 --- a/apps/documenteditor/main/app/controller/DocumentHolderExt.js +++ b/apps/documenteditor/main/app/controller/DocumentHolderExt.js @@ -956,30 +956,39 @@ define([], function () { chartProps.setDisplayChartTitle(true, true); break; case 'CenterData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.ctr); break; case 'InnerBottomData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inBase); break; case 'InnerTopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inEnd); break; case 'OuterTopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.outEnd); break; case 'TopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.t); break; case 'LeftData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.l); break; case 'RightData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.r); break; case 'BottomData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.b); break; case 'FitWidthData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.bestFit); break; case 'bShowDataLabels': diff --git a/apps/pdfeditor/main/app/controller/DocumentHolderExt.js b/apps/pdfeditor/main/app/controller/DocumentHolderExt.js index d7ecb0fa27..5fe6e69327 100644 --- a/apps/pdfeditor/main/app/controller/DocumentHolderExt.js +++ b/apps/pdfeditor/main/app/controller/DocumentHolderExt.js @@ -2782,30 +2782,39 @@ define([], function () { chartProps.setDisplayChartTitle(true, true); break; case 'CenterData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.ctr); break; case 'InnerBottomData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inBase); break; case 'InnerTopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inEnd); break; case 'OuterTopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.outEnd); break; case 'TopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.t); break; case 'LeftData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.l); break; case 'RightData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.r); break; case 'BottomData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.b); break; case 'FitWidthData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.bestFit); break; case 'bShowDataLabels': @@ -3058,7 +3067,7 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { - + if (!me.btnChartElement) { me.btnChartElement = new Common.UI.Button({ parentEl: $('#id-document-holder-btn-chart-element'), diff --git a/apps/presentationeditor/main/app/controller/DocumentHolderExt.js b/apps/presentationeditor/main/app/controller/DocumentHolderExt.js index b41c3855c4..d36eaed486 100644 --- a/apps/presentationeditor/main/app/controller/DocumentHolderExt.js +++ b/apps/presentationeditor/main/app/controller/DocumentHolderExt.js @@ -911,30 +911,39 @@ define([], function () { chartProps.setDisplayChartTitle(true, true); break; case 'CenterData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.ctr); break; case 'InnerBottomData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inBase); break; case 'InnerTopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inEnd); break; case 'OuterTopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.outEnd); break; case 'TopData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.t); break; case 'LeftData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.l); break; case 'RightData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.r); break; case 'BottomData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.b); break; case 'FitWidthData': + if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.bestFit); break; case 'bShowDataLabels': @@ -1201,7 +1210,7 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { - + if (!me.btnChartElement) { me.btnChartElement = new Common.UI.Button({ parentEl: $('#id-document-holder-btn-chart-element'), From f8068259acbd246ec906af1bc9b3917069ffb5c1 Mon Sep 17 00:00:00 2001 From: Dmitry-Ilyushechkin Date: Wed, 8 Oct 2025 13:08:36 +0300 Subject: [PATCH 3/3] Revert "[DE, PDFE, PE] fix: reset data labels state before setting position" This reverts commit 122095eb64aeda9ec7b58771d28d69df314e35a0. --- .../main/app/controller/DocumentHolderExt.js | 9 --------- .../main/app/controller/DocumentHolderExt.js | 11 +---------- .../main/app/controller/DocumentHolderExt.js | 11 +---------- 3 files changed, 2 insertions(+), 29 deletions(-) diff --git a/apps/documenteditor/main/app/controller/DocumentHolderExt.js b/apps/documenteditor/main/app/controller/DocumentHolderExt.js index f6129837ff..9f271d2879 100644 --- a/apps/documenteditor/main/app/controller/DocumentHolderExt.js +++ b/apps/documenteditor/main/app/controller/DocumentHolderExt.js @@ -956,39 +956,30 @@ define([], function () { chartProps.setDisplayChartTitle(true, true); break; case 'CenterData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.ctr); break; case 'InnerBottomData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inBase); break; case 'InnerTopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inEnd); break; case 'OuterTopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.outEnd); break; case 'TopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.t); break; case 'LeftData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.l); break; case 'RightData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.r); break; case 'BottomData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.b); break; case 'FitWidthData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.bestFit); break; case 'bShowDataLabels': diff --git a/apps/pdfeditor/main/app/controller/DocumentHolderExt.js b/apps/pdfeditor/main/app/controller/DocumentHolderExt.js index 5fe6e69327..d7ecb0fa27 100644 --- a/apps/pdfeditor/main/app/controller/DocumentHolderExt.js +++ b/apps/pdfeditor/main/app/controller/DocumentHolderExt.js @@ -2782,39 +2782,30 @@ define([], function () { chartProps.setDisplayChartTitle(true, true); break; case 'CenterData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.ctr); break; case 'InnerBottomData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inBase); break; case 'InnerTopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inEnd); break; case 'OuterTopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.outEnd); break; case 'TopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.t); break; case 'LeftData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.l); break; case 'RightData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.r); break; case 'BottomData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.b); break; case 'FitWidthData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.bestFit); break; case 'bShowDataLabels': @@ -3067,7 +3058,7 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { - + if (!me.btnChartElement) { me.btnChartElement = new Common.UI.Button({ parentEl: $('#id-document-holder-btn-chart-element'), diff --git a/apps/presentationeditor/main/app/controller/DocumentHolderExt.js b/apps/presentationeditor/main/app/controller/DocumentHolderExt.js index d36eaed486..b41c3855c4 100644 --- a/apps/presentationeditor/main/app/controller/DocumentHolderExt.js +++ b/apps/presentationeditor/main/app/controller/DocumentHolderExt.js @@ -911,39 +911,30 @@ define([], function () { chartProps.setDisplayChartTitle(true, true); break; case 'CenterData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.ctr); break; case 'InnerBottomData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inBase); break; case 'InnerTopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.inEnd); break; case 'OuterTopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.outEnd); break; case 'TopData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.t); break; case 'LeftData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.l); break; case 'RightData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.r); break; case 'BottomData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.b); break; case 'FitWidthData': - if (chartProps.getDataLabelsPos() === 0) chartProps.setDisplayDataLabels(false, false); chartProps.setDisplayDataLabels(true, Asc.c_oAscChartDataLabelsPos.bestFit); break; case 'bShowDataLabels': @@ -1210,7 +1201,7 @@ define([], function () { me.isRtlSheet = me.api ? Common.UI.isRTL() : false; if (me.chartProps) { - + if (!me.btnChartElement) { me.btnChartElement = new Common.UI.Button({ parentEl: $('#id-document-holder-btn-chart-element'),