From 27d07deb5a222b42e1b40bb06a89d8de5815eec2 Mon Sep 17 00:00:00 2001 From: Konstantin Kireyev Date: Thu, 18 Apr 2024 17:28:02 +0500 Subject: [PATCH] [common] delay loading for plugin, rename, color dialogs --- apps/common/main/lib/component/HSBColorPicker.js | 6 +----- apps/common/main/lib/component/MaskedField.js | 4 +--- apps/common/main/lib/controller/Plugins.js | 2 -- apps/common/main/lib/view/ExtendedColorDialog.js | 4 +--- apps/common/main/lib/view/Header.js | 3 +-- apps/common/main/lib/view/PluginDlg.js | 7 +------ apps/common/main/lib/view/PluginPanel.js | 6 +----- apps/common/main/lib/view/RenameDialog.js | 4 +--- apps/documenteditor/main/app_dev.js | 4 ++++ apps/documenteditor/main/app_pack.js | 4 ++++ 10 files changed, 15 insertions(+), 29 deletions(-) diff --git a/apps/common/main/lib/component/HSBColorPicker.js b/apps/common/main/lib/component/HSBColorPicker.js index 8a8b82b6e6..57018003c5 100644 --- a/apps/common/main/lib/component/HSBColorPicker.js +++ b/apps/common/main/lib/component/HSBColorPicker.js @@ -32,11 +32,7 @@ if (Common === undefined) var Common = {}; -define([ - 'common/main/lib/component/BaseView', - 'common/main/lib/util/utils' - -], function () { +define([], function () { 'use strict'; Common.UI.HSBColorPicker = Common.UI.BaseView.extend({ diff --git a/apps/common/main/lib/component/MaskedField.js b/apps/common/main/lib/component/MaskedField.js index c61a562300..3a91ba3ec1 100644 --- a/apps/common/main/lib/component/MaskedField.js +++ b/apps/common/main/lib/component/MaskedField.js @@ -32,9 +32,7 @@ if (Common === undefined) var Common = {}; -define([ - 'common/main/lib/component/BaseView' -], function () { +define([], function () { 'use strict'; Common.UI.MaskedField = Common.UI.BaseView.extend({ diff --git a/apps/common/main/lib/controller/Plugins.js b/apps/common/main/lib/controller/Plugins.js index 89617db160..d7214ccc1f 100644 --- a/apps/common/main/lib/controller/Plugins.js +++ b/apps/common/main/lib/controller/Plugins.js @@ -39,8 +39,6 @@ define([ 'core', 'common/main/lib/collection/Plugins', 'common/main/lib/view/Plugins', - 'common/main/lib/view/PluginDlg', - 'common/main/lib/view/PluginPanel', 'common/main/lib/component/Switcher' ], function () { 'use strict'; diff --git a/apps/common/main/lib/view/ExtendedColorDialog.js b/apps/common/main/lib/view/ExtendedColorDialog.js index 7febda8079..b68b5ed573 100644 --- a/apps/common/main/lib/view/ExtendedColorDialog.js +++ b/apps/common/main/lib/view/ExtendedColorDialog.js @@ -35,9 +35,7 @@ if (Common === undefined) define([ 'text!common/main/lib/template/ExtendedColorDialog.template', 'common/main/lib/component/HSBColorPicker', - 'common/main/lib/component/MetricSpinner', - 'common/main/lib/component/MaskedField', - 'common/main/lib/component/Window' + 'common/main/lib/component/MaskedField' ], function (dlgTemplate) { 'use strict'; diff --git a/apps/common/main/lib/view/Header.js b/apps/common/main/lib/view/Header.js index 44ab50c734..14920d853c 100644 --- a/apps/common/main/lib/view/Header.js +++ b/apps/common/main/lib/view/Header.js @@ -45,8 +45,7 @@ Common.Views = Common.Views || {}; define([ 'backbone', 'text!common/main/lib/template/Header.template', - 'core', - 'common/main/lib/view/RenameDialog' + 'core' ], function (Backbone, headerTemplate) { 'use strict'; Common.Views.Header = Backbone.View.extend(_.extend(function(){ diff --git a/apps/common/main/lib/view/PluginDlg.js b/apps/common/main/lib/view/PluginDlg.js index 851257c881..728965b642 100644 --- a/apps/common/main/lib/view/PluginDlg.js +++ b/apps/common/main/lib/view/PluginDlg.js @@ -40,12 +40,7 @@ if (Common === undefined) Common.Views = Common.Views || {}; -define([ - 'common/main/lib/util/utils', - 'common/main/lib/component/BaseView', - 'common/main/lib/component/Layout', - 'common/main/lib/component/Window' -], function (template) { +define([], function () { 'use strict'; Common.Views.PluginDlg = Common.UI.Window.extend(_.extend({ diff --git a/apps/common/main/lib/view/PluginPanel.js b/apps/common/main/lib/view/PluginPanel.js index 46f1cd11f0..22ace8bead 100644 --- a/apps/common/main/lib/view/PluginPanel.js +++ b/apps/common/main/lib/view/PluginPanel.js @@ -40,11 +40,7 @@ if (Common === undefined) Common.Views = Common.Views || {}; -define([ - 'common/main/lib/util/utils', - 'common/main/lib/component/BaseView', - 'common/main/lib/component/Layout' -], function (template) { +define([], function () { 'use strict'; Common.Views.PluginPanel = Common.UI.BaseView.extend(_.extend({ diff --git a/apps/common/main/lib/view/RenameDialog.js b/apps/common/main/lib/view/RenameDialog.js index c154299345..faf2af4a15 100644 --- a/apps/common/main/lib/view/RenameDialog.js +++ b/apps/common/main/lib/view/RenameDialog.js @@ -37,9 +37,7 @@ * */ -define([ - 'common/main/lib/component/Window' -], function () { 'use strict'; +define([], function () { 'use strict'; Common.Views.RenameDialog = Common.UI.Window.extend(_.extend({ options: { diff --git a/apps/documenteditor/main/app_dev.js b/apps/documenteditor/main/app_dev.js index 8e917741d7..0f47c8cff2 100644 --- a/apps/documenteditor/main/app_dev.js +++ b/apps/documenteditor/main/app_dev.js @@ -221,6 +221,10 @@ require([ 'common/main/lib/view/UserNameDialog', 'common/main/lib/view/SearchDialog', 'common/main/lib/view/AdvancedSettingsWindow', + 'common/main/lib/view/PluginDlg', + 'common/main/lib/view/PluginPanel', + 'common/main/lib/view/ExtendedColorDialog', + 'common/main/lib/view/RenameDialog', 'documenteditor/main/app/view/ParagraphSettingsAdvanced', 'documenteditor/main/app/view/ImageSettingsAdvanced', diff --git a/apps/documenteditor/main/app_pack.js b/apps/documenteditor/main/app_pack.js index 8e057a8ef1..aa72ea9e20 100644 --- a/apps/documenteditor/main/app_pack.js +++ b/apps/documenteditor/main/app_pack.js @@ -18,6 +18,10 @@ require([ 'common/main/lib/view/OpenDialog', 'common/main/lib/view/UserNameDialog', 'common/main/lib/view/SearchDialog', + 'common/main/lib/view/PluginDlg', + 'common/main/lib/view/PluginPanel', + 'common/main/lib/view/ExtendedColorDialog', + 'common/main/lib/view/RenameDialog', 'documenteditor/main/app/view/ParagraphSettingsAdvanced', 'documenteditor/main/app/view/ImageSettingsAdvanced',