From e922d4fca22dcd061ec91f099b01bd625f5e0a38 Mon Sep 17 00:00:00 2001
From: Sergey Konovalov <Sergey.Konovalov@onlyoffice.com>
Date: Fri, 21 Mar 2025 16:02:25 +0300
Subject: [PATCH] [sql] Refactor mssql schema; Fix bug 73602

---
 schema/mssql/createdb.sql  | 37 +++++++++++++++++++++++++++----------
 schema/mssql/removetbl.sql |  9 ++++++++-
 2 files changed, 35 insertions(+), 11 deletions(-)

diff --git a/schema/mssql/createdb.sql b/schema/mssql/createdb.sql
index a89a5a9d..bc11649f 100644
--- a/schema/mssql/createdb.sql
+++ b/schema/mssql/createdb.sql
@@ -1,35 +1,52 @@
+-- Modified for SQL Server
+-- Requires SQL Server 2016 (13.x) or newer
+-- Features used:
+--   - DROP TABLE IF EXISTS (SQL Server 2016+)
+--   - Data compression (SQL Server 2008 R2+)
+
 -- CREATE DATABASE onlyoffice;
 -- GO
 
 -- USE onlyoffice;
+-- GO
+
+-- SQL Server Configuration Parameters
+-- ANSI_NULLS ON: Enables ISO standard NULL handling behavior
+--   When ON, comparison of NULL values evaluates to UNKNOWN instead of TRUE or FALSE
+-- QUOTED_IDENTIFIER ON: Enables standard SQL string delimiter behavior
+--   When ON, double quotes can be used to delimit identifiers and literal strings must use single quotes
+-- ANSI_PADDING ON: Controls how column stores values shorter than the defined size
+--   When ON, trailing blanks in char data and trailing zeros in binary data are preserved
+SET ANSI_NULLS ON;
+SET QUOTED_IDENTIFIER ON;
+SET ANSI_PADDING ON;
+GO
 
 CREATE TABLE doc_changes(
     tenant NVARCHAR(255) NOT NULL,
     id NVARCHAR(255) NOT NULL,
-    change_id DECIMAL NOT NULL CONSTRAINT unsigned_doc_changes CHECK(change_id BETWEEN 0 AND 4294967295),
+    change_id int NOT NULL CHECK(change_id BETWEEN 0 AND 4294967295),
     user_id NVARCHAR(255) NOT NULL,
     user_id_original NVARCHAR(255) NOT NULL,
     user_name NVARCHAR(255) NOT NULL,
     change_data NVARCHAR(MAX) NOT NULL,
     change_date DATETIME NOT NULL,
-    UNIQUE (tenant, id, change_id)
-);
+    PRIMARY KEY (tenant, id, change_id)
+) WITH (DATA_COMPRESSION = PAGE);
 
 CREATE TABLE task_result (
     tenant NVARCHAR(255) NOT NULL,
     id NVARCHAR(255) NOT NULL,
     status SMALLINT NOT NULL,
     status_info INT NOT NULL,
-    created_at DATETIME DEFAULT CURRENT_TIMESTAMP NOT NULL,
+    created_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     last_open_date DATETIME NOT NULL,
-    user_index DECIMAL DEFAULT 1 NOT NULL,
-    change_id DECIMAL DEFAULT 0 NOT NULL,
+    user_index int NOT NULL DEFAULT 1 CHECK(user_index BETWEEN 0 AND 4294967295),
+    change_id int NOT NULL DEFAULT 0 CHECK(change_id BETWEEN 0 AND 4294967295),
     callback NVARCHAR(MAX) NOT NULL,
     baseurl NVARCHAR(MAX) NOT NULL,
     password NVARCHAR(MAX) NULL,
     additional NVARCHAR(MAX) NULL,
-    UNIQUE (tenant, id),
-    CONSTRAINT unsigned_task_result CHECK(change_id BETWEEN 0 AND 4294967295 AND user_index BETWEEN 0 AND 4294967295)
-);
-
+    PRIMARY KEY (tenant, id)
+) WITH (DATA_COMPRESSION = PAGE);
 GO
diff --git a/schema/mssql/removetbl.sql b/schema/mssql/removetbl.sql
index a0fc5dbb..1e2e89b5 100644
--- a/schema/mssql/removetbl.sql
+++ b/schema/mssql/removetbl.sql
@@ -1,2 +1,9 @@
+-- SQL Server table removal for ONLYOFFICE
+-- Requires SQL Server 2016 (13.x) or newer
+-- Features used:
+--   - DROP TABLE IF EXISTS (SQL Server 2016+)
+
 -- USE onlyoffice;
-DROP TABLE IF EXISTS doc_changes, task_result;
\ No newline at end of file
+DROP TABLE IF EXISTS task_result;
+DROP TABLE IF EXISTS doc_changes;
+GO
\ No newline at end of file