pengjunjie/server
1
0
Fork 1
mirror of https://github.com/ONLYOFFICE/server.git synced 2026-04-07 14:04:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

[test] Add test for updateIf with empty callback; For bug 77666

Browse Source
This commit is contained in:
Sergey Konovalov
2025-10-16 15:28:27 +03:00
parent c7a03c97a7
commit 6332a524f7
1 changed files with 45 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/integration/databaseTests/baseConnector.tests.js
View File

@ -100,6 +100,10 @@ const upsertCases = {
insert: 'baseConnector-upsert()-tester-row-inserted', insert: 'baseConnector-upsert()-tester-row-inserted',
update: 'baseConnector-upsert()-tester-row-updated' update: 'baseConnector-upsert()-tester-row-updated'
}; };
const updateIfCases = {
notEmpty: 'baseConnector-updateIf()-tester-not-empty-callback',
emptyCallback: 'baseConnector-updateIf()-tester-empty-callback'
};
function createChanges(changesLength, date) { function createChanges(changesLength, date) {
const objChanges = [ const objChanges = [
@ -203,9 +207,10 @@ afterAll(async () => {
const insertIds = Object.values(insertCases); const insertIds = Object.values(insertCases);
const changesIds = Object.values(changesCases); const changesIds = Object.values(changesCases);
const upsertIds = Object.values(upsertCases); const upsertIds = Object.values(upsertCases);
const updateIfIds = Object.values(updateIfCases);
const tableChangesIds = [...emptyCallbacksCase, ...documentsWithChangesCase, ...changesIds, ...insertIds]; const tableChangesIds = [...emptyCallbacksCase, ...documentsWithChangesCase, ...changesIds, ...insertIds];
const tableResultIds = [...emptyCallbacksCase, ...documentsWithChangesCase, ...getExpiredCase, ...getCountWithStatusCase, ...upsertIds]; const tableResultIds = [...emptyCallbacksCase, ...documentsWithChangesCase, ...getExpiredCase, ...getCountWithStatusCase, ...upsertIds, ...updateIfIds];
const deletionPool = [ const deletionPool = [
deleteRowsByIds(cfgTableChanges, tableChangesIds), deleteRowsByIds(cfgTableChanges, tableChangesIds),
@ -469,4 +474,43 @@ describe('Base database connector', () => {
expect(updatedRow).toEqual(expectedUrlChanges); expect(updatedRow).toEqual(expectedUrlChanges);
}); });
}); });
describe('updateIf() method', () => {
test('Update with NOT_EMPTY callback mask', async () => {
const date = new Date();
const taskWithCallback = createTask(updateIfCases.notEmpty, 'http://example.com/callback');
const taskEmptyCallback = createTask(updateIfCases.emptyCallback, '');
// Insert two rows: one with callback, one without
await Promise.all([
insertIntoResultTable(date, taskWithCallback),
insertIntoResultTable(date, taskEmptyCallback)
]);
// Update mask: only update rows with non-empty callback and status=None
const mask = new taskResult.TaskResultData();
mask.tenant = ctx.tenant;
mask.key = taskWithCallback.key;
mask.status = commonDefines.FileStatus.None;
mask.callback = 'NOT_EMPTY';
// Update task: change status to SaveVersion
const updateTask = new taskResult.TaskResultData();
updateTask.status = commonDefines.FileStatus.SaveVersion;
updateTask.statusInfo = constants.NO_ERROR;
const result = await taskResult.updateIf(ctx, updateTask, mask);
// Should update exactly 1 row (the one with callback)
expect(result.affectedRows).toEqual(1);
// Verify the row with callback was updated
const updatedRow = await executeSql(`SELECT status FROM ${cfgTableResult} WHERE id = '${taskWithCallback.key}';`);
expect(updatedRow[0].status).toEqual(commonDefines.FileStatus.SaveVersion);
// Verify the row without callback was NOT updated
const notUpdatedRow = await executeSql(`SELECT status FROM ${cfgTableResult} WHERE id = '${taskEmptyCallback.key}';`);
expect(notUpdatedRow[0].status).toEqual(commonDefines.FileStatus.None);
});
});
}); });