Refactor code (#8341)

### What problem does this PR solve?

1. rename var
2. update if statement

### Type of change

- [x] Refactoring

---------

Signed-off-by: Jin Hai <haijin.chn@gmail.com>
Co-authored-by: Kevin Hu <kevinhu.sh@gmail.com>
This commit is contained in:
Jin Hai
2025-06-18 16:40:30 +08:00
committed by GitHub
parent e96cf89524
commit e470645efd
7 changed files with 45 additions and 45 deletions

View File

@ -174,10 +174,10 @@ class TestDocumentsUpdated:
assert res["code"] == expected_code
if expected_code == 0:
res = list_documents(HttpApiAuth, dataset_id, {"id": document_ids[0]})
if chunk_method != "":
assert res["data"]["docs"][0]["chunk_method"] == chunk_method
else:
if chunk_method == "":
assert res["data"]["docs"][0]["chunk_method"] == "naive"
else:
assert res["data"]["docs"][0]["chunk_method"] == chunk_method
else:
assert res["message"] == expected_message
@ -533,10 +533,7 @@ class TestUpdateDocumentParserConfig:
assert res["code"] == expected_code
if expected_code == 0:
res = list_documents(HttpApiAuth, dataset_id, {"id": document_ids[0]})
if parser_config != {}:
for k, v in parser_config.items():
assert res["data"]["docs"][0]["parser_config"][k] == v
else:
if parser_config == {}:
assert res["data"]["docs"][0]["parser_config"] == {
"chunk_token_num": 128,
"delimiter": r"\n",
@ -544,5 +541,8 @@ class TestUpdateDocumentParserConfig:
"layout_recognize": "DeepDOC",
"raptor": {"use_raptor": False},
}
else:
for k, v in parser_config.items():
assert res["data"]["docs"][0]["parser_config"][k] == v
if expected_code != 0 or expected_message:
assert res["message"] == expected_message

View File

@ -163,10 +163,10 @@ class TestSessionsWithChatAssistantList:
res = list_session_with_chat_assistants(HttpApiAuth, chat_assistant_id, params=params)
assert res["code"] == expected_code
if expected_code == 0:
if params["name"] != "session_with_chat_assistant_1":
assert len(res["data"]) == expected_num
else:
if params["name"] == "session_with_chat_assistant_1":
assert res["data"][0]["name"] == params["name"]
else:
assert len(res["data"]) == expected_num
else:
assert res["message"] == expected_message
@ -190,10 +190,10 @@ class TestSessionsWithChatAssistantList:
res = list_session_with_chat_assistants(HttpApiAuth, chat_assistant_id, params=params)
assert res["code"] == expected_code
if expected_code == 0:
if params["id"] != session_ids[0]:
assert len(res["data"]) == expected_num
else:
if params["id"] == session_ids[0]:
assert res["data"][0]["id"] == params["id"]
else:
assert len(res["data"]) == expected_num
else:
assert res["message"] == expected_message

View File

@ -126,10 +126,10 @@ class TestSessionsWithChatAssistantList:
assert expected_message in str(excinfo.value)
else:
sessions = chat_assistant.list_sessions(**params)
if params["name"] != "session_with_chat_assistant_1":
assert len(sessions) == expected_num
else:
if params["name"] == "session_with_chat_assistant_1":
assert sessions[0].name == params["name"]
else:
assert len(sessions) == expected_num
@pytest.mark.p1
@pytest.mark.parametrize(
@ -154,10 +154,10 @@ class TestSessionsWithChatAssistantList:
assert expected_message in str(excinfo.value)
else:
list_sessions = chat_assistant.list_sessions(**params)
if "id" in params and params["id"] != sessions[0].id:
assert len(list_sessions) == expected_num
else:
if "id" in params and params["id"] == sessions[0].id:
assert list_sessions[0].id == params["id"]
else:
assert len(list_sessions) == expected_num
@pytest.mark.p3
@pytest.mark.parametrize(