From dc95bd6a7c10bd7362d3da87f6a83222ca8aaa61 Mon Sep 17 00:00:00 2001
From: Scott Davidson <49713135+sd109@users.noreply.github.com>
Date: Thu, 24 Jul 2025 03:15:11 +0100
Subject: [PATCH] Ensure Redis volumeClaimTemplate labels are deterministic
 (#9016)

### What problem does this PR solve?

Previous version created labels which were dependent on the specific
Helm chart version such as:
```
volumeClaimTemplates:
- metadata:
    name: redis-data
    labels:
      helm.sh/chart: ragflow-0.2.3-dev.0.opensearch-test.4
      app.kubernetes.io/name: ragflow
      app.kubernetes.io/instance: test-1
      app.kubernetes.io/version: "9a04408"
      app.kubernetes.io/managed-by: Helm
      app.kubernetes.io/component: redis
```
which causes `helm upgrade` commands to fail with
```
Upgrade "test-1" failed: cannot patch "test-1-ragflow-redis" with
kind StatefulSet: StatefulSet.apps "test-1-ragflow-redis" is
invalid: spec: Forbidden: updates to statefulset spec for fields
other than 'replicas', 'ordinals', 'template', 'updateStrategy',
'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are
forbidden
```
because the labels changed on upgrade.

This fix uses a reduced set of labels to prevent upgrade failures.

### Type of change

- [X] Bug Fix (non-breaking change which fixes an issue)
---
 helm/templates/redis.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/helm/templates/redis.yaml b/helm/templates/redis.yaml
index 53e7a6781..8c94982e3 100644
--- a/helm/templates/redis.yaml
+++ b/helm/templates/redis.yaml
@@ -68,7 +68,7 @@ spec:
     - metadata:
         name: redis-data
         labels:
-          {{- include "ragflow.labels" . | nindent 10 }}
+          {{- include "ragflow.selectorLabels" . | nindent 10 }}
           app.kubernetes.io/component: redis
       spec:
         accessModes:
@@ -109,4 +109,4 @@ spec:
   selector:
     matchLabels:
       {{- include "ragflow.selectorLabels" . | nindent 6 }}
-      app.kubernetes.io/component: redis
\ No newline at end of file
+      app.kubernetes.io/component: redis