pengjunjie/ragflow
1
0
Fork 1
mirror of https://github.com/infiniflow/ragflow.git synced 2025-12-08 20:42:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Test: handle duplicate names by appending "(1)" (#11244)

Browse Source 
### What problem does this PR solve?

- Updated tests to reflect new behavior of handling duplicate dataset
names
- Instead of returning an error, the system now appends "(1)" to
duplicate names
- This problem was introduced by PR #10960

### Type of change

- [x] Testcase update
This commit is contained in:
Liu An
2025-11-13 15:18:32 +08:00
committed by GitHub
parent 871055b0fc
commit bfc84ba95b
2 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/testcases/test_http_api/test_dataset_mangement/test_create_dataset.py
View File

@ -16,14 +16,15 @@
from concurrent.futures import ThreadPoolExecutor, as_completed from concurrent.futures import ThreadPoolExecutor, as_completed
import pytest import pytest
from common import create_dataset from configs import DATASET_NAME_LIMIT, DEFAULT_PARSER_CONFIG, INVALID_API_TOKEN
from configs import DATASET_NAME_LIMIT, INVALID_API_TOKEN
from hypothesis import example, given, settings from hypothesis import example, given, settings
from libs.auth import RAGFlowHttpApiAuth from libs.auth import RAGFlowHttpApiAuth
from utils import encode_avatar from utils import encode_avatar
from utils.file_utils import create_image_file from utils.file_utils import create_image_file
from utils.hypothesis_utils import valid_names from utils.hypothesis_utils import valid_names
from configs import DEFAULT_PARSER_CONFIG
from common import create_dataset
@pytest.mark.usefixtures("clear_datasets") @pytest.mark.usefixtures("clear_datasets")
class TestAuthorization: class TestAuthorization:
@ -125,8 +126,8 @@ class TestDatasetCreate:
assert res["code"] == 0, res assert res["code"] == 0, res
res = create_dataset(HttpApiAuth, payload) res = create_dataset(HttpApiAuth, payload)
assert res["code"] == 103, res assert res["code"] == 0, res
assert res["message"] == f"Dataset name '{name}' already exists", res assert res["data"]["name"] == name + "(1)", res
@pytest.mark.p3 @pytest.mark.p3
def test_name_case_insensitive(self, HttpApiAuth): def test_name_case_insensitive(self, HttpApiAuth):
@ -137,8 +138,8 @@ class TestDatasetCreate:
payload = {"name": name.lower()} payload = {"name": name.lower()}
res = create_dataset(HttpApiAuth, payload) res = create_dataset(HttpApiAuth, payload)
assert res["code"] == 103, res assert res["code"] == 0, res
assert res["message"] == f"Dataset name '{name.lower()}' already exists", res assert res["data"]["name"] == name.lower() + "(1)", res
@pytest.mark.p2 @pytest.mark.p2
def test_avatar(self, HttpApiAuth, tmp_path): def test_avatar(self, HttpApiAuth, tmp_path):

14
test/testcases/test_sdk_api/test_dataset_mangement/test_create_dataset.py
View File

@ -17,13 +17,13 @@ from concurrent.futures import ThreadPoolExecutor, as_completed
from operator import attrgetter from operator import attrgetter
import pytest import pytest
from configs import DATASET_NAME_LIMIT, HOST_ADDRESS, INVALID_API_TOKEN from configs import DATASET_NAME_LIMIT, DEFAULT_PARSER_CONFIG, HOST_ADDRESS, INVALID_API_TOKEN
from hypothesis import example, given, settings from hypothesis import example, given, settings
from ragflow_sdk import DataSet, RAGFlow from ragflow_sdk import DataSet, RAGFlow
from utils import encode_avatar from utils import encode_avatar
from utils.file_utils import create_image_file from utils.file_utils import create_image_file
from utils.hypothesis_utils import valid_names from utils.hypothesis_utils import valid_names
from configs import DEFAULT_PARSER_CONFIG
@pytest.mark.usefixtures("clear_datasets") @pytest.mark.usefixtures("clear_datasets")
class TestAuthorization: class TestAuthorization:
@ -95,9 +95,8 @@ class TestDatasetCreate:
payload = {"name": name} payload = {"name": name}
client.create_dataset(**payload) client.create_dataset(**payload)
with pytest.raises(Exception) as excinfo: dataset = client.create_dataset(**payload)
client.create_dataset(**payload) assert dataset.name == name + "(1)", str(dataset)
assert str(excinfo.value) == f"Dataset name '{name}' already exists", str(excinfo.value)
@pytest.mark.p3 @pytest.mark.p3
def test_name_case_insensitive(self, client): def test_name_case_insensitive(self, client):
@ -106,9 +105,8 @@ class TestDatasetCreate:
client.create_dataset(**payload) client.create_dataset(**payload)
payload = {"name": name.lower()} payload = {"name": name.lower()}
with pytest.raises(Exception) as excinfo: dataset = client.create_dataset(**payload)
client.create_dataset(**payload) assert dataset.name == name.lower() + "(1)", str(dataset)
assert str(excinfo.value) == f"Dataset name '{name.lower()}' already exists", str(excinfo.value)
@pytest.mark.p2 @pytest.mark.p2
def test_avatar(self, client, tmp_path): def test_avatar(self, client, tmp_path):