Fix unreachable code in loop.py and iteration.py

Co-authored-by: JinHai-CN <33142505+JinHai-CN@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-06 02:18:09 +00:00
parent 22f17f6334
commit a0a7eb9100
2 changed files with 24 additions and 28 deletions

View File

@ -57,12 +57,10 @@ class Iteration(ComponentBase, ABC):
return cid return cid
def _invoke(self, **kwargs): def _invoke(self, **kwargs):
if self.check_if_canceled("Iteration processing"): if not self.check_if_canceled("Iteration processing"):
return arr = self._canvas.get_variable_value(self._param.items_ref)
if not isinstance(arr, list):
arr = self._canvas.get_variable_value(self._param.items_ref) self.set_output("_ERROR", self._param.items_ref + " must be an array, but its type is "+str(type(arr)))
if not isinstance(arr, list):
self.set_output("_ERROR", self._param.items_ref + " must be an array, but its type is "+str(type(arr)))
def thoughts(self) -> str: def thoughts(self) -> str:
return "Need to process {} items.".format(len(self._canvas.get_variable_value(self._param.items_ref))) return "Need to process {} items.".format(len(self._canvas.get_variable_value(self._param.items_ref)))

View File

@ -51,29 +51,27 @@ class Loop(ComponentBase, ABC):
return cid return cid
def _invoke(self, **kwargs): def _invoke(self, **kwargs):
if self.check_if_canceled("Loop processing"): if not self.check_if_canceled("Loop processing"):
return for item in self._param.loop_variables:
if any([not item.get("variable"), not item.get("input_mode"), not item.get("value"),not item.get("type")]):
for item in self._param.loop_variables: assert "Loop Variable is not complete."
if any([not item.get("variable"), not item.get("input_mode"), not item.get("value"),not item.get("type")]): if item["input_mode"]=="variable":
assert "Loop Variable is not complete." self.set_output(item["variable"],self._canvas.get_variable_value(item["value"]))
if item["input_mode"]=="variable": elif item["input_mode"]=="constant":
self.set_output(item["variable"],self._canvas.get_variable_value(item["value"])) self.set_output(item["variable"],item["value"])
elif item["input_mode"]=="constant":
self.set_output(item["variable"],item["value"])
else:
if item["type"] == "number":
self.set_output(item["variable"], 0)
elif item["type"] == "string":
self.set_output(item["variable"], "")
elif item["type"] == "boolean":
self.set_output(item["variable"], False)
elif item["type"].startswith("object"):
self.set_output(item["variable"], {})
elif item["type"].startswith("array"):
self.set_output(item["variable"], [])
else: else:
self.set_output(item["variable"], "") if item["type"] == "number":
self.set_output(item["variable"], 0)
elif item["type"] == "string":
self.set_output(item["variable"], "")
elif item["type"] == "boolean":
self.set_output(item["variable"], False)
elif item["type"].startswith("object"):
self.set_output(item["variable"], {})
elif item["type"].startswith("array"):
self.set_output(item["variable"], [])
else:
self.set_output(item["variable"], "")
def thoughts(self) -> str: def thoughts(self) -> str: