From 97401c1e33067720058ae4eac7a6a19377b6ffd2 Mon Sep 17 00:00:00 2001 From: Adrian Altermatt Date: Mon, 27 Oct 2025 04:09:20 +0100 Subject: [PATCH] Removing value={field} from EditTag (#10767) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### What problem does this PR solve? Could not delete Entity Types from the Knowledge Graph settings. The list was not updated on pressing the X on a tag. What I think happened: - value={field} was passing ['parser_config','entity_types'] to EditTag instead of the real tags. - That blocked AntD Form from injecting the right value/onChange. - Clicking X filtered the wrong “value,” so no visible change. Fix: - Remove value={field} and let Form.Item control EditTag. - EditTag now gets the real tags array and emits onChange(tags), Form captures it. Now it works. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) --- web/src/components/entity-types-item.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/components/entity-types-item.tsx b/web/src/components/entity-types-item.tsx index ba26e5f4c..3a6ccb858 100644 --- a/web/src/components/entity-types-item.tsx +++ b/web/src/components/entity-types-item.tsx @@ -25,7 +25,7 @@ const EntityTypesItem = ({ rules={[{ required: true }]} initialValue={initialEntityTypes} > - + ); };