From 922b5c652dee12e092ef252224813be7c5ad9bf3 Mon Sep 17 00:00:00 2001 From: Jin Hai Date: Thu, 25 Sep 2025 12:05:43 +0800 Subject: [PATCH] Refactor: fix typos (#10200) ### What problem does this PR solve? 1. Fix typos 2. Rename function 3. Use English to write comment ### Type of change - [x] Refactoring Signed-off-by: jinhai --- agent/component/base.py | 2 +- agent/component/categorize.py | 2 +- agent/component/llm.py | 8 ++++---- agent/component/message.py | 6 +++--- api/apps/sdk/files.py | 6 +++--- api/db/__init__.py | 2 +- api/db/services/__init__.py | 4 ++-- 7 files changed, 15 insertions(+), 15 deletions(-) diff --git a/agent/component/base.py b/agent/component/base.py index a622046e6..daf974dc7 100644 --- a/agent/component/base.py +++ b/agent/component/base.py @@ -244,7 +244,7 @@ class ComponentParamBase(ABC): if not value_legal: raise ValueError( - "Plase check runtime conf, {} = {} does not match user-parameter restriction".format( + "Please check runtime conf, {} = {} does not match user-parameter restriction".format( variable, value ) ) diff --git a/agent/component/categorize.py b/agent/component/categorize.py index d25518d09..3f1188363 100644 --- a/agent/component/categorize.py +++ b/agent/component/categorize.py @@ -28,7 +28,7 @@ from rag.llm.chat_model import ERROR_PREFIX class CategorizeParam(LLMParam): """ - Define the Categorize component parameters. + Define the categorize component parameters. """ def __init__(self): super().__init__() diff --git a/agent/component/llm.py b/agent/component/llm.py index 4e4dbcfe6..555761704 100644 --- a/agent/component/llm.py +++ b/agent/component/llm.py @@ -81,9 +81,9 @@ class LLMParam(ComponentParamBase): class LLM(ComponentBase): component_name = "LLM" - - def __init__(self, canvas, id, param: ComponentParamBase): - super().__init__(canvas, id, param) + + def __init__(self, canvas, component_id, param: ComponentParamBase): + super().__init__(canvas, component_id, param) self.chat_mdl = LLMBundle(self._canvas.get_tenant_id(), TenantLLMService.llm_id2llm_type(self._param.llm_id), self._param.llm_id, max_retries=self._param.max_retries, retry_interval=self._param.delay_after_error @@ -209,7 +209,7 @@ class LLM(ComponentBase): return re.sub(r"```\n*$", "", ans, flags=re.DOTALL) prompt, msg, _ = self._prepare_prompt_variables() - error = "" + error: str = "" if self._param.output_structure: prompt += "\nThe output MUST follow this JSON format:\n"+json.dumps(self._param.output_structure, ensure_ascii=False, indent=2) diff --git a/agent/component/message.py b/agent/component/message.py index b991ad21d..1e4641e85 100644 --- a/agent/component/message.py +++ b/agent/component/message.py @@ -49,7 +49,7 @@ class MessageParam(ComponentParamBase): class Message(ComponentBase): component_name = "Message" - def get_kwargs(self, script:str, kwargs:dict = {}, delimeter:str=None) -> tuple[str, dict[str, str | list | Any]]: + def get_kwargs(self, script:str, kwargs:dict = {}, delimiter:str=None) -> tuple[str, dict[str, str | list | Any]]: for k,v in self.get_input_elements_from_text(script).items(): if k in kwargs: continue @@ -60,8 +60,8 @@ class Message(ComponentBase): if isinstance(v, partial): for t in v(): ans += t - elif isinstance(v, list) and delimeter: - ans = delimeter.join([str(vv) for vv in v]) + elif isinstance(v, list) and delimiter: + ans = delimiter.join([str(vv) for vv in v]) elif not isinstance(v, str): try: ans = json.dumps(v, ensure_ascii=False) diff --git a/api/apps/sdk/files.py b/api/apps/sdk/files.py index 84491a02c..96efe208d 100644 --- a/api/apps/sdk/files.py +++ b/api/apps/sdk/files.py @@ -83,16 +83,16 @@ def upload(tenant_id): return get_json_result(data=False, message="Can't find this folder!", code=404) for file_obj in file_objs: - # 文件路径处理 + # Handle file path full_path = '/' + file_obj.filename file_obj_names = full_path.split('/') file_len = len(file_obj_names) - # 获取文件夹路径ID + # Get folder path ID file_id_list = FileService.get_id_list_by_id(pf_id, file_obj_names, 1, [pf_id]) len_id_list = len(file_id_list) - # 创建文件夹结构 + # Crete file folder if file_len != len_id_list: e, file = FileService.get_by_id(file_id_list[len_id_list - 1]) if not e: diff --git a/api/db/__init__.py b/api/db/__init__.py index 186e9bcba..992ec2818 100644 --- a/api/db/__init__.py +++ b/api/db/__init__.py @@ -111,7 +111,7 @@ class CanvasCategory(StrEnum): Agent = "agent_canvas" DataFlow = "dataflow_canvas" -VALID_CAVAS_CATEGORIES = {CanvasCategory.Agent, CanvasCategory.DataFlow} +VALID_CANVAS_CATEGORIES = {CanvasCategory.Agent, CanvasCategory.DataFlow} class MCPServerType(StrEnum): diff --git a/api/db/services/__init__.py b/api/db/services/__init__.py index 4b3af3ecf..ce937911f 100644 --- a/api/db/services/__init__.py +++ b/api/db/services/__init__.py @@ -19,7 +19,7 @@ from pathlib import PurePath from .user_service import UserService as UserService -def split_name_counter(filename: str) -> tuple[str, int | None]: +def _split_name_counter(filename: str) -> tuple[str, int | None]: """ Splits a filename into main part and counter (if present in parentheses). @@ -87,7 +87,7 @@ def duplicate_name(query_func, **kwargs) -> str: stem = path.stem suffix = path.suffix - main_part, counter = split_name_counter(stem) + main_part, counter = _split_name_counter(stem) counter = counter + 1 if counter else 1 new_name = f"{main_part}({counter}){suffix}"