From 6599db1e99aee421790d607ec7475172be89516d Mon Sep 17 00:00:00 2001 From: liu an Date: Wed, 26 Mar 2025 19:23:13 +0800 Subject: [PATCH] Test: Update test cases for PR #6405 #6504 #6538 (#6565) ### What problem does this PR solve? PR #6405 #6504 #6538 ### Type of change - [x] update test cases --- .../test_add_chunk.py | 10 +++------- .../test_list_chunks.py | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_add_chunk.py b/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_add_chunk.py index 07f5ad2a7..79fd6ec5e 100644 --- a/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_add_chunk.py +++ b/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_add_chunk.py @@ -28,7 +28,7 @@ def validate_chunk_details(dataset_id, document_id, payload, res): if "important_keywords" in payload: assert chunk["important_keywords"] == payload["important_keywords"] if "questions" in payload: - assert chunk["questions"] == payload["questions"] + assert chunk["questions"] == [str(q).strip() for q in payload.get("questions", []) if str(q).strip()] class TestAuthorization: @@ -119,12 +119,7 @@ class TestAddChunk: "payload, expected_code, expected_message", [ ({"content": "chunk test", "questions": ["a", "b", "c"]}, 0, ""), - pytest.param( - {"content": "chunk test", "questions": [""]}, - 0, - "", - marks=pytest.mark.skip(reason="issues/6404"), - ), + ({"content": "chunk test", "questions": [""]}, 0, ""), ({"content": "chunk test", "questions": [1]}, 100, "TypeError('sequence item 0: expected str instance, int found')"), ({"content": "chunk test", "questions": ["a", "a"]}, 0, ""), ({"content": "chunk test", "questions": "abc"}, 102, "`questions` is required to be a list"), @@ -138,6 +133,7 @@ class TestAddChunk: assert False, res chunks_count = res["data"]["doc"]["chunk_count"] res = add_chunk(get_http_api_auth, dataset_id, document_id, payload) + print(res) assert res["code"] == expected_code if expected_code == 0: validate_chunk_details(dataset_id, document_id, payload, res) diff --git a/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_list_chunks.py b/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_list_chunks.py index 75517105e..cf70fd7be 100644 --- a/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_list_chunks.py +++ b/sdk/python/test/test_http_api/test_chunk_management_within_dataset/test_list_chunks.py @@ -109,7 +109,7 @@ class TestChunksList: [ (None, 0, 5, ""), ("", 0, 5, ""), - pytest.param(lambda r: r[0], 0, 1, "", marks=pytest.mark.skip(reason="issues/6499")), + pytest.param(lambda r: r[0], 0, 1, "", marks=pytest.mark.skipif(os.getenv("DOC_ENGINE") == "infinity", reason="issues/6499")), pytest.param("unknown", 100, 0, """AttributeError("\'NoneType\' object has no attribute \'keys\'")""", marks=pytest.mark.skip), ], )