33 Commits

Author	SHA1	Message	Date
Jordan Frazier	71cd5ce376	feat: improve lfx serve production-readiness (#13121) ... * docs: add design spec for lfx serve multi-flow startup and dynamic upload * docs: add implementation plan for lfx serve multi-flow startup and dynamic upload * feat(serve): add FlowRegistry for mutable in-process flow management * feat(serve): add flow_id_from_content for content-based flow ID generation * fix(test): update streaming tests to use FlowRegistry API * test(serve): add upload endpoint tests * feat(serve): add build_registry_from_directory and build_registry_from_paths helpers * refactor(serve): remove dead _analyze_graph_structure and _generate_dynamic_run_description helpers * feat(serve): accept directory and multiple file paths at startup; wire registry to serve_command * [autofix.ci] apply automated fixes * fix(serve): move traceback import to module level; remove planning docs from branch * [autofix.ci] apply automated fixes * fix(serve): deepcopy graph in stream_flow; use json.dumps for error stream payload * test(serve): verify stream setup error payload is valid JSON with special characters * [autofix.ci] apply automated fixes * fix(serve): use load_flow_from_json directly in _load_graph_and_meta for clear error messages * docs(serve): document multi-worker and persistence limitations on FlowRegistry * feat(serve): allow starting server with no flows; accept full Langflow flow JSON on upload - Remove the requirement for a flow path/JSON/stdin at startup; lfx serve now starts with an empty FlowRegistry when no input is provided, ready to accept flows via POST /flows/upload/ - UploadFlowRequest now accepts the full Langflow export JSON directly (extra="allow", id field added) so callers can do -d @flow.json without wrapping; load_flow_from_json receives the full dict and the flow's own stable id is used when present * fix(serve): harden upload endpoint and remove unused verbose_print param - Pass body.model_dump(exclude={"replace"}) to load_flow_from_json instead of body.model_dump(); keeps the top-level "data" key the function expects while excluding the internal replace flag - Set graph.flow_id after upload so it matches the registry key - Return 409 Conflict on duplicate flow ID; add replace=true field to allow explicit overwrite - Remove unused verbose_print param from _load_graph_and_meta and update callers - Clarify directory scan is top-level only (non-recursive) in CLI help text - Add test_upload_full_export_as_body regression test: sends a complete Langflow export JSON as the request body (curl -d @flow.json pattern) where body.data has no nested "data" key — would have caught the KeyError('data') regression * fix(serve): address PR review comments - Restore .py script support: _load_graph_and_meta now dispatches to load_graph_from_script for .py paths; CLI validation accepts .json and .py; help text updated in both _running_commands.py and commands.py - Fix flow ID collision in build_registry_from_paths: compute a shared common root from all supplied paths so same-named files in different directories get distinct UUIDv5 IDs instead of silently overwriting each other - Harden FlowRegistry.add(): add overwrite=False parameter that raises ValueError on duplicate IDs; startup paths keep default (collision = error), upload endpoint passes overwrite=body.replace - Add regression test: test_same_filename_in_different_dirs_gets_distinct_ids - Update test_duplicate_add_replaces_graph to reflect new overwrite semantics * test(serve): add unit tests for .py script path in serve command - test_load_graph_and_meta_dispatches_to_script_loader_for_py: verifies _load_graph_and_meta calls load_graph_from_script (not load_flow_from_json) for .py paths, and that meta.title and relative_path are set correctly - test_serve_command_accepts_py_file: end-to-end check that lfx serve my.py reaches the server (exit_code == 0) - test_serve_command_rejects_unsupported_extension: .txt and other unknown extensions must exit non-zero with a helpful message * [autofix.ci] apply automated fixes * Add --no-env-fallback option to support scoped request_vars * [autofix.ci] apply automated fixes * feat(serve): filesystem-backed flow registry for multi-worker sharing Adds a FlowStore abstraction with two implementations: - NullFlowStore (default): in-memory only, existing behavior unchanged - FilesystemFlowStore: persists each flow as {id}.json; writes are atomic (tmp→rename); reads and deletes are TOCTOU-safe; path traversal guard rejects unsafe flow IDs FlowRegistry now delegates persistence to FlowStore: - add(raw_json=...) writes to store when raw JSON is available - get() falls through to store on cache miss, reconstructs + caches - list_metas() merges in-memory and store-side entries - remove() propagates deletion to store - warm_from_store() pre-warms the in-memory cache at startup New --flow-dir option on lfx serve activates the filesystem store. All uvicorn workers pointing at the same directory serve the same flows — use /tmp/lfx-flows for single-pod sharing or a PVC mount for cross-pod sharing. Raw JSON is plumbed through _load_graph_and_meta and both builder functions so startup-loaded .json flows are persisted automatically; .py flows remain in-memory only. * feat(serve): add --workers option for multi-worker uvicorn support Adds --workers N to lfx serve, enabling multiple uvicorn processes to share flows via --flow-dir. serve_command is restructured from @syncify async to plain sync: all async registry-building is extracted into _build_serve_registry() and called via asyncio.run(), then uvicorn.run() handles the server. For workers > 1, uvicorn requires an import string rather than an app object. The factory create_serve_app() in serve_app.py reads LFX_SERVE_FLOW_DIR and LFX_SERVE_NO_ENV_FALLBACK from env, pre-warms from the shared FilesystemFlowStore, and returns a ready FastAPI app. The parent sets those env vars unconditionally before dispatching. For workers == 1, the pre-built app object is used directly (no change to existing single-worker behavior). A warning is emitted when --workers > 1 is used without --flow-dir since each worker would have an isolated in-memory registry. The startup panel flow count is now accurate for single-worker + --flow-dir by calling warm_from_store() before printing. * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * [autofix.ci] apply automated fixes (attempt 3/3) * fix(serve): remove no_args_is_help, drop verbose_print param, harden _safe_path - Remove no_args_is_help=True from serve command so lfx serve with no arguments starts with an empty registry instead of showing help - Remove unused verbose_print parameter from create_multi_serve_app and update all callers (14 call sites across tests) - Wrap _safe_path's relative_to() check in try/except for a clear error message; restructure delete() to use try/except/else (TRY300) - Add TYPE_CHECKING guard for FlowStore annotation in commands.py; wrap long --workers help string; restore FBT003 noqa on no_env_fallback - Fix test_env_fallback_skipped_when_flag_true to allow logger's getenv calls while still asserting the credential variable is never looked up - Fix ARG002/D205/RUF059 lint issues in test files * [autofix.ci] apply automated fixes * fix(serve): resolve merge conflicts and clean up test section comments * ruff - test updates * fix(serve): cross-worker delete propagation and HTTP 500 for execution failures Cross-worker stale cache (multi-worker DELETE bug): - Add FlowStore.is_persistent to distinguish real stores from NullFlowStore - Track _store_sourced in FlowRegistry for flows written to a persistent store - get() re-reads the store for store-sourced flows to detect cross-worker deletes; evicts and returns None if the file is gone - list_metas() skips store-sourced flows whose store key is no longer present - Add _evict() helper to clean up _flows, _store_meta_cache, _store_keys, _store_sourced HTTP status for execution failures: - POST /flows/{id}/run now returns HTTP 500 (not 200) when execution raises or when the flow returns success=false; body is still RunResponse for debug detail - Updated OpenAPI responses declaration: 500 now maps to RunResponse model * fix(serve): harden multi-worker registry correctness and safety - Add FlowAlreadyRegisteredError (ValueError subclass) so upload_flow catches only the specific race-condition exception rather than any ValueError from unrelated internals. - Add _SERVE_ENV_PREFIX constant; rebuild LFX_SERVE_* env var names from it and add try/finally cleanup so those vars are always deleted after uvicorn.run() returns in multi-worker mode. - Reject .py startup files when --workers > 1: Python graphs cannot be serialized to the filesystem store so workers would silently start with empty registries for those flows. - Remove warm_from_store() from build_registry_from_paths/directory; the builders no longer pre-warm to avoid double-loading when the startup dir and flow-dir overlap. serve_command still warms for single-worker mode. - Fix FlowRegistry.__len__ to delegate to list_metas() so store-only flows (not yet cache-loaded) are counted; this makes the startup panel and /health flow_count accurate for multi-worker + pre-placed files. - Fix FlowRegistry.remove() to delete both the primary store key file and any alternate-keyed file (UUID or stem), ensuring cross-worker DELETE propagation: after a delete, every worker's next request to that flow triggers the per-request stale check, reads None from the store, and returns 404 regardless of which key its cache entry uses. - Document the per-request stale check in FlowRegistry docstring with latency guidance for network volumes vs. local tmpfs. - Add tests for all of the above, including a cross-worker DELETE propagation scenario validated by a live 2-worker integration test. * fix(serve): load startup flows in every uvicorn worker via LFX_SERVE_STARTUP_PATHS Previously, lfx serve flow.json --workers 4 silently dropped startup flows: the parent loaded them into a NullFlowStore registry that workers never inherited. Each worker called create_serve_app() fresh and started empty, returning flow_count: 0 from /health and 404 for the startup flow. Fix: before calling uvicorn.run() in multi-worker mode, set LFX_SERVE_STARTUP_PATHS to the JSON-encoded list of resolved startup file paths (or the inline-JSON temp file path). create_serve_app() reads this env var and re-loads the startup flows independently in each worker process using a ThreadPoolExecutor to avoid RuntimeError from asyncio.run() being called inside uvicorn's already-running event loop. Startup flows loaded this way live in each worker's in-memory registry. Uploaded flows still require --flow-dir for cross-worker sharing (existing warning preserved). The LFX_SERVE_* env vars are cleaned up after uvicorn.run() returns via the existing prefix-sweep finally block. Tests added: - test_serve_command_sets_startup_paths_env_for_multi_worker: verifies LFX_SERVE_STARTUP_PATHS is set before uvicorn.run() and cleaned up after - TestCreateServeAppFactory: unit tests for create_serve_app() in all three modes (empty start, with startup paths, empty paths list) * fix(serve): fix 3 worker/store consistency issues Issue 1 — redundant store writes with --flow-dir + startup files + workers > 1: When flow_dir is set the parent already persisted startup flows to the store. create_serve_app() was re-loading and re-writing them in every worker. Fix: create_serve_app() now skips LFX_SERVE_STARTUP_PATHS when flow_dir is set and relies solely on warm_from_store(). Similarly, serve_command now only populates LFX_SERVE_STARTUP_PATHS when flow_dir is NOT set. Issue 2 — .py restriction was too broad: The error blocked .py + --workers > 1 even without --flow-dir, where each worker can safely re-execute the .py via LFX_SERVE_STARTUP_PATHS. The error now only fires when --flow-dir is also set (workers would skip startup paths and warm_from_store, missing the .py flow entirely since it can't be stored). Issue 3 — parent built FastAPI app for multi-worker then discarded it: create_multi_serve_app() was called before the workers > 1 / else branch, building a full FastAPI app that was never served in multi-worker mode. Moved into the else branch so it's only built for single-worker. Tests: - test_create_serve_app_with_flow_dir_skips_startup_paths_uses_store: asserts build_registry_from_paths NOT called when flow_dir is set; flow comes from store via warm_from_store instead. - test_create_serve_app_without_flow_dir_loads_startup_paths_from_files: asserts flow IS loaded when no flow_dir. - test_serve_command_does_not_set_startup_paths_when_flow_dir_set: asserts LFX_SERVE_STARTUP_PATHS is [] when flow_dir is set. - test_serve_command_allows_py_with_multiple_workers_no_flow_dir: asserts .py + workers>1 + no flow_dir is allowed and path appears in env. * test(serve): remove duplicate test and fix mislabeled test name - Remove test_create_serve_app_loads_startup_paths: functionally identical to test_create_serve_app_without_flow_dir_loads_startup_paths_from_files (same setup, same assertions, added in a prior session). - Rename test_verify_api_key_header_takes_precedence to test_verify_api_key_query_param_takes_precedence: the test passes the correct key as the query_param argument and the wrong key as header_param, then asserts the query param value is returned — query param has precedence, not header. The old name was the opposite of what the test actually checks. * [autofix.ci] apply automated fixes * fix(serve): fix concurrent request isolation and startup UX Three bug fixes discovered via live QA: 1. Component.__deepcopy__ produced shallow copies of _outputs_map, _edges, and _components, causing concurrent requests to share the same Output objects across graph copies. Output.cache=True by default: the first request's output.value was served to all subsequent concurrent requests, producing identical responses for different inputs. Fixed by deep-copying all three fields with memo. 2. POST /flows/upload/ without an explicit id used uuid5(content), which is deterministic — two uploads of any flow with the same nodes/edges structure always generated the same UUID and the second always returned 409. Fixed by using uuid4() (random). 3. Startup CLI emitted emoji and exclamation-point decoration in the serve banner and verbose output. Replaced with plain text. * [autofix.ci] apply automated fixes * fix(serve): address PR review comments - Move 409 conflict check before load_flow_from_json+prepare so callers with an explicit id don't pay the parse cost for a flow that will be rejected anyway - Remove unreachable FlowAlreadyRegisteredError catch: no await exists between registry.get() and registry.add(), so asyncio cannot interleave another request in that window - Update FlowMeta.id and UploadFlowResponse.id field descriptions from stale "Deterministic UUIDv5" to plain "Flow identifier (UUID)" * test(serve): fix upload duplicate/replace tests after uuid4 change Both tests relied on uuid5(content) determinism to generate the same flow ID from identical data. With uuid4, each upload gets a fresh ID, so duplicate detection was never triggered. Tests now supply an explicit id field to exercise the 409/replace paths directly. * fix(serve): address code review suggestions - Fix test_write_is_atomic to glob for any *.tmp files rather than checking a hardcoded filename that could never exist - Remove incorrect noqa: B904 from validate_id_is_uuid (not in an except block); use `from None` instead - Add TTL cache (1 s) for FlowStore.list_ids() in FlowRegistry to avoid one filesystem glob per /health request; mutations invalidate immediately, warm_from_store and delete-scan bypass it - Document the UUID/stem dual-key alias invariant on _flows - Add test verifying create_serve_app() propagates load errors from the ThreadPoolExecutor startup path (fail fast, not silent empty registry) * [autofix.ci] apply automated fixes * fix: lfx serve no_env_fallback, deepcopy cycle, cross-worker delete (#13297) fix: address concurrency and isolation issues in lfx serve - Re-apply no_env_fallback to the per-request graph copy in the run and stream endpoints; deepcopy() drops graph.context so the flag was lost. - Register the copy in memo before recursive deepcopy calls in Component.__deepcopy__ so reference cycles are preserved. - Check the store directly in list_metas() so cross-worker deletes are reflected immediately instead of after the TTL cache window. - Remove the redundant upload-conflict test (already covered by test_upload_duplicate_without_replace_returns_409). Also mark test secrets with allowlist pragmas and fix two docstring lint warnings in the touched test file. * [autofix.ci] apply automated fixes * feat(lfx): WXO/TRM request-scoped variables for lfx serve (child of #13121) (#13327) * feat(lfx): WXO/TRM request-scoped variables for lfx serve global_vars Align lfx serve with the TRM/WXO credential contract on top of #13121: - Parse LANGFLOW_REQUEST_VARIABLES from global_vars payloads - ContextVar-backed lookup in VariableService (no os.environ mutation) - Activate request scope during execute_graph_with_capture Child of add-workers-and-upload-lfx (PR #13121). * [autofix.ci] apply automated fixes * fix(lfx): harden request-scoped variable resolution + add isolation t… (#13347) fix(lfx): harden request-scoped variable resolution + add isolation tests Addresses PR review of WXO/TRM request-scoped variables for lfx serve: - service: honor no_env_fallback in VariableService so model/KB credential resolution no longer falls back to os.environ under --no-env-fallback; correct the get_variable precedence docstring (5-step interleaved order) - request_scope: add a per-request no_env_fallback ContextVar; use precise Token type; document the None-vs-empty scope contract - common: activate/reset the no_env_fallback scope from graph.context - runtime_variables: log (instead of silently swallowing) a malformed or non-object LANGFLOW_REQUEST_VARIABLES blob; anchor the override comment to the TRM contract Tests: - add request-scope concurrency isolation + no-env-fallback suite - add execute_graph_with_capture wiring test (graph.context -> ContextVars) - give TestGraphExecution mock graphs a real context, fixing 11 tests that broke once the helper began reading graph.context * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Jordan Frazier <122494242+jordanrfrazier@users.noreply.github.com> * Update use of stem alias tracking to ensure proper deletes * fix(lfx): enforce no_env_fallback across all credential resolution paths Closes credential-isolation gaps in lfx serve and hardens request-scoped variable handling: - VariableService: skip the process-wide LANGFLOW_REQUEST_VARIABLES env read when env fallback is disabled (previously leaked process credentials for an empty-global_vars request despite --no-env-fallback). - Unified models: gate os.environ reads in get_api_key_for_provider and the connection-config fallbacks in instantiation.py (WatsonX URL/project-id, Ollama base-url, OpenRouter headers) on the no-env-fallback flag. - run_until_complete: propagate the caller's contextvars into the worker thread so request-scoped vars and the flag survive the thread hop. - Request variables: serialize structured (dict/list) values as valid JSON and drop nulls instead of producing lossy Python reprs or a truthy "None". - FlowRegistry: extract the duplicated store-alias scan shared by add/remove. Adds tests for request-scope isolation, credential/env gating, and contextvar propagation. * fix(lfx): close no_env_fallback credential leaks and harden serve isolation - credentials: honor no_env_fallback in get_all_variables_for_provider so served flows no longer leak process env (was defeating the _env_if_allowed guards in instantiation.py via pre-filled provider_vars) - loading: apply the no_env_fallback contract to table load_from_db column resolution (sibling of load_from_env_vars, previously still read os.getenv) - variable service: resolve request-scoped vars (exact name + x-langflow-global-var alias) before env fallback so a caller's per-request credential is never shadowed by a same-named process env var - runtime_variables: flatten the LANGFLOW_REQUEST_VARIABLES blob into graph context for parity between the ContextVar and load_from_db resolution paths - flow_store: clean up the partial temp file when an atomic write fails - commands: on multi-worker shutdown remove only the serve env vars we set, not the whole LFX_SERVE_* namespace - components: add check_component_env_writes lint banning os.environ writes; stop the mem0 component from writing the OpenAI key into the process environment * fix(lfx): contain corrupt flow-store files so one bad file can't crash worker startup FilesystemFlowStore.read() only caught FileNotFoundError, so a corrupted/partial {id}.json in a shared store (PVC corruption, an external writer killed mid-write) raised JSONDecodeError. warm_from_store() calls get() for every store id at startup with no per-file guard, so a single bad file would crash every worker's startup and 500 GET /flows. - read(): catch JSONDecodeError/OSError/UnicodeDecodeError, log, return None (treat as absent) so warm_from_store/list_metas/get skip it and other flows keep serving. - warm_from_store(): skip+log a flow that fails to reconstruct (corrupt JSON, or valid JSON referencing a component not available in this build) instead of aborting startup. - tests: corrupt-JSON read returns None; warm_from_store skips unloadable flows. * fix test -- request wins over env now * fix test. mock graph context correctly --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@logspace.ai> Co-authored-by: Himavarsha <40851462+HimavarshaVS@users.noreply.github.com>	2026-06-03 15:33:39 +00:00
Eric Hare	cc009c9133	feat(lfx): Bundle Separation and LFX Extension Framework (#13043) ... * feat(lfx): installed-package + seed-directory discovery for production install (LE-1022) Adds the read-only production install path for Modes A, B, and C of the Bundle Separation iteration. Manifest-shipping pip-installed distributions and seed-directory subdirectories are discovered at server startup and registered as Extensions at @official. * discovery.py: walks importlib.metadata.distributions() + the $LANGFLOW_SEED_DIR / /opt/langflow/bundles seed root; produces DiscoveredExtension records and typed errors for malformed manifests / configured-but-missing seed dirs. * registry.py: ExtensionRegistry service with the immutability invariant for installed and seed entries. Mutation verbs (uninstall, disable, enable, install, update_entry) all raise ExtensionImmutableError carrying the typed installed-extension-immutable / seed-directory-immutable code so the invariant is testable today; the CLI uninstall surface ships in B4. * lfx extension list: read-only inspector with text and JSON output for operators inspecting Mode B/C images. * Errors: four new typed codes (installed-extension-immutable, seed-directory-immutable, seed-directory-not-found, duplicate-extension-id) plus snapshot coverage in tests/unit/extension/test_errors.py. * Tests: 165 extension tests pass, including the LE-1022 acceptance cases -- three pip-installed wheels visible at @official, three seed bundles visible at @official, and the parametrized service-layer immutability check across every mutation verb. * Docs: docs/Deployment/deployment-extensions-production.mdx covers the Dockerfile template, k8s deployment notes, the bundle packaging convention (extension.json shipped via package-data), and troubleshooting for the typed error codes. * feat(lfx): add single-Bundle loader and LANGFLOW_COMPONENTS_PATH discovery (#12967) * feat(lfx): add extension manifest schema, validate CLI, and error formatter (LE-1014) Foundation for the Bundle Separation iteration. Defines what a valid extension.json looks like (Pydantic models + Draft 2020-12 JSON Schema), ships the offline `lfx extension validate` command, and ships the single `format_extension_error` function that every other extension-system module will use to render structured errors. What's in lfx.extension: - `ExtensionManifest` / `BundleRef` / `LangflowCompat` Pydantic models with `extra="forbid"` so unknown fields fail loudly. Deferred fields (`services`, `routes`, `hooks`, `starter_projects`, `userConfig`) are reserved as None-only so non-null values produce a dedicated `field-deferred-in-this-milestone` error instead of a generic schema wall. `bundles` accepts a list but rejects length > 1 with `multi-bundle-deferred-in-this-milestone` (validator-enforced; the loader re-checks at install time in LE-1015). - `schema.build_schema()` + `build_schema_json()` produce the publishable artifact at schemas.langflow.org/extension/v1.json. - `ExtensionError` typed envelope and `format_extension_error` -- one branch per discriminant. Codes are registered in `ERROR_CODES`; an `ExtensionError` constructed with an unknown code raises at construction time, preventing producers from shipping without a matching renderer. - `validate_extension` runs four passes: manifest discovery + schema, path-safety (no `..`, no absolute paths, no symlink escape), AST inspection of every `.py` (syntax, Component subclass present, build() declared, top-level `import *`, top-level I/O primitives), and an opt-in `--execute-imports` that runs each module in a subprocess with a temporary HOME / TMPDIR / LANGFLOW_CONFIG_DIR and LANGFLOW_*/LFX_* env vars stripped. - `lfx extension validate` and `lfx extension schema` typer subcommands. Acceptance-criteria coverage in tests/unit/extension/: - Round-trips every v0 manifest field; deferred fields rejected; multi-bundle rejected with the dedicated discriminant. - JSON Schema validates the v0 example and rejects 12 malformed manifests with distinct error paths (>= 10 required by the ticket). - Median default-validate runtime < 100ms on the basic template. - Crafted side-effect bundle: default validate does NOT execute it (canary file is never written); `--execute-imports` DOES execute it and the canary appears, while LANGFLOW_* env vars are NOT inherited by the subprocess. - Snapshot tests for every code in ERROR_CODES; a guard test verifies ERROR_CODES and the snapshot table are in lockstep so future additions cannot ship without a format branch and a snapshot. Wiring: `lfx extension` is a sub-app under the Authoring help panel so future tickets (LE-1016 init/dev, LE-1018 reload) can attach without colliding with the existing `lfx validate` (which validates flow JSON, not extensions). * fix(lfx): fall back to tomli on Python 3.10 in extension manifest loader tomllib is stdlib only on 3.11+, but lfx supports 3.10-3.13. Use the existing tomli runtime dependency as the 3.10 fallback (same API, so the import alias keeps the rest of the module unchanged). Fixes ModuleNotFoundError seen in CI on the 3.10 job. * Update src/lfx/tests/unit/extension/test_schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/extension/schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/cli/_extension_commands.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(lfx): add single-Bundle loader and LANGFLOW_COMPONENTS_PATH discovery (LE-1015) Introduces lfx.extension.loader: the runtime that turns an Extension on disk into LoadedComponent records keyed by ext:<bundle>:<Class>@<slot>. Two paths in: - load_extension(root): one manifest, one Bundle, registered at @official. Re-checks multi-bundle at runtime (defense-in-depth vs. the schema). - discover_inline_bundles(paths): each subfolder of LANGFLOW_COMPONENTS_PATH is a Bundle at @extra. Walk order is platform-independent (sorted dirs, user-declared path order). First-wins on duplicate names; second emits duplicate-inline-bundle warning that names both paths. Manifest-first precedence helpers (installed_extension_roots, manifest_owning_distributions, filter_plugin_entry_points) let callers of the legacy langflow.plugins entry-point loader skip distributions that ship a manifest, so component entry-points are not double-registered. New typed error codes: module-import-failed, duplicate-component-name, duplicate-distribution, duplicate-inline-bundle, inline-bundle-name-invalid. Each ships with a format branch and a snapshot test. Tests cover the AC: single-bundle happy path, multi-bundle rejection, missing/empty/no-Component bundle, duplicate class names, deterministic walk order, recursive discovery, inline-bundle first-wins + dot-dir skip + bundle.json metadata, manifest-first precedence partition, PEP-503 distribution-name canonicalization. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(lfx): address LE-1015 review feedback - Drop the unproduced duplicate-distribution error code; LE-1022 will add it once startup-time discovery has a place to surface it. Restores the invariant that every code in ERROR_CODES has a producer. - Clarify that intra-bundle relative imports are NOT supported in v0; only absolute references between bundle modules work in this milestone. - Use strict=False when re-resolving bundle_root in the walker; the path was already existence-checked, and a concurrent removal in the narrow window should not raise across the loader's public boundary. - Hoist the json import out of _read_inline_bundle_json's body. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(lfx): split extension loader into a small subpackage (LE-1015) Addresses the file-size feedback from the LE-1015 review. The single 870-line loader.py becomes a flat package keyed off the four section banners that already existed inline: loader/ __init__.py # re-exports the public surface _types.py # SLOT constants, LoadedComponent, LoadResult _discovery.py # filesystem walk + importlib.util orchestration _detection.py # Component subclass identification (MRO heuristic) _orchestrator.py # load_extension, discover_inline_bundles _plugins.py # manifest-first precedence over langflow.plugins Largest file is now _orchestrator.py at 440 LOC (was 870); every file is well under the 800-LOC project guideline. No behavior change: the public import paths from lfx.extension are unchanged, all 38 loader tests still pass. ``_canonicalize_distribution`` is now exported as ``canonicalize_distribution`` from ``loader._plugins`` (it's a stable PEP-503 helper that downstream modules will reach for, so it loses the private underscore). The test suite is split to mirror the package: tests/unit/extension/loader/ conftest.py # shared fixtures, FakeDist, autouse scrub test_load_extension.py # @official slot, identity, failure modes test_inline_bundles.py # LANGFLOW_COMPONENTS_PATH, @extra slot test_plugins.py # manifest-first precedence helpers test_types.py # LoadedComponent, LoadResult, code parity Each test file imports its own slice of the public API and pulls fixtures from conftest, so a reader looking at one banner can read it in isolation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: LangflowCompat -> LfxCompat * fix: Remove references to ticket * fix: encode maxItems constraint in schema * fix: deferred fields and schema version * Fix ruff errors * fix: align loader tests with renamed manifest API and strip ticket refs The merge of feat/extension-validate brought in the LfxCompat / compat rename, but the loader test fixtures still used LangflowCompat / bundle_api and failed at the manifest layer. Update conftest.py + test_load_extension.py to the post-rename API. Strip 17 LE-XXXX ticket references from loader source files, errors.py loader-specific comments, and the four loader test docstrings, matching the convention applied to LE-1014. Descriptive prose preserved. Promote _BUNDLE_NAME_RE to BUNDLE_NAME_RE on the manifest module so the loader's orchestrator no longer reaches across modules into a private name. * refactor(lfx): clarify broad except, log malformed bundle.json, expand test docstring - Document why _discovery.import_bundle_module catches BaseException (startup-time loader, must surface bad bundles as typed errors rather than abort). - Add debug-level logging when bundle.json is malformed or non-object so a stale-cache footgun is at least observable. - Expand test_skips_re_imported_class docstring so future maintainers don't accidentally weaken the __module__-equality guard if package-style relative imports get added later. Also drops the stale duplicate-distribution claim from the PR description; that code is correctly deferred to LE-1022 along with /all integration. * feat(lfx): wire Extension System into /all, pathsep-split LANGFLOW_COMPONENTS_PATH, emit duplicate-distribution Closes the four AC gaps the previous reviewer flagged on PR #12967: 1. /all integration: get_and_cache_all_types_dict now also calls a new import_extension_components() that loads installed Extensions via load_installed_extensions, loads inline bundles via discover_inline_bundles, and builds frontend-node templates with extension/bundle/extension_version fields stamped on. Failures are logged and skipped per bundle. 2. LANGFLOW_COMPONENTS_PATH is now split on os.pathsep so multi-entry env vars (e.g. /a:/b on POSIX) produce multiple components-path entries instead of one literal non-existent path. Empty segments and missing paths are skipped. 3. duplicate-distribution is a real producer: load_installed_extensions surfaces a typed warning on the winner LoadResult when two distributions share a canonical name, naming every involved manifest path. 4. Manifest-first precedence runtime wiring: new filter_component_entry_points loads each entry-point and only skips ones that resolve to a Component subclass on a manifest-shipping distribution. plugin_routes.load_plugin_routes now applies it so non-component entry-points (route registrars) keep loading per the AC's 'unaffected' promise. Added the previously-missing AC test for same-distribution component+non-component partition. Also makes _distribution_canonical_name defensive against MagicMock test seams. * fix(lfx): register extension components under namespaced ID; promote duplicate-distribution to error Addresses the latest review of PR #12967: P1: /all integration now keys the cache inner dict by LoadedComponent.namespaced_id (ext:<bundle>:<Class>@<slot>) rather than the bare class name. Templates also carry the namespaced_id as an explicit field so consumers that look at the value (not the key) still see the canonical address. This is the form the LE-1020 migration table will rewrite legacy class-name references to. P2: load_installed_extensions now appends duplicate-distribution to result.errors instead of result.warnings, so LoadResult.ok=False when two distributions share a canonical name. The winner's components still appear in result.components so flows already pinned to them keep working; only the conflict status changes. Updated test to assert errors + ok=False; added explicit assertion that the winner's components are still present. * fix(lfx): installed-distribution discovery accepts pyproject.toml manifest form Closes the latest review finding on PR #12967: the installed-distribution scan only looked for extension.json, ignoring distributions whose manifest lives in [tool.langflow.extension] inside pyproject.toml. The AC explicitly treats both as valid manifest forms. _distribution_manifest_path now: - Returns extension.json immediately when present (preserves precedence matching load_manifest's discovery order). - Falls back to pyproject.toml only when extension.json is absent AND the pyproject's [tool.langflow.extension] section is parseable. Validation reuses load_manifest itself so the rule lives in exactly one place; a stray pyproject.toml without the section is correctly ignored. Tests cover: pyproject-only discovery, pyproject-without-section ignored, extension.json wins on collision, end-to-end pyproject load at @official, and pyproject-form manifest-first entry-point suppression. * refactor(lfx): tighten loader invariants, surface silent skips, harden tests Addresses the latest review feedback on PR #12967: Type-level invariants (_types.py): - LoadedComponent.__post_init__ enforces that @extra components must NOT carry a distribution. The reverse (@official without distribution) is permitted because load_extension is also used for dev-mode loads against a working tree before pip install. - LoadResult docstring documents the partial-success contract: components may be non-empty when errors is non-empty (some files imported, others failed). Callers branching on ok get strict success. Silent-failure fixes (_orchestrator.py + settings/base.py): - inline-path-missing: a non-existent / non-dir LANGFLOW_COMPONENTS_PATH entry now produces a typed warning per skipped path so a typo no longer yields zero diagnostics. Settings-layer skip bumped from debug to warning for the same reason. - bundle-json-invalid: a malformed or non-object bundle.json now surfaces a typed warning instead of silently rewriting the user-declared id/version to derived values under the same bundle name. - no-component-subclass gating uses a call-local counter instead of result.errors so the diagnostic stays accurate when a future caller reuses a LoadResult (multi-bundle / batch wrapper scenarios). Test hardening: - test_re_imported_class_is_skipped_via_module_filter rewritten to actually exercise the __module__-equality check via sys.modules injection; previously passed via module-import-failed (relative-import failure), which would silently weaken if package registration changes. - test_user_declared_path_order_is_preserved: AC #8's multi-path order case (distinct bundles in [path_b, path_a]) was unasserted; added. - test_inline_module_import_failure_attributes_identity: AC #10's identity-on-partial-failure was covered for @official but not @extra; added. - test_uses_real_distributions_by_default tightened to assert ep placement (in kept, not in skipped) instead of exact-list equality, so a future Langflow-shipped manifest doesn't silently flip the assertion. bumped 64 -> 175 passing extension tests; 20 backend integration tests still pass. * fix(lfx): malformed pyproject manifests surface manifest-invalid instead of disappearing Closes the latest review finding on PR #12967: a pyproject.toml with a [tool.langflow.extension] section that has missing/invalid required fields was silently dropped because _pyproject_has_extension_section ran full schema validation via load_manifest and returned False on ValueError/TypeError. That conflated 'no section' with 'section malformed'. Fix: detect section presence only. _pyproject_has_extension_section now calls _read_pyproject_extension (TOML parse + key lookup, no schema check). Behavior: - Section absent or pyproject TOML unparseable -> False (treat as regular non-manifest package). - Section present and is a table (valid OR schema-invalid) -> True. - Section present but is not a table -> True; the author intended to declare an extension and load_extension will surface the typed error. This way a typo'd pyproject Extension produces a typed manifest-invalid LoadResult with extension_id attribution, and manifest-first precedence still suppresses its legacy component entry-points -- matching the 'typed load results on success/failure' contract for the supported pyproject manifest form. Tests: two new cases pin the behavior. test_malformed_pyproject_section_ surfaces_manifest_invalid asserts a typed load-failure result with distribution attribution; the second test pins manifest-first suppression for malformed pyproject distributions. * refactor(lfx): emit inline-path-unreadable, document reload contract, trim rot Closes the remaining nits on PR #12967: - inline-path-unreadable (new typed error code): a configured LANGFLOW_COMPONENTS_PATH entry that raises OSError on iterdir (typically permission-denied) now produces a typed LoadResult error carrying str(exc) instead of silently swallowing the message. - duplicate-inline-bundle hint trimmed: removed forward promise about hard-error-in-a-later-release; same actionability, no expiration. - discover_inline_bundles docstring trimmed from three paragraphs to two sentences (per CLAUDE.md anti-multi-paragraph rule). - _distribution_manifest_path docstring trimmed to one-liner. - installed_extension_roots dropped Used-by caller-narration list; manifest_owning_distributions docstring rewritten to call out the shadow-load risk for direct callers and point to load_installed_ extensions for the typed warning surface. - _discovery.import_bundle_module: replaced 'until that lands in a later milestone' rot with a single line ('Absolute imports only between bundle modules; relative imports unsupported.') AND added the single-load-per-process contract note documenting why LE-1018 reload must scrub registry/sys.modules before re-invoking the loader. - load_extension docstring grew a 'Single-load-per-process contract' block telling direct callers not to rely on this function for refresh. Tests: new test_unreadable_path_emits_inline_path_unreadable pins the OSError -> typed-error path. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(lfx): atomic-swap Bundle reload pipeline + endpoint + CLI (LE-1018) (#12979) * feat(lfx): add single-Bundle loader and LANGFLOW_COMPONENTS_PATH discovery (LE-1015) Introduces lfx.extension.loader: the runtime that turns an Extension on disk into LoadedComponent records keyed by ext:<bundle>:<Class>@<slot>. Two paths in: - load_extension(root): one manifest, one Bundle, registered at @official. Re-checks multi-bundle at runtime (defense-in-depth vs. the schema). - discover_inline_bundles(paths): each subfolder of LANGFLOW_COMPONENTS_PATH is a Bundle at @extra. Walk order is platform-independent (sorted dirs, user-declared path order). First-wins on duplicate names; second emits duplicate-inline-bundle warning that names both paths. Manifest-first precedence helpers (installed_extension_roots, manifest_owning_distributions, filter_plugin_entry_points) let callers of the legacy langflow.plugins entry-point loader skip distributions that ship a manifest, so component entry-points are not double-registered. New typed error codes: module-import-failed, duplicate-component-name, duplicate-distribution, duplicate-inline-bundle, inline-bundle-name-invalid. Each ships with a format branch and a snapshot test. Tests cover the AC: single-bundle happy path, multi-bundle rejection, missing/empty/no-Component bundle, duplicate class names, deterministic walk order, recursive discovery, inline-bundle first-wins + dot-dir skip + bundle.json metadata, manifest-first precedence partition, PEP-503 distribution-name canonicalization. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(lfx): address LE-1015 review feedback - Drop the unproduced duplicate-distribution error code; LE-1022 will add it once startup-time discovery has a place to surface it. Restores the invariant that every code in ERROR_CODES has a producer. - Clarify that intra-bundle relative imports are NOT supported in v0; only absolute references between bundle modules work in this milestone. - Use strict=False when re-resolving bundle_root in the walker; the path was already existence-checked, and a concurrent removal in the narrow window should not raise across the loader's public boundary. - Hoist the json import out of _read_inline_bundle_json's body. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(lfx): split extension loader into a small subpackage (LE-1015) Addresses the file-size feedback from the LE-1015 review. The single 870-line loader.py becomes a flat package keyed off the four section banners that already existed inline: loader/ __init__.py # re-exports the public surface _types.py # SLOT constants, LoadedComponent, LoadResult _discovery.py # filesystem walk + importlib.util orchestration _detection.py # Component subclass identification (MRO heuristic) _orchestrator.py # load_extension, discover_inline_bundles _plugins.py # manifest-first precedence over langflow.plugins Largest file is now _orchestrator.py at 440 LOC (was 870); every file is well under the 800-LOC project guideline. No behavior change: the public import paths from lfx.extension are unchanged, all 38 loader tests still pass. ``_canonicalize_distribution`` is now exported as ``canonicalize_distribution`` from ``loader._plugins`` (it's a stable PEP-503 helper that downstream modules will reach for, so it loses the private underscore). The test suite is split to mirror the package: tests/unit/extension/loader/ conftest.py # shared fixtures, FakeDist, autouse scrub test_load_extension.py # @official slot, identity, failure modes test_inline_bundles.py # LANGFLOW_COMPONENTS_PATH, @extra slot test_plugins.py # manifest-first precedence helpers test_types.py # LoadedComponent, LoadResult, code parity Each test file imports its own slice of the public API and pulls fixtures from conftest, so a reader looking at one banner can read it in isolation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(lfx): atomic-swap Bundle reload pipeline + endpoint + CLI (LE-1018) Five-stage reload (parallel staging load -> validate -> swap under write lock -> cleanup -> emit) for installed Bundles in Mode A. In-flight flows keep the pre-swap class via existing references; new flows pick up the post-swap class atomically; concurrent reloads on the same Bundle are rejected with reload-in-progress. Adds: * lfx/extension/registry.py -- BundleRegistry with per-bundle reload-in-progress guard and components_index.json writer * lfx/extension/reload.py -- the five-stage pipeline; events emission is stubbed (TODO LE-1017) so the swap mechanics can ship before the events service lands * loader: optional module_namespace param so Stage 1 lands in __reload_staging__.<id> instead of the live _lfx_ext.* namespace * errors: four new typed reload codes (reload-in-progress, reload-bundle-not-installed, reload-bundle-name-mismatch, reload-source-missing) with branch templates and snapshot tests * HTTP: POST /api/v1/extensions/{id}/bundles/{name}/reload, gated by the existing get_current_active_user dependency, returns 409 with a typed body for the in-progress collision case * CLI: lfx extension reload <id> [--bundle <name>] -- HTTP client against the dev server with text/json output and proper exit codes (--all is gated until LE-1019 lands the list endpoint) * tests: 16 reload-pipeline tests covering the AC matrix (rename round-trip, broken-bundle isolation, concurrent readers, in-flight flow, double-reload guard, bundle-name mismatch) plus 9 CLI client tests Mode A only. In Mode B/C bundle changes require a Docker image rebuild and the reload path is not exercised. The events emission in Stage 5 is intentionally stubbed -- the LE-1017 ticket will swap the body of _emit_bundle_reload_event in one place without touching the pipeline core. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * [autofix.ci] apply automated fixes * feat(lfx): add `extension init` and `extension dev` CLIs (LE-1016) (#12968) * feat(lfx): add extension manifest schema, validate CLI, and error formatter (LE-1014) Foundation for the Bundle Separation iteration. Defines what a valid extension.json looks like (Pydantic models + Draft 2020-12 JSON Schema), ships the offline `lfx extension validate` command, and ships the single `format_extension_error` function that every other extension-system module will use to render structured errors. What's in lfx.extension: - `ExtensionManifest` / `BundleRef` / `LangflowCompat` Pydantic models with `extra="forbid"` so unknown fields fail loudly. Deferred fields (`services`, `routes`, `hooks`, `starter_projects`, `userConfig`) are reserved as None-only so non-null values produce a dedicated `field-deferred-in-this-milestone` error instead of a generic schema wall. `bundles` accepts a list but rejects length > 1 with `multi-bundle-deferred-in-this-milestone` (validator-enforced; the loader re-checks at install time in LE-1015). - `schema.build_schema()` + `build_schema_json()` produce the publishable artifact at schemas.langflow.org/extension/v1.json. - `ExtensionError` typed envelope and `format_extension_error` -- one branch per discriminant. Codes are registered in `ERROR_CODES`; an `ExtensionError` constructed with an unknown code raises at construction time, preventing producers from shipping without a matching renderer. - `validate_extension` runs four passes: manifest discovery + schema, path-safety (no `..`, no absolute paths, no symlink escape), AST inspection of every `.py` (syntax, Component subclass present, build() declared, top-level `import *`, top-level I/O primitives), and an opt-in `--execute-imports` that runs each module in a subprocess with a temporary HOME / TMPDIR / LANGFLOW_CONFIG_DIR and LANGFLOW_*/LFX_* env vars stripped. - `lfx extension validate` and `lfx extension schema` typer subcommands. Acceptance-criteria coverage in tests/unit/extension/: - Round-trips every v0 manifest field; deferred fields rejected; multi-bundle rejected with the dedicated discriminant. - JSON Schema validates the v0 example and rejects 12 malformed manifests with distinct error paths (>= 10 required by the ticket). - Median default-validate runtime < 100ms on the basic template. - Crafted side-effect bundle: default validate does NOT execute it (canary file is never written); `--execute-imports` DOES execute it and the canary appears, while LANGFLOW_* env vars are NOT inherited by the subprocess. - Snapshot tests for every code in ERROR_CODES; a guard test verifies ERROR_CODES and the snapshot table are in lockstep so future additions cannot ship without a format branch and a snapshot. Wiring: `lfx extension` is a sub-app under the Authoring help panel so future tickets (LE-1016 init/dev, LE-1018 reload) can attach without colliding with the existing `lfx validate` (which validates flow JSON, not extensions). * fix(lfx): fall back to tomli on Python 3.10 in extension manifest loader tomllib is stdlib only on 3.11+, but lfx supports 3.10-3.13. Use the existing tomli runtime dependency as the 3.10 fallback (same API, so the import alias keeps the rest of the module unchanged). Fixes ModuleNotFoundError seen in CI on the 3.10 job. * Update src/lfx/tests/unit/extension/test_schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/extension/schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/cli/_extension_commands.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(lfx): add single-Bundle loader and LANGFLOW_COMPONENTS_PATH discovery (LE-1015) Introduces lfx.extension.loader: the runtime that turns an Extension on disk into LoadedComponent records keyed by ext:<bundle>:<Class>@<slot>. Two paths in: - load_extension(root): one manifest, one Bundle, registered at @official. Re-checks multi-bundle at runtime (defense-in-depth vs. the schema). - discover_inline_bundles(paths): each subfolder of LANGFLOW_COMPONENTS_PATH is a Bundle at @extra. Walk order is platform-independent (sorted dirs, user-declared path order). First-wins on duplicate names; second emits duplicate-inline-bundle warning that names both paths. Manifest-first precedence helpers (installed_extension_roots, manifest_owning_distributions, filter_plugin_entry_points) let callers of the legacy langflow.plugins entry-point loader skip distributions that ship a manifest, so component entry-points are not double-registered. New typed error codes: module-import-failed, duplicate-component-name, duplicate-distribution, duplicate-inline-bundle, inline-bundle-name-invalid. Each ships with a format branch and a snapshot test. Tests cover the AC: single-bundle happy path, multi-bundle rejection, missing/empty/no-Component bundle, duplicate class names, deterministic walk order, recursive discovery, inline-bundle first-wins + dot-dir skip + bundle.json metadata, manifest-first precedence partition, PEP-503 distribution-name canonicalization. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(lfx): address LE-1015 review feedback - Drop the unproduced duplicate-distribution error code; LE-1022 will add it once startup-time discovery has a place to surface it. Restores the invariant that every code in ERROR_CODES has a producer. - Clarify that intra-bundle relative imports are NOT supported in v0; only absolute references between bundle modules work in this milestone. - Use strict=False when re-resolving bundle_root in the walker; the path was already existence-checked, and a concurrent removal in the narrow window should not raise across the loader's public boundary. - Hoist the json import out of _read_inline_bundle_json's body. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(lfx): split extension loader into a small subpackage (LE-1015) Addresses the file-size feedback from the LE-1015 review. The single 870-line loader.py becomes a flat package keyed off the four section banners that already existed inline: loader/ __init__.py # re-exports the public surface _types.py # SLOT constants, LoadedComponent, LoadResult _discovery.py # filesystem walk + importlib.util orchestration _detection.py # Component subclass identification (MRO heuristic) _orchestrator.py # load_extension, discover_inline_bundles _plugins.py # manifest-first precedence over langflow.plugins Largest file is now _orchestrator.py at 440 LOC (was 870); every file is well under the 800-LOC project guideline. No behavior change: the public import paths from lfx.extension are unchanged, all 38 loader tests still pass. ``_canonicalize_distribution`` is now exported as ``canonicalize_distribution`` from ``loader._plugins`` (it's a stable PEP-503 helper that downstream modules will reach for, so it loses the private underscore). The test suite is split to mirror the package: tests/unit/extension/loader/ conftest.py # shared fixtures, FakeDist, autouse scrub test_load_extension.py # @official slot, identity, failure modes test_inline_bundles.py # LANGFLOW_COMPONENTS_PATH, @extra slot test_plugins.py # manifest-first precedence helpers test_types.py # LoadedComponent, LoadResult, code parity Each test file imports its own slice of the public API and pulls fixtures from conftest, so a reader looking at one banner can read it in isolation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(lfx): add `extension init` and `extension dev` CLIs (LE-1016) The two scaffolding CLIs an Extension author types: - `lfx extension init <target>` writes the basic single-Bundle template (manifest with $schema, README, .gitignore, one Component subclass + a pytest smoke test). AC #1: the generated extension validates clean against LE-1014. AC #2: the generated test file is a valid pytest module that exercises the component's build() method. AC #3: any --template other than 'basic' fails with a typed template-deferred-in-this-milestone error and a non-zero exit. Refuses to scaffold over a non-empty target dir. - `lfx extension dev <target>` validates the local extension, records its absolute path in <config_dir>/extensions/dev_extensions.json, prints reload instructions, and execs `langflow run` (or `python -m langflow` when langflow isn't on PATH). --skip-launch registers without launching (used by tests + external dev-server scripts); --skip-validate lets authors register a known-broken manifest to debug it under the loader. Stack: - Wave 0: error codes (extension-target-exists, extension-target-invalid, local-extension-missing) with format branches and snapshot tests. - Wave 1: lfx.extension.init_template -- pure-data scaffolder, no Typer dependency so the CLI is a thin shell over it. - Wave 1: lfx.extension.dev_registry -- atomic JSON state file under the langflow user-cache dir; helpers for register / list / unregister / load_dev_extensions / dev_extension_component_paths. - Wave 2: lfx.cli._extension_commands gains init/dev subcommands. - Wave 2: langflow.main lifespan hook reads the dev registry after bundle loading and extends components_path with each registered bundle dir, so the existing palette discovery picks up dev extensions. Missing paths surface as local-extension-missing warnings (AC #5) without aborting startup. Tests (84 new, 197 total in tests/unit/extension/): - test_init_template.py: AC scenarios + identifier derivation + deterministic file shape. - test_dev_registry.py: register/list/unregister round-trip, idempotent re-register refreshes timestamp, malformed state file treated as empty, missing-path warning, recovery when path reappears, env-var override precedence. - test_cli.py: AC #1 init->validate, AC #3 deferred templates, --skip-launch registers without launching, --skip-validate short-circuits the pre-flight pass. - test_errors.py: snapshot rows for all three new codes; the every-known-code-has-a-snapshot test enforces parity. LE-1018 (reload) reuses load_dev_extensions; LE-1022 (installed-pkg discovery) shares the components_path extension pattern. AC #4 ("boots Langflow with the extension visible in the palette within 5s") is delivered jointly by `extension dev` (registers + execs) and the lifespan hook (loads on startup). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(lfx): address LE-1016 review feedback Fixes the four HIGH issues + the elevated LOW from the review pass: 1. dev_extension_component_paths now forwards EVERY warning, not just local-extension-missing. Previously a duplicate-component-name (or any future warning code) was silently dropped, hiding real signal from the lifespan hook's logs. 2. Defensive emit when a LoadResult has components but source_path is None. The current loader always sets source_path, but a future hand-built LoadResult could violate that contract; we now surface a typed local-extension-missing error rather than dropping the extension silently. 3. Replaced the fragile ``min(len(parts))`` bundle-root selection with a relative-to-source-path measurement. Handles deep-vs-shallow sibling extensions correctly without depending on absolute path depth. 4. Generated README now documents the langflow/lfx prerequisite under the Develop section so authors know `pytest` requires the lfx environment, not just Python. 5. Forced LANGFLOW_LAZY_LOAD_COMPONENTS=false unconditionally in the `extension dev` exec env (was setdefault, which let a developer's global lazy-loading export silently hide their dev components from the palette and miss AC #4's 5s budget). Plus three MEDIUMs: - sys.modules cleanup in test_generated_test_file_runs_against_generated_component so a later test importing the same dotted path doesn't pick up a stale module from a deleted tmp_path. Component instantiation moved inside the try block because Component.__init__ uses inspect.getsourcefile against self.__class__'s still-live module. - Added regex-drift test that pins the init_template patterns to match manifest.py's so a schema regex change can't quietly produce invalid scaffolded manifests. - Added two new dev_registry tests covering the forward-all-warnings contract and the source_path=None defense. Tests: 201 passing (4 new); ruff check + format clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: LangflowCompat -> LfxCompat * fix: Remove references to ticket * fix: encode maxItems constraint in schema * fix: deferred fields and schema version * Fix ruff errors * fix: align loader tests with renamed manifest API and strip ticket refs The merge of feat/extension-validate brought in the LfxCompat / compat rename, but the loader test fixtures still used LangflowCompat / bundle_api and failed at the manifest layer. Update conftest.py + test_load_extension.py to the post-rename API. Strip 17 LE-XXXX ticket references from loader source files, errors.py loader-specific comments, and the four loader test docstrings, matching the convention applied to LE-1014. Descriptive prose preserved. Promote _BUNDLE_NAME_RE to BUNDLE_NAME_RE on the manifest module so the loader's orchestrator no longer reaches across modules into a private name. * fix(lfx): align init template with renamed manifest API After merging feat/extension-loader into this branch, two surfaces fell out of sync with the renamed manifest schema: - init_template generates extension.json with `lfx: {bundle_api: [1]}`, but the validator now requires `lfx: {compat: ["1"]}` per LfxCompat. This made `test_basic_template_validates_clean` fail with manifest-invalid (`lfx.compat: Field required; lfx.bundle_api: Extra inputs are not permitted`). - test_init_template_regexes_match_manifest_schema reads `manifest_mod._BUNDLE_NAME_RE`, but that symbol was promoted to public `BUNDLE_NAME_RE` in c63f84a591. Update the test to reference the public name; init_template's local copy is still private since it also covers `_EXTENSION_ID_RE`, which remains private upstream. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(lfx): append-only migration table + flow deserializer rewrite hook (#13024) * feat(lfx): add extension manifest schema, validate CLI, and error formatter (LE-1014) Foundation for the Bundle Separation iteration. Defines what a valid extension.json looks like (Pydantic models + Draft 2020-12 JSON Schema), ships the offline `lfx extension validate` command, and ships the single `format_extension_error` function that every other extension-system module will use to render structured errors. What's in lfx.extension: - `ExtensionManifest` / `BundleRef` / `LangflowCompat` Pydantic models with `extra="forbid"` so unknown fields fail loudly. Deferred fields (`services`, `routes`, `hooks`, `starter_projects`, `userConfig`) are reserved as None-only so non-null values produce a dedicated `field-deferred-in-this-milestone` error instead of a generic schema wall. `bundles` accepts a list but rejects length > 1 with `multi-bundle-deferred-in-this-milestone` (validator-enforced; the loader re-checks at install time in LE-1015). - `schema.build_schema()` + `build_schema_json()` produce the publishable artifact at schemas.langflow.org/extension/v1.json. - `ExtensionError` typed envelope and `format_extension_error` -- one branch per discriminant. Codes are registered in `ERROR_CODES`; an `ExtensionError` constructed with an unknown code raises at construction time, preventing producers from shipping without a matching renderer. - `validate_extension` runs four passes: manifest discovery + schema, path-safety (no `..`, no absolute paths, no symlink escape), AST inspection of every `.py` (syntax, Component subclass present, build() declared, top-level `import *`, top-level I/O primitives), and an opt-in `--execute-imports` that runs each module in a subprocess with a temporary HOME / TMPDIR / LANGFLOW_CONFIG_DIR and LANGFLOW_*/LFX_* env vars stripped. - `lfx extension validate` and `lfx extension schema` typer subcommands. Acceptance-criteria coverage in tests/unit/extension/: - Round-trips every v0 manifest field; deferred fields rejected; multi-bundle rejected with the dedicated discriminant. - JSON Schema validates the v0 example and rejects 12 malformed manifests with distinct error paths (>= 10 required by the ticket). - Median default-validate runtime < 100ms on the basic template. - Crafted side-effect bundle: default validate does NOT execute it (canary file is never written); `--execute-imports` DOES execute it and the canary appears, while LANGFLOW_* env vars are NOT inherited by the subprocess. - Snapshot tests for every code in ERROR_CODES; a guard test verifies ERROR_CODES and the snapshot table are in lockstep so future additions cannot ship without a format branch and a snapshot. Wiring: `lfx extension` is a sub-app under the Authoring help panel so future tickets (LE-1016 init/dev, LE-1018 reload) can attach without colliding with the existing `lfx validate` (which validates flow JSON, not extensions). * fix(lfx): fall back to tomli on Python 3.10 in extension manifest loader tomllib is stdlib only on 3.11+, but lfx supports 3.10-3.13. Use the existing tomli runtime dependency as the 3.10 fallback (same API, so the import alias keeps the rest of the module unchanged). Fixes ModuleNotFoundError seen in CI on the 3.10 job. * Update src/lfx/tests/unit/extension/test_schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/extension/schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/cli/_extension_commands.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(lfx): add single-Bundle loader and LANGFLOW_COMPONENTS_PATH discovery (LE-1015) Introduces lfx.extension.loader: the runtime that turns an Extension on disk into LoadedComponent records keyed by ext:<bundle>:<Class>@<slot>. Two paths in: - load_extension(root): one manifest, one Bundle, registered at @official. Re-checks multi-bundle at runtime (defense-in-depth vs. the schema). - discover_inline_bundles(paths): each subfolder of LANGFLOW_COMPONENTS_PATH is a Bundle at @extra. Walk order is platform-independent (sorted dirs, user-declared path order). First-wins on duplicate names; second emits duplicate-inline-bundle warning that names both paths. Manifest-first precedence helpers (installed_extension_roots, manifest_owning_distributions, filter_plugin_entry_points) let callers of the legacy langflow.plugins entry-point loader skip distributions that ship a manifest, so component entry-points are not double-registered. New typed error codes: module-import-failed, duplicate-component-name, duplicate-distribution, duplicate-inline-bundle, inline-bundle-name-invalid. Each ships with a format branch and a snapshot test. Tests cover the AC: single-bundle happy path, multi-bundle rejection, missing/empty/no-Component bundle, duplicate class names, deterministic walk order, recursive discovery, inline-bundle first-wins + dot-dir skip + bundle.json metadata, manifest-first precedence partition, PEP-503 distribution-name canonicalization. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(lfx): address LE-1015 review feedback - Drop the unproduced duplicate-distribution error code; LE-1022 will add it once startup-time discovery has a place to surface it. Restores the invariant that every code in ERROR_CODES has a producer. - Clarify that intra-bundle relative imports are NOT supported in v0; only absolute references between bundle modules work in this milestone. - Use strict=False when re-resolving bundle_root in the walker; the path was already existence-checked, and a concurrent removal in the narrow window should not raise across the loader's public boundary. - Hoist the json import out of _read_inline_bundle_json's body. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(lfx): split extension loader into a small subpackage (LE-1015) Addresses the file-size feedback from the LE-1015 review. The single 870-line loader.py becomes a flat package keyed off the four section banners that already existed inline: loader/ __init__.py # re-exports the public surface _types.py # SLOT constants, LoadedComponent, LoadResult _discovery.py # filesystem walk + importlib.util orchestration _detection.py # Component subclass identification (MRO heuristic) _orchestrator.py # load_extension, discover_inline_bundles _plugins.py # manifest-first precedence over langflow.plugins Largest file is now _orchestrator.py at 440 LOC (was 870); every file is well under the 800-LOC project guideline. No behavior change: the public import paths from lfx.extension are unchanged, all 38 loader tests still pass. ``_canonicalize_distribution`` is now exported as ``canonicalize_distribution`` from ``loader._plugins`` (it's a stable PEP-503 helper that downstream modules will reach for, so it loses the private underscore). The test suite is split to mirror the package: tests/unit/extension/loader/ conftest.py # shared fixtures, FakeDist, autouse scrub test_load_extension.py # @official slot, identity, failure modes test_inline_bundles.py # LANGFLOW_COMPONENTS_PATH, @extra slot test_plugins.py # manifest-first precedence helpers test_types.py # LoadedComponent, LoadResult, code parity Each test file imports its own slice of the public API and pulls fixtures from conftest, so a reader looking at one banner can read it in isolation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: LangflowCompat -> LfxCompat * fix: Remove references to ticket * fix: encode maxItems constraint in schema * fix: deferred fields and schema version * Fix ruff errors * fix: align loader tests with renamed manifest API and strip ticket refs The merge of feat/extension-validate brought in the LfxCompat / compat rename, but the loader test fixtures still used LangflowCompat / bundle_api and failed at the manifest layer. Update conftest.py + test_load_extension.py to the post-rename API. Strip 17 LE-XXXX ticket references from loader source files, errors.py loader-specific comments, and the four loader test docstrings, matching the convention applied to LE-1014. Descriptive prose preserved. Promote _BUNDLE_NAME_RE to BUNDLE_NAME_RE on the manifest module so the loader's orchestrator no longer reaches across modules into a private name. * feat(lfx): append-only migration table + flow deserializer rewrite hook Adds the migration layer of the Extension System: an append-only JSON table that maps three legacy component reference shapes (bare class name, old import path, pre-Phase-A namespaced slot) to the post-Phase-A canonical ext:<bundle>:<Class>@<slot> identifier, plus a deserializer hook that rewrites a saved-flow payload in place against that table on load. What landed: * lfx.extension.migration.schema -- Pydantic models for MigrationEntry + MigrationTable with per-entry validators (exactly one of bare/import/slot populated; canonical target shape) and table-level uniqueness check. * lfx.extension.migration.loader -- canonical in-repo path, threadsafe process-lifetime cache, typed errors on every failure mode. * lfx.extension.migration.rewrite -- node-by-node rewrite, idempotent on canonical refs, difflib-backed closest-match suggestion for unmapped references, cross-bucket ambiguity surfaces component-name-ambiguous instead of silently loading into the wrong bundle. * Wired into Graph.from_payload before validate_flow_for_current_settings so every saved-flow load goes through migration first. * scripts/migrate/check_migration_append_only.py -- CI guard that diffs the working-tree table against origin/main and rejects removals or target mutations; reordering and additions are allowed. * 34 new unit tests covering rewrite paths, loader failure modes, schema invariants, and the CI script behavior. What is deliberately deferred: * flow-migrated event emission. The events pipeline is unavailable in this iteration; the wiring point in Graph.from_payload is marked TODO and the MigrationReport already carries every field a future emitter needs. The shipped migration_table.json starts empty; entries land alongside the pilot bundle extraction in a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(frontend): palette Bundle reload action + loading + toasts (#13025) * feat(lfx): add extension manifest schema, validate CLI, and error formatter (LE-1014) Foundation for the Bundle Separation iteration. Defines what a valid extension.json looks like (Pydantic models + Draft 2020-12 JSON Schema), ships the offline `lfx extension validate` command, and ships the single `format_extension_error` function that every other extension-system module will use to render structured errors. What's in lfx.extension: - `ExtensionManifest` / `BundleRef` / `LangflowCompat` Pydantic models with `extra="forbid"` so unknown fields fail loudly. Deferred fields (`services`, `routes`, `hooks`, `starter_projects`, `userConfig`) are reserved as None-only so non-null values produce a dedicated `field-deferred-in-this-milestone` error instead of a generic schema wall. `bundles` accepts a list but rejects length > 1 with `multi-bundle-deferred-in-this-milestone` (validator-enforced; the loader re-checks at install time in LE-1015). - `schema.build_schema()` + `build_schema_json()` produce the publishable artifact at schemas.langflow.org/extension/v1.json. - `ExtensionError` typed envelope and `format_extension_error` -- one branch per discriminant. Codes are registered in `ERROR_CODES`; an `ExtensionError` constructed with an unknown code raises at construction time, preventing producers from shipping without a matching renderer. - `validate_extension` runs four passes: manifest discovery + schema, path-safety (no `..`, no absolute paths, no symlink escape), AST inspection of every `.py` (syntax, Component subclass present, build() declared, top-level `import *`, top-level I/O primitives), and an opt-in `--execute-imports` that runs each module in a subprocess with a temporary HOME / TMPDIR / LANGFLOW_CONFIG_DIR and LANGFLOW_*/LFX_* env vars stripped. - `lfx extension validate` and `lfx extension schema` typer subcommands. Acceptance-criteria coverage in tests/unit/extension/: - Round-trips every v0 manifest field; deferred fields rejected; multi-bundle rejected with the dedicated discriminant. - JSON Schema validates the v0 example and rejects 12 malformed manifests with distinct error paths (>= 10 required by the ticket). - Median default-validate runtime < 100ms on the basic template. - Crafted side-effect bundle: default validate does NOT execute it (canary file is never written); `--execute-imports` DOES execute it and the canary appears, while LANGFLOW_* env vars are NOT inherited by the subprocess. - Snapshot tests for every code in ERROR_CODES; a guard test verifies ERROR_CODES and the snapshot table are in lockstep so future additions cannot ship without a format branch and a snapshot. Wiring: `lfx extension` is a sub-app under the Authoring help panel so future tickets (LE-1016 init/dev, LE-1018 reload) can attach without colliding with the existing `lfx validate` (which validates flow JSON, not extensions). * fix(lfx): fall back to tomli on Python 3.10 in extension manifest loader tomllib is stdlib only on 3.11+, but lfx supports 3.10-3.13. Use the existing tomli runtime dependency as the 3.10 fallback (same API, so the import alias keeps the rest of the module unchanged). Fixes ModuleNotFoundError seen in CI on the 3.10 job. * Update src/lfx/tests/unit/extension/test_schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/extension/schema.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/cli/_extension_commands.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(lfx): add single-Bundle loader and LANGFLOW_COMPONENTS_PATH discovery (LE-1015) Introduces lfx.extension.loader: the runtime that turns an Extension on disk into LoadedComponent records keyed by ext:<bundle>:<Class>@<slot>. Two paths in: - load_extension(root): one manifest, one Bundle, registered at @official. Re-checks multi-bundle at runtime (defense-in-depth vs. the schema). - discover_inline_bundles(paths): each subfolder of LANGFLOW_COMPONENTS_PATH is a Bundle at @extra. Walk order is platform-independent (sorted dirs, user-declared path order). First-wins on duplicate names; second emits duplicate-inline-bundle warning that names both paths. Manifest-first precedence helpers (installed_extension_roots, manifest_owning_distributions, filter_plugin_entry_points) let callers of the legacy langflow.plugins entry-point loader skip distributions that ship a manifest, so component entry-points are not double-registered. New typed error codes: module-import-failed, duplicate-component-name, duplicate-distribution, duplicate-inline-bundle, inline-bundle-name-invalid. Each ships with a format branch and a snapshot test. Tests cover the AC: single-bundle happy path, multi-bundle rejection, missing/empty/no-Component bundle, duplicate class names, deterministic walk order, recursive discovery, inline-bundle first-wins + dot-dir skip + bundle.json metadata, manifest-first precedence partition, PEP-503 distribution-name canonicalization. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(lfx): address LE-1015 review feedback - Drop the unproduced duplicate-distribution error code; LE-1022 will add it once startup-time discovery has a place to surface it. Restores the invariant that every code in ERROR_CODES has a producer. - Clarify that intra-bundle relative imports are NOT supported in v0; only absolute references between bundle modules work in this milestone. - Use strict=False when re-resolving bundle_root in the walker; the path was already existence-checked, and a concurrent removal in the narrow window should not raise across the loader's public boundary. - Hoist the json import out of _read_inline_bundle_json's body. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(lfx): split extension loader into a small subpackage (LE-1015) Addresses the file-size feedback from the LE-1015 review. The single 870-line loader.py becomes a flat package keyed off the four section banners that already existed inline: loader/ __init__.py # re-exports the public surface _types.py # SLOT constants, LoadedComponent, LoadResult _discovery.py # filesystem walk + importlib.util orchestration _detection.py # Component subclass identification (MRO heuristic) _orchestrator.py # load_extension, discover_inline_bundles _plugins.py # manifest-first precedence over langflow.plugins Largest file is now _orchestrator.py at 440 LOC (was 870); every file is well under the 800-LOC project guideline. No behavior change: the public import paths from lfx.extension are unchanged, all 38 loader tests still pass. ``_canonicalize_distribution`` is now exported as ``canonicalize_distribution`` from ``loader._plugins`` (it's a stable PEP-503 helper that downstream modules will reach for, so it loses the private underscore). The test suite is split to mirror the package: tests/unit/extension/loader/ conftest.py # shared fixtures, FakeDist, autouse scrub test_load_extension.py # @official slot, identity, failure modes test_inline_bundles.py # LANGFLOW_COMPONENTS_PATH, @extra slot test_plugins.py # manifest-first precedence helpers test_types.py # LoadedComponent, LoadResult, code parity Each test file imports its own slice of the public API and pulls fixtures from conftest, so a reader looking at one banner can read it in isolation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(lfx): atomic-swap Bundle reload pipeline + endpoint + CLI (LE-1018) Five-stage reload (parallel staging load -> validate -> swap under write lock -> cleanup -> emit) for installed Bundles in Mode A. In-flight flows keep the pre-swap class via existing references; new flows pick up the post-swap class atomically; concurrent reloads on the same Bundle are rejected with reload-in-progress. Adds: * lfx/extension/registry.py -- BundleRegistry with per-bundle reload-in-progress guard and components_index.json writer * lfx/extension/reload.py -- the five-stage pipeline; events emission is stubbed (TODO LE-1017) so the swap mechanics can ship before the events service lands * loader: optional module_namespace param so Stage 1 lands in __reload_staging__.<id> instead of the live _lfx_ext.* namespace * errors: four new typed reload codes (reload-in-progress, reload-bundle-not-installed, reload-bundle-name-mismatch, reload-source-missing) with branch templates and snapshot tests * HTTP: POST /api/v1/extensions/{id}/bundles/{name}/reload, gated by the existing get_current_active_user dependency, returns 409 with a typed body for the in-progress collision case * CLI: lfx extension reload <id> [--bundle <name>] -- HTTP client against the dev server with text/json output and proper exit codes (--all is gated until LE-1019 lands the list endpoint) * tests: 16 reload-pipeline tests covering the AC matrix (rename round-trip, broken-bundle isolation, concurrent readers, in-flight flow, double-reload guard, bundle-name mismatch) plus 9 CLI client tests Mode A only. In Mode B/C bundle changes require a Docker image rebuild and the reload path is not exercised. The events emission in Stage 5 is intentionally stubbed -- the LE-1017 ticket will swap the body of _emit_bundle_reload_event in one place without touching the pipeline core. * feat(frontend): palette Bundle reload action + loading + toasts Adds the frontend half of the bundle reload flow. When the Bundle header is right-clicked or its overflow ("⋮") icon clicked, a Reload action fires POST /api/v1/extensions/{id}/bundles/{name}/reload and surfaces the result via the existing alert-store toast system. What landed (frontend only): * src/controllers/API/queries/extensions/ -- typed wire-format models (ReloadBundleResponse, ExtensionErrorPayload, ReloadInProgressDetail) and the useReloadBundle mutation hook. The hook unwraps the 409 `reload-in-progress` detail into a stable, parseable Error message so the UI can branch without reading status codes. * components/bundleHeaderActions.tsx -- new Select-based overflow menu next to the Bundle header chevron. Three toast paths: success (green, with components +/- delta), structural failure (red, with typed errors and inline hints), reload-in-progress (notice). Loading state swaps the kebab icon for a spinning Loader2 while the request is in flight. Renders nothing when no extension_id is on the bundle, so the static SIDEBAR_BUNDLES list is unaffected. * components/bundleItems.tsx -- wires the new actions in next to the chevron, plus a context-menu (right-click) capture that opens the same overflow trigger so keyboard / mouse / right-click all share one source of truth. * types/index.ts -- BundleItemProps.item gains an optional extension_id; took the opportunity to extract the SidebarBundle interface and tighten three pre-existing `any` types. * customization/feature-flags.ts -- ENABLE_EXTENSION_RELOAD gate, off by default until the bundle-list endpoint that populates extension_id per bundle ships. * controllers/API/helpers/constants.ts -- EXTENSIONS URL constant. * Tests: 7 component tests + 3 mutation-hook tests, all green. Total sidebar + extensions test count: 479 passing. Deferred: * Event-pipeline subscription is left as an inline TODO. The mutation response carries enough information to drive the toasts on its own today; once the events service lands the toast wiring will move to a `bundle_reloaded` / `bundle_reload_failed` listener so multi-tab and multi-worker swaps surface exactly once. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat: End to end bundle installation * fix: Review comments addressed * Update component_index.json * Update component_index.json * Update router.py * fix(docker): copy src/bundles before uv sync so workspace bundles resolve Each directory under ``src/bundles`` is a uv workspace member referenced by ``langflow-base`` (and the root project) as a path dependency. The Docker builders ran ``uv sync --no-install-project`` after copying only the top-level pyproject.toml files, so resolution failed with ``Distribution not found at: file:///app/src/bundles/<name>``. Copying the whole ``src/bundles`` tree (rather than enumerating each bundle) means a new bundle dropped under that dir does not require a Dockerfile edit. The full ``./src`` copy a few lines later produces the same final layer either way; this earlier copy just unblocks the dependency-resolution sync. Touched all builders that run a workspace-resolving uv sync: * docker/build_and_push.Dockerfile * docker/build_and_push_base.Dockerfile * docker/build_and_push_ep.Dockerfile * docker/build_and_push_with_extras.Dockerfile * docker/dev.Dockerfile (bind-mount instead of COPY) * Revert "fix(docker): copy src/bundles before uv sync so workspace bundles resolve" This reverts commit 5aa008a3cd. * feat: DuckDuckGo as Extension in new Bundle System (#13044) * feat: DuckDuckGo Extension for bundles * fix ruff errors * Update test_pilot_duckduckgo_upgrade.py * test(lfx): handle non-empty canonical migration table + editable installs - test_path_override_bypasses_cache: mirror the cached canonical table into the temp file instead of asserting it's empty. Drift in migration_table.json (the duckduckgo entries shipped with the B1 pilot) no longer breaks the cache-bypass invariant. - test_lfx_duckduckgo_ships_manifest: editable installs (pip install -e) surface only dist-info entries in dist.files, so we cannot use that path to find extension.json in the workspace venv. Detect editable mode via direct_url.json's PEP 660 marker and fall through to walking the source tree; non-editable wheel installs still exercise the dist.files path the loader uses at runtime. * chore: auto-bake note keys and regenerate backend locales/en.json [skip ci] * fix(docker): copy src/bundles before uv sync so workspace bundles resolve Each directory under ``src/bundles`` is a uv workspace member referenced by ``langflow-base`` (and the root project) as a path dependency. The Docker builders ran ``uv sync --no-install-project`` after copying only the top-level pyproject.toml files, so resolution failed with ``Distribution not found at: file:///app/src/bundles/<name>``. Copying the whole ``src/bundles`` tree (rather than enumerating each bundle) means a new bundle dropped under that dir does not require a Dockerfile edit. The full ``./src`` copy a few lines later produces the same final layer either way; this earlier copy just unblocks the dependency-resolution sync. Touched all builders that run a workspace-resolving uv sync: * docker/build_and_push.Dockerfile * docker/build_and_push_base.Dockerfile * docker/build_and_push_ep.Dockerfile * docker/build_and_push_with_extras.Dockerfile * docker/dev.Dockerfile (bind-mount instead of COPY) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: Review sweep * fix: More review comments addressed * Ruff check * docs: add bundle porting guide Step-by-step recipe for extracting a provider package from the in-tree ``src/lfx/src/lfx/components/<provider>/`` directory into a standalone Extension Bundle distribution under ``src/bundles/<provider>/``. The DuckDuckGo bundle is the reference; every section maps to a single copy-pasteable change and a verification command. Doc surfaces a forthcoming ``scripts/migrate/port_bundle.py`` automation helper for the mechanical bits; that script lands on the next branch together with the second-pilot port that validates the recipe end-to-end. * fix(extension): accept Output(method=...) in build-method validator The validator's static AST check looked for a literal ``build`` method on every Component subclass and emitted ``build-method-missing`` when absent. Real Langflow components -- including the production ``DuckDuckGoSearchComponent`` and the in-tree ``ArXivComponent`` -- do not declare a literal ``build``; they declare entry-points declaratively via ``outputs = [Output(name=..., method=<name>)]`` and the named method is what gets called. Result: every clean port hit a spurious ``build-method-missing`` error from ``lfx extension validate``. Fix: extend ``_has_build_method`` to also accept any class that names a method via ``Output(method="X")`` AND defines that method in the class body. The negative case ("Output(method=...) without a matching def") still fires -- a typo'd method name would crash at runtime, so the static check should keep flagging it. Two new tests in ``test_validate.py`` lock the contract: positive case mirroring duckduckgo / arxiv, negative case for typo'd method names. All 26 validator tests pass. PORTING.md updates fall out of running the recipe live against the duckduckgo bundle on this branch: * Validate path is ``src/bundles/<bundle>/src/lfx_<bundle>``, not the bundle root (the manifest lives next to ``__init__.py``). * Index regen needs ``LFX_DEV=1`` to skip the prebuilt-index fast path and uses ``scripts/build_component_index.py``. * Drop the migration-table JSON from the ruff invocation (ruff treats it as Python and complains about the top-level expression). * fix: Delete outdated components * fix(palette): wire reload kebab via DropdownMenu, not Select The reload kebab on the palette Bundle header was using Radix ``Select`` to back its overflow menu. ``Select`` is for picking a value, not for firing an action: ``onValueChange`` is gated by value-equality (so a re-click of the only item is a no-op), and the popover-portal click semantics interact poorly with the parent disclosure-trigger button. The combined effect: clicking ⋮ → Reload opened the popover and closed it, but never fired the network request, with no console error to point at. Switch to ``DropdownMenu`` (purpose-built action menu). ``DropdownMenuItem`` exposes ``onSelect`` which fires on every activation -- the same callback path keyboard navigation uses -- so clicking Reload reliably invokes the mutation. Test mocks updated to drive the DropdownMenu primitives instead of Select; all 8 bundleHeaderActions tests + the broader 437-test sidebar suite still pass. * fix(extension): route ddgs through the lockfile + drop bogus list endpoint hint Two reviewer findings, both about reproducibility / correctness of operator-facing surfaces. [P2] ``docker/build_and_push_base.Dockerfile`` previously installed ``ddgs`` via an unpinned ``uv pip install ddgs`` after the workspace sync. That made the base image non-reproducible: a future ``ddgs`` release would silently drift from the tested lock state on every rebuild. Fix: route ddgs through the locked sync. * Restore the ``duckduckgo`` extra in ``src/backend/base/pyproject.toml`` (``ddgs>=9.0.0``) as an internal "image-build sidecar". Public consumers still install ``lfx-duckduckgo`` directly; the extra exists only to keep ``ddgs`` resolved in the lockfile. * The Dockerfile now passes ``--extra duckduckgo`` to ``uv sync --frozen``, picking up the locked ``ddgs==9.14.1``. * The follow-on bundle install keeps ``--no-deps`` so it does not duplicate the now-locked ``ddgs`` / ``lfx`` / ``langchain-community``. [P3] ``langflow/api/v1/extensions.py`` returned a fix hint that pointed operators at ``GET /api/v1/extensions`` -- a route that does not exist in this PR (it lands with the LE-1019 list endpoint). Replaced with a reference to ``lfx extension list``, which is shipped here. * fix(compat): bridge langflow.components.* dynamically via meta path finder Commit 45552cd1df ("fix: Delete outdated components") removed the physical shim files under ``src/backend/base/langflow/components/`` that forwarded saved-flow imports like ``from langflow.components.processing.converter import convert_to_dataframe`` or ``import langflow.components.knowledge_bases.retrieval`` to their new ``lfx.components.*`` homes. Without those shims, dotted imports into ``langflow.components.<sub>.<leaf>`` failed at flow-load time -- the existing ``LangflowCompatibilityModule`` registers ``langflow.components`` itself in ``sys.modules`` but does not bridge submodules, so Python's import machinery falls through to the now-empty langflow.components directory and raises ``ModuleNotFoundError``. Replace the deleted physical-shim stack with a single ``MetaPathFinder`` in ``langflow/__init__.py`` that dynamically resolves every ``langflow.components.<rest>`` import to ``lfx.components.<rest>`` and registers the loaded lfx module in ``sys.modules`` under both names. The langflow- and lfx-prefixed imports share a single underlying module object, so class identity is preserved across the bridge -- ``isinstance`` checks against types resolved through either path keep working. The finder also carries a small first-segment override map for the few subpackages whose name diverged during the move; the only entry today is ``knowledge_bases`` -> ``files_and_knowledge``, matching the deleted shim's intent. Why a meta finder instead of restoring the physical shim files (option 1 from the scope analysis): the meta finder scales without per-bundle maintenance. Every future bundle extraction landed under ``lfx.components`` becomes reachable via the legacy ``langflow.components.<bundle>`` path immediately; nobody has to remember to add a parallel langflow shim. Six new unit tests in ``test_langflow_components_compat_shim.py`` lock the contract: dotted submodule resolution, helpers re-export, the ``knowledge_bases`` override, class identity preservation, top-level aliasing, and the "arbitrary extracted bundle" case that prevents regression for future ports. Verified pre-existing tests: * 17 dynamic-import integration tests pass. * The reload-route-guard suite still passes. * The Research Translation Loop starter-project test (which loads ArXivComponent) passes. * Update index.tsx * fix: Review pass on delivery * fix: Second review sweep, bare names * fix: Third review sweep * Resolve dotted imports and attribute chains Record import shape and flatten attribute chains so router references can be resolved across dotted imports and re-exports. Added ImportTarget dataclass, _attribute_chain helper, and switched IncludeCall/DecoratorRef to store attribute tuples. parse_file now records ImportTarget entries for imports and captures dotted parent/child chains for include_router and decorators. Replaced _resolve_var with _resolve_chain which handles "from" vs "module" imports, various import shapes (including import x.y and aliased imports), and prevents infinite recursion on re-export cycles. * One more sweep * Add seed-directory extension loading and docs Introduce filesystem "seed directory" extension support and authoring docs. Adds three documentation pages (quickstart, manifest reference, author guide) and wires them into the docs sidebar. Implement load_seed_extensions to discover/load bundles from $LANGFLOW_SEED_DIR (default /opt/langflow/bundles), export it from loader/__init__ and extension package, and integrate it into the components import pipeline. Handle installed-vs-seed shadowing by preferring installed distributions and appending a typed seed-bundle-shadowed ExtensionError; add the corresponding error code and message. Update schema doc link and add unit/integration tests to cover seed loading, determinism, shadowing behavior, and migration-target resolution. * Fix claims * Fix docasaurus build * Clean up the manual checklist * Update test_pilot_duckduckgo_upgrade.py * fix: Some wording issues with dogfooding * fix: Comments addressed * Update port_bundle.py * Update component_index.json * chore: auto-bake note keys and regenerate backend locales/en.json [skip ci] * fix: pytest testpaths glob and accurate scaffold output in port_bundle testpaths now uses ``src/bundles/*/tests`` so future bundle tests are picked up automatically without hardcoding each bundle at the root. pytest expands the glob via ``glob.iglob(..., recursive=True)``. Rewrote port_bundle.py's ``_render_migration_entries`` and ``_render_test_scaffold`` to match the actual conventions: * Migration entries now use ``bare_class_name``/``import_path``/ ``legacy_slot`` + ``target`` + ``added_in`` (the keys ``lfx.extension.migration.loader`` actually reads) instead of the invented ``from``/``to``/``release`` shape. * Test scaffold now imports ``load_migration_table`` and ``migrate_flow_payload`` -- the APIs the real tests use -- instead of a fictitious ``resolve_legacy_id``. Includes the ``migration_table`` fixture, ``_saved_flow``/``_saved_flow_node`` helpers, and the distribution-importable + manifest-shipped checks that mirror ``test_pilot_duckduckgo_upgrade.py``. Verified by rendering the scaffold for duckduckgo with synthetic plan data, dropping it into ``src/lfx/tests/integration/extension/``, and running pytest -- ``3 passed, 2 skipped`` (skips are the wheel-only checks, by design when run inside the lfx isolation venv). * [autofix.ci] apply automated fixes * fix: Review comments * Update test_discovery.py * feat: Port Arxiv to the Extension Framework (#13047) * feat(bundles): port arxiv as the second-pilot Bundle + porting helper Validates ``src/bundles/PORTING.md`` end-to-end by following its recipe against a clean candidate (``ArXivComponent``: no third-party runtime deps, no langflow-base extra, no deactivated duplicate). Touchpoints exercised: * Bundle skeleton at ``src/bundles/arxiv/`` mirroring duckduckgo. * In-tree provider directory removed from ``src/lfx/src/lfx/components/`` along with its three references in ``components/__init__.py``. * Workspace wiring: dep, ``[tool.uv.sources]``, ``[tool.uv.workspace]`` members, lockfile. * Migration table: bare-name + two import-path forms + legacy_slot entry. * Component index regenerated via ``LFX_DEV=1`` (forces dynamic discovery; without it the script reproduces stale entries). * Integration test ``test_pilot_arxiv_upgrade.py`` mirroring the duckduckgo pilot suite; 5 tests pass against the workspace install. PORTING.md updates fall out of running the recipe live: * Validate path is ``src/bundles/<bundle>/src/lfx_<bundle>``, not the bundle root (the manifest lives next to ``__init__.py``). * Index regen needs ``LFX_DEV=1`` to skip the prebuilt-index fast path. * Drop the migration-table JSON from the ruff invocation (ruff treats it as Python and complains about the top-level expression). ``scripts/migrate/port_bundle.py`` is the mechanical helper referenced from § Automation: stdlib-only, dry-run by default, refuses on invalid input, and intentionally leaves migration-table edits + integration-test authoring to a human (release version + bare-name uniqueness require judgement). Three guard rails verified: invalid bundle name, existing-target-bundle, missing in-tree provider. * chore: auto-bake note keys and regenerate backend locales/en.json [skip ci] * Update Research Translation Loop.json * Update .secrets.baseline * fix: Move bundle test for arxiv * Update PORTING.md * Update component_index.json * chore: auto-bake note keys and regenerate backend locales/en.json [skip ci] * Update component_index.json * [autofix.ci] apply automated fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * [autofix.ci] apply automated fixes * chore: auto-bake note keys and regenerate backend locales/en.json [skip ci] * Update component_index.json * Update component_index.json * Update component_index.json * fix: empty cache dict on reload * Lint fixes * Update test_components_cache_integration.py * Update test_reload.py * Hardening pass * Update test_init_template.py * fix: resolve cross-source bundle-name shadowing before registry population The reload pipeline reads ``live.source_path`` from the registry on every call. Previously, the registry-population loop in ``import_extension_components`` only special-cased installed-shadows-seed; for every other pair (seed/dev, seed/inline, dev/inline, installed/dev, installed/inline) it silently overwrote earlier records via last-wins iteration order. A stale dev registration whose ``source_path`` pointed at a different filesystem location could clobber the seed record's ``source_path``; reload would then walk the dev path while the operator edited the seed copy on disk -- producing 200 OK with empty deltas on every reload, including for syntactically broken edits. Generalize the dedup pass to every (earlier, later) pair using the explicit precedence ``installed > seed > dev > inline``, applied before both registry population AND palette template construction so the two read from the same winning source. Add a new generic ``bundle-shadowed`` typed error code for the pairs the existing ``seed-bundle-shadowed`` did not cover; keep ``seed-bundle-shadowed`` for the documented installed- over-seed pair so existing CLI exit-code logic and snapshot tests stay intact. Both codes are warn-only in ``lfx extension list``. Also add an INFO log line in reload Stage 1 with the resolved ``source_path`` so the next "200 OK with empty deltas" repro can be triaged from the server log alone -- if the path logged is not the path the operator was editing, this dedup is what to look at. Includes a regression test (``test_seed_bundle_shadows_dev_emits_generic_bundle_shadowed``) that asserts both halves: seed wins in the BundleRegistry AND the registry's ``source_path`` is the seed path, not the stale dev path. * Update component_index.json * fix: widen lfx-* bundles' requires-python to <3.15 to match langflow root The two pilot bundles (``lfx-arxiv``, ``lfx-duckduckgo``) were scaffolded by ``scripts/migrate/port_bundle.py`` whose template hard-coded ``requires-python = ">=3.10,<3.14"``. Because both bundles are uv workspace members of the langflow root, that cap leaked into every workspace-level resolve: ``cd src/lfx && uv sync`` (the path ``make lfx_tests`` takes) refuses to pick a Python 3.14 interpreter even though lfx itself, langflow, and langflow-base all advertise ``>=3.10,<3.15``. Hosts with 3.14 installed see: error: The requested interpreter resolved to Python 3.14.5, which is incompatible with the project's Python requirement: `>=3.10, <3.14`. Fix at the source so future ``port_bundle.py`` runs do not regress this: template emits ``<3.15``, and the two existing emitted pyprojects are bumped in lockstep. ``uv.lock`` regenerates with the wider range. Verified ``make lfx_tests`` resolves cleanly on a host with both 3.13.12 and 3.14.5 installed; the focused extension slice runs to completion. * Update __init__.py * Update src/lfx/tests/unit/extension/migration/test_rewrite.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/extension/loader/_plugins.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update docs/docs/Deployment/deployment-extensions-production.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lfx/src/lfx/extension/loader/_orchestrator.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update docs/docs/Develop/extensions-author-guide.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update docs/docs/Develop/extensions-manifest.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: Coderabbit review suggestions * Template updates * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * Tweaks to bundle hot reload * [autofix.ci] apply automated fixes * chore: Address review comments by @Cristhianzl * [autofix.ci] apply automated fixes * Update BUNDLE_API.md * Update component_index.json * Update component_index.json * Update Structured Data Analysis Agent.json * fix: Next round of review comments * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-05-18 17:36:56 +00:00
Mendon Kissling	71fbf5ff00	docs: cut version 1.9.0 (#12681) ... * version-1.9.0-docs * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>	2026-04-14 02:07:01 +00:00
Mendon Kissling	3ee4bd57eb	docs: test harness for api reference code samples (#12338) ... * curl-examples-and-tests * move-curl-examples * docs-add-existing-js-and-python-examples * add-python-and-js-examples * use-code-snippet-not-code-block * remove-unused-ts-files * add-gitignore-for-docs-pycache * test-api-commands-with-langflow-env-var * add-fixtures-and-makefile-tests-pass * no-action * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * block-ruff-check-for-docs-examples * add-horizontal-scrolling-and-pin-copy-button --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>	2026-04-03 16:45:15 +00:00
Mendon Kissling	2d32e5269c	docs: lfx readme content (#11870) ... * docs-add-lfx-content-to-readme * github-link-syntax * allowlist-blocklist	2026-03-18 18:31:57 +00:00
Rico Furtado	348b1b86ce	feat: Version 1.2 - comprehensive database migration guidelines using… (#10519) ... * feat: Version 1.2 - comprehensive database migration guidelines using the Expand-Contract pattern * Update src/backend/base/langflow/alembic/DB-MIGRATION-GUIDE.MD Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Cleanup text and typos * feat: Implement migration validation workflow and add migration validator scripts * Update src/backend/base/langflow/alembic/migration_validator.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/backend/base/langflow/alembic/migration_validator.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/backend/base/langflow/alembic/migration_validator.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: moved the test_migrations directory to under tests * feat: Added migration validator to pre-commit check. * fix: improved test performance. * fix: optimized attribute resolution in migration validator * feat: add comprehensive tests for migration validator and guidelines * fix: Lint is complaining about shebang declared but not being used. * fix: Shebang reinstated. * Update src/backend/base/langflow/alembic/DB-MIGRATION-GUIDE.MD Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/workflows/migration-validation.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: color improvments * Update .github/workflows/migration-validation.yml Removed Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/workflows/migration-validation.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * ci: Created relative paths for CI * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * [autofix.ci] apply automated fixes (attempt 3/3) * fix: Component index json. * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * [autofix.ci] apply automated fixes (attempt 3/3) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>	2025-11-24 23:09:11 +00:00
Madhavan	d0f95fd9b9	test: catch import errors upfront (#10632) ... * Convert to async and ruff-friendly print * Implement the checking into existing test file itself * Remove the newly introduced lfx test which is now incorporated into existing tests * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * [autofix.ci] apply automated fixes (attempt 3/3) * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * [autofix.ci] apply automated fixes (attempt 3/3) * Run make build_component_index after merging latest from main * [autofix.ci] apply automated fixes * Revert "docs: update component documentation links to individual pages" This reverts commit 1da51d4ccb. * build component index after origin/main merge into feature branch * [autofix.ci] apply automated fixes --------- Co-authored-by: Madhavan <cxo@ibm.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Mendon Kissling <59585235+mendonk@users.noreply.github.com>	2025-11-24 19:02:06 +00:00
Wallgau	e9d1c2fb7d	Chore: enforce no any type lint (#10461) ... * chore(frontend): enforce no explicit any types in lint for changed files - Add noExplicitAny rule to Biome configuration - Update pre-commit hook to only check staged files (not entire codebase) - Add check-format:staged npm script for manual checks - Fix biome schema version to match installed version (2.1.1) * add lint to biome to enforce not using any in commited files only --------- Co-authored-by: Olfa Maslah <olfamaslah@Olfas-MacBook-Pro.local> Co-authored-by: Deon Sanchez <69873175+deon-sanchez@users.noreply.github.com>	2025-10-31 19:23:28 +00:00
Gabriel Luiz Freitas Almeida	d6b6e88951	chore: enhance GitHub Actions comments for component index updates (#10291) ... * chore: update pre-commit configuration to refine exclude patterns Modified the exclude pattern for the detect-secrets hook to prevent false positives by excluding the specific component_index.json file in addition to the docs directory. This change enhances the accuracy of secret detection during pre-commit checks. * chore: update ruff exclude patterns to include component_index.json Added the component_index.json file to the exclude patterns in the ruff configuration to prevent false positives during linting. This change enhances the accuracy of code quality checks. * chore: enhance GitHub Actions comments for component index updates Updated the GitHub Actions workflow to improve the commenting mechanism for component index updates. Added logic to delete previous comments from the GitHub Actions bot to prevent duplicates and included a marker in the comment body for better tracking. This change ensures that users receive clear instructions on updating the component index when necessary. --------- Co-authored-by: Edwin Jose <edwin.jose@datastax.com>	2025-10-16 12:28:32 +00:00
Gabriel Luiz Freitas Almeida	424b6202b5	ci: update workflows and extend detect-secrets exclude (#10286) ... * chore: update pre-commit configuration to exclude specific JSON file from secrets detection - Modified the exclude pattern for the detect-secrets hook to prevent false positives for the component_index.json file located in src/lfx/src/lfx/_assets. * ci: update GitHub Actions workflow to enhance security for pull request handling - Changed the event trigger from `pull_request` to `pull_request_target` to improve security when handling forked pull requests. - Updated conditions for repository checkout and dependency installation to ensure safe execution only for same-repo pull requests. - Adjusted PR comment conditions to reflect the new event trigger, maintaining functionality for both community forks and same-repo updates.	2025-10-15 14:42:38 +00:00
Mendon Kissling	c59bfc875a	docs: warnings for dotenv vulnerability (#10138) ... * dotenv-warnings-and-164-patch Dotenv warnings and 164 patch. * Apply suggestions from code review * remove-pragma-flags * Apply suggestion from @mendonk * Apply suggestion from @mendonk * Apply suggestion from @mendonk --------- Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>	2025-10-07 18:10:36 +00:00
Mendon Kissling	6a2b013835	docs: exclude docs directory from pre-commit hook (#10140) ... dont-run-detect-secrets-in-docs-folders Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>	2025-10-07 13:21:44 +00:00
Gabriel Luiz Freitas Almeida	771d08d12c	chore: add detect-secrets pre-commit hook and baseline file (#8655) ... * chore: add detect-secrets hook to pre-commit configuration for API key scanning * feat: add .secrets.baseline file for secret detection configuration This commit introduces a new .secrets.baseline file that outlines the configuration for secret detection, including the plugins and filters used, as well as the results of the secret scans across various files. This addition enhances the security posture by providing a baseline for identifying sensitive information in the codebase. * chore: update .secrets.baseline with additional filters and secret verification status This commit enhances the .secrets.baseline file by adding a new filter for baseline file detection and updating existing entries to include the 'is_secret' status for various files. These changes improve the clarity and effectiveness of secret detection across the codebase.	2025-09-30 19:51:36 +00:00
Mendon Kissling	bcb8d7ed5f	fix: exclude docs folder from local biome check (#9799) ... exclude-docs-from-biome-check Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>	2025-09-30 16:14:51 +00:00
Yuqi Tang	d0e4e7d1cc	feat: Add template tests (#9083) ... * add template tests * remove files * adding validate flow build * add validate endpoint and flow execution * Update .github/workflows/template-tests.yml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/backend/base/langflow/utils/template_validation.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * [autofix.ci] apply automated fixes * change workflow running * add ci * fix test * fix test * delete when push * fix: Exclude template tests from unit test bundle Template tests are already run separately in CI via the test-templates job. This change prevents duplicate execution and eliminates timeout failures in the unit test suite by excluding slow template execution tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: Exclude template tests from unit test bundle Template tests are already run separately in CI via the test-templates job. This change prevents duplicate execution and eliminates timeout failures in the unit test suite by excluding slow template execution tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: Exclude template tests from unit test bundle Template tests are already run separately in CI via the test-templates job. This change prevents duplicate execution and eliminates timeout failures in the unit test suite by excluding slow template execution tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: Remove remaining merge conflict markers 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: Improve validate.py unit tests to eliminate CI failures Fixed 4 failing tests in test_validate.py: - test_code_with_syntax_error: Better error message handling for syntax errors - test_raises_error_for_missing_function: Handle StopIteration along with ValueError - test_creates_simple_class: Use optional constructor parameter to avoid TypeError - test_handles_validation_error: Use proper ValidationError constructor from pydantic_core - test_creates_context_with_langflow_imports: Remove invalid module patching - test_creates_mock_classes_on_import_failure: Use proper import mocking All 50 validate tests now pass consistently, improving CI stability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * enhance: Add comprehensive edge case tests for template_validation.py Added 6 additional test cases to improve coverage of template_validation.py: - test_validate_stream_exception: Tests Graph.validate_stream() exception handling - test_code_validation_other_exceptions: Tests TypeError/KeyError/AttributeError handling - test_vertices_sorted_without_end_vertex_events: Tests variable usage tracking - test_vertex_count_tracking: Tests vertex_count increment paths - test_empty_lines_in_stream: Tests empty line handling in event streams - test_event_stream_validation_exception: Tests exception handling in _validate_event_stream These tests target the remaining 7 uncovered lines to maximize coverage percentage. Total tests: 40 (all passing) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>	2025-07-28 18:32:24 +00:00
Mike Fortman	f75d9a20e0	refactor: Update icon dark mode comparison (#9060) ... * Update icon dark mode comparison * [autofix.ci] apply automated fixes * coderabbit fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>	2025-07-16 14:15:14 +00:00
Mike Fortman	0f89e39da1	feat: Move to Biome for linting and formatting (#8997) ... * init biome * lint * format * unused vars * more unused vars * error fixes * import ordering * test precommit hook * add precommit hook * [autofix.ci] apply automated fixes * remove prettier and eslint and update gh actions * pre-commit update * ✨ (Makefile): add new targets 'biome' and 'biome_check' to run biome check and format on frontend code. * 🔧 (Makefile): rename 'biome' target to 'format_frontend' for clarity and consistency 🔧 (Makefile): rename 'biome_check' target to 'format_frontend_check' for clarity and consistency * 📝 (biome.json): Update a11y rule in biome.json to turn off 'noStaticElementInteractions' warning 🔧 (apiModal/code-tabs.tsx): Remove unused 'autologin' variable in APITabsComponent ♻️ (global-variable-modal.tsx): Simplify GeneralGlobalVariableModal component by removing unused props definition * 📝 (biome.json): Remove 'debug' from allowed console methods to improve code quality 🔧 (index.tsx): Replace console.debug with console.log for better logging consistency ♻️ (index.tsx): Refactor UpdateAllComponents function signature to remove unnecessary empty object parameter * fix console rules * 📝 (biome.json): update a11y rule to warn for noStaticElementInteractions to improve accessibility compliance. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>	2025-07-15 18:46:51 +00:00
Gabriel Luiz Freitas Almeida	d1b3b99dcb	chore: update pre-commit configuration to use local ruff hooks (#9048)	2025-07-14 17:47:06 -03:00
Gabriel Luiz Freitas Almeida	13386d4118	chore: update pre-commit hooks to latest versions (#8938) ... - Bumped pre-commit-hooks from v4.1.0 to v5.0.0. - Updated ruff-pre-commit from v0.8.3 to v0.12.2 for improved linting capabilities.	2025-07-10 18:19:12 +00:00
Gabriel Luiz Freitas Almeida	dd68a97567	feat: return variable value if it is a generic variable (#5366) ... * fix: update pre-commit configuration for ruff formatting args * fix: update variable type constant from GENERIC_TYPE to CREDENTIAL_TYPE * feat: enhance variable service to handle decryption for generic type and update default variable type to CREDENTIAL_TYPE * feat: add abstract method to retrieve all variables for a user in VariableService * feat: implement get_all method in KubernetesSecretService to retrieve and decrypt user variables * refactor: update variable tests to use fixtures for generic and credential types - Renamed and refactored test fixtures for better clarity and reusability. - Updated tests to utilize `generic_variable` and `credential_variable` fixtures instead of hardcoded values. - Enhanced assertions to ensure correct handling of variable types, including encryption for credential variables and decryption for generic variables. - Improved test structure for creating, reading, updating, and deleting variables, ensuring consistency across test cases. * refactor: update get_all method signatures in variable services to return VariableRead - Changed return type of the get_all method in VariableService, KubernetesSecretService, and DatabaseVariableService from list[Variable | None] to list[VariableRead]. - This update enhances type consistency across variable services and aligns with the new VariableRead model for improved data handling. * fix: update variable type assertion in test_update_variable to CREDENTIAL_TYPE - Changed the assertion in the `test_update_variable` test to verify that the result type is now `CREDENTIAL_TYPE` instead of `GENERIC_TYPE`. - This update aligns the test with recent changes in variable type handling, ensuring accurate validation of variable updates. * fix: update variable type assertion in test_create_variable to CREDENTIAL_TYPE - Changed the assertion in the `test_create_variable` test to verify that the result type is now `CREDENTIAL_TYPE` instead of `GENERIC_TYPE`. - This update ensures consistency with recent changes in variable type handling and improves the accuracy of the test validation.	2024-12-19 17:04:00 +00:00
Gabriel Luiz Freitas Almeida	e25872b287	ci: Update pre-commit configuration to use ruff for linting and formatting (#5360) ... chore: update pre-commit configuration to use ruff for linting and formatting	2024-12-19 15:24:01 +00:00
Gabriel Luiz Freitas Almeida	4519f9ffa8	chore: Add 'types' field to pre-commit hooks for ruff check and format (#4006)	2024-10-03 09:53:58 -07:00
Christophe Bornet	b11207bef3	feat: Add pre-commit hook for ruff (#3960) ... Add pre-commit hook	2024-10-01 12:50:19 +02:00
Gabriel Luiz Freitas Almeida	a9cb7b0f5e	Update linting workflows for frontend and Python code (#2171) ... * chore: Update pre-commit hooks and dependencies * chore: Add linting workflow for frontend code * chore: Update linting workflow for Python code and include tests in pull requests * chore: Add Ruff style check workflow for Python code	2024-06-14 06:27:48 -07:00
ogabrielluiz	2cffd76135	feat: Update pre-commit configuration ... The pre-commit configuration file `.pre-commit-config.yaml` was updated to remove the `pretty-format-json` hook and exclude `tsconfig.*.json` files. This change improves the formatting consistency of the codebase. Note: The commit message has been generated based on the provided code changes and recent commits.	2024-05-30 19:13:15 -03:00
Gabriel Luiz Freitas Almeida	8230434e19	Add CLI command to create API key for default superuser with AUTO_LOGIN enabled (#1965) ... * chore: Add CLI command to create API key for default superuser with AUTO_LOGIN enabled * chore: Add pyperclip dependency for cross-platform clipboard functionality * chore: Update API key banner to copy the key to clipboard * chore: Update langchainhub package version to 0.1.16 and openai package version to 1.30.3 * chore: Update pre-commit hooks to fix mixed line endings and trailing whitespace in Python, JavaScript, and TypeScript files * style(__main__.py): add type ignore comment for import of pyperclip to suppress type checking error	2024-05-24 13:05:15 -07:00
Gabriel Luiz Freitas Almeida	2920e69593	🔧 (.pre-commit-config.yaml): Add eslint@9.1.1 as a dependency and enable autofix for pretty-format-json hook ... 🔧 (.eslintrc.json): Update eslint configuration to include additional plugins, parser, parserOptions, and env settings	2024-05-02 19:27:40 -03:00
cristhianzl	9cd3925233	remove parser	2024-05-02 18:54:01 -03:00
cristhianzl	37ca646f2c	Merge branch 'dev' of https://github.com/langflow-ai/langflow into dev	2024-05-02 18:51:31 -03:00
cristhianzl	33ad0430d3	🔧 (.pre-commit-config.yaml): add eslint-plugin-react@latest as a dependency to improve linting for React components ... 🔧 (.eslintrc.json): update eslint configuration to include additional plugins, parser, parserOptions, and env settings to improve linting for React components and TypeScript files ♻️ (index.tsx): remove unnecessary empty line to improve code readability	2024-05-02 18:51:27 -03:00
Gabriel Luiz Freitas Almeida	c9a9ca2958	Update .pre-commit-config.yaml to enable fail_fast option and add eslint repository	2024-05-02 18:51:22 -03:00
Gabriel Luiz Freitas Almeida	89595d4a14	Update pre-commit-config.yaml and Makefile	2024-05-02 17:07:23 -03:00
Gabriel Luiz Freitas Almeida	2eb2f3bec6	Add pre-commit hooks for eslint and ruff (#1817)	2024-05-02 17:02:06 -03:00